* [dpdk-dev] [PATCH 1/3] doc: fix matrix CSS for recent sphinx
2020-03-11 23:01 [dpdk-dev] [PATCH 0/3] refresh NIC features matrix Thomas Monjalon
@ 2020-03-11 23:01 ` Thomas Monjalon
2020-03-11 23:01 ` [dpdk-dev] [PATCH 2/3] doc: remove empty columns from NIC features matrix Thomas Monjalon
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2020-03-11 23:01 UTC (permalink / raw)
To: dev
Cc: rahul.lakkireddy, qi.z.zhang, xiao.w.wang, xavier.huwei,
beilei.xing, wenzhuo.lu, qiming.yang, konstantin.ananyev,
ferruh.yigit, jerinj, rmody, shshaikh, maxime.coquelin,
xiaolong.ye, John McNamara, Marko Kovacevic
It seems sphinx >= 2.0 is inserting a <p> tag in each table cell.
The feature table (matrix) style needs to be updated to avoid
cells being too big.
The margin, padding and line height are overriden.
The font size in percentage is replaced with an equivalent pixel size.
The border is explicit because it disappeared for th.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/conf.py | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/doc/guides/conf.py b/doc/guides/conf.py
index c368fa51d4..804c4aa74f 100644
--- a/doc/guides/conf.py
+++ b/doc/guides/conf.py
@@ -314,16 +314,22 @@ def print_table_css(outfile, table_id):
cursor: default;
overflow: hidden;
}
+ table#idx p {
+ margin: 0;
+ line-height: inherit;
+ }
table#idx th, table#idx td {
text-align: center;
+ border: solid 1px #ddd;
}
table#idx th {
- font-size: 72%;
+ padding: 0.5em 0;
+ }
+ table#idx th, table#idx th p {
+ font-size: 11px;
white-space: pre-wrap;
vertical-align: top;
- padding: 0.5em 0;
min-width: 0.9em;
- width: 2em;
}
table#idx col:first-child {
width: 0;
@@ -332,9 +338,11 @@ def print_table_css(outfile, table_id):
vertical-align: bottom;
}
table#idx td {
- font-size: 70%;
padding: 1px;
}
+ table#idx td, table#idx td p {
+ font-size: 11px;
+ }
table#idx td:first-child {
padding-left: 1em;
text-align: left;
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [dpdk-dev] [PATCH 2/3] doc: remove empty columns from NIC features matrix
2020-03-11 23:01 [dpdk-dev] [PATCH 0/3] refresh NIC features matrix Thomas Monjalon
2020-03-11 23:01 ` [dpdk-dev] [PATCH 1/3] doc: fix matrix CSS for recent sphinx Thomas Monjalon
@ 2020-03-11 23:01 ` Thomas Monjalon
2020-03-11 23:01 ` [dpdk-dev] [PATCH 3/3] doc: remove similar " Thomas Monjalon
` (3 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2020-03-11 23:01 UTC (permalink / raw)
To: dev
Cc: rahul.lakkireddy, qi.z.zhang, xiao.w.wang, xavier.huwei,
beilei.xing, wenzhuo.lu, qiming.yang, konstantin.ananyev,
ferruh.yigit, jerinj, rmody, shshaikh, maxime.coquelin,
xiaolong.ye, Chas Williams, John McNamara, Marko Kovacevic,
Tetsuya Mukawa, Bruce Richardson, Jasvinder Singh,
Cristian Dumitrescu, Matan Azrad
The virtual PMDs bonding, KNI, null, ring, softnic and vdev_netvsc
have no real feature to advertise so they can be removed
from the (too) big matrix of ethdev features.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/nics/features/bonding.ini | 6 ------
doc/guides/nics/features/kni.ini | 7 -------
doc/guides/nics/features/null.ini | 6 ------
doc/guides/nics/features/ring.ini | 6 ------
doc/guides/nics/features/softnic.ini | 9 ---------
doc/guides/nics/features/vdev_netvsc.ini | 12 ------------
6 files changed, 46 deletions(-)
delete mode 100644 doc/guides/nics/features/bonding.ini
delete mode 100644 doc/guides/nics/features/kni.ini
delete mode 100644 doc/guides/nics/features/null.ini
delete mode 100644 doc/guides/nics/features/ring.ini
delete mode 100644 doc/guides/nics/features/softnic.ini
delete mode 100644 doc/guides/nics/features/vdev_netvsc.ini
diff --git a/doc/guides/nics/features/bonding.ini b/doc/guides/nics/features/bonding.ini
deleted file mode 100644
index c1653051e7..0000000000
--- a/doc/guides/nics/features/bonding.ini
+++ /dev/null
@@ -1,6 +0,0 @@
-;
-; Supported features of the 'bonding' network poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
diff --git a/doc/guides/nics/features/kni.ini b/doc/guides/nics/features/kni.ini
deleted file mode 100644
index 6deb66ae2d..0000000000
--- a/doc/guides/nics/features/kni.ini
+++ /dev/null
@@ -1,7 +0,0 @@
-;
-; Supported features of the 'kni' network poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
-Usage doc = Y
diff --git a/doc/guides/nics/features/null.ini b/doc/guides/nics/features/null.ini
deleted file mode 100644
index 3957f7ca18..0000000000
--- a/doc/guides/nics/features/null.ini
+++ /dev/null
@@ -1,6 +0,0 @@
-;
-; Supported features of the 'null' network poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
diff --git a/doc/guides/nics/features/ring.ini b/doc/guides/nics/features/ring.ini
deleted file mode 100644
index ac207ba31b..0000000000
--- a/doc/guides/nics/features/ring.ini
+++ /dev/null
@@ -1,6 +0,0 @@
-;
-; Supported features of the 'ring' network poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
diff --git a/doc/guides/nics/features/softnic.ini b/doc/guides/nics/features/softnic.ini
deleted file mode 100644
index 0583381cc7..0000000000
--- a/doc/guides/nics/features/softnic.ini
+++ /dev/null
@@ -1,9 +0,0 @@
-;
-; Supported features of the 'softnic' poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
-x86-32 = Y
-x86-64 = Y
-Usage doc = Y
diff --git a/doc/guides/nics/features/vdev_netvsc.ini b/doc/guides/nics/features/vdev_netvsc.ini
deleted file mode 100644
index cfc5cb93ef..0000000000
--- a/doc/guides/nics/features/vdev_netvsc.ini
+++ /dev/null
@@ -1,12 +0,0 @@
-;
-; Supported features of the 'vdev_netvsc' network poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
-ARMv7 = Y
-ARMv8 = Y
-Power8 = Y
-x86-32 = Y
-x86-64 = Y
-Usage doc = Y
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [dpdk-dev] [PATCH 3/3] doc: remove similar columns from NIC features matrix
2020-03-11 23:01 [dpdk-dev] [PATCH 0/3] refresh NIC features matrix Thomas Monjalon
2020-03-11 23:01 ` [dpdk-dev] [PATCH 1/3] doc: fix matrix CSS for recent sphinx Thomas Monjalon
2020-03-11 23:01 ` [dpdk-dev] [PATCH 2/3] doc: remove empty columns from NIC features matrix Thomas Monjalon
@ 2020-03-11 23:01 ` Thomas Monjalon
2020-03-18 11:42 ` [dpdk-dev] [PATCH 0/3] refresh " Thomas Monjalon
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2020-03-11 23:01 UTC (permalink / raw)
To: dev
Cc: rahul.lakkireddy, qi.z.zhang, xiao.w.wang, xavier.huwei,
beilei.xing, wenzhuo.lu, qiming.yang, konstantin.ananyev,
ferruh.yigit, jerinj, rmody, shshaikh, maxime.coquelin,
xiaolong.ye, John McNamara, Marko Kovacevic, Heinrich Kuhn
The PMDs bnx2x and nfp have a separate column for VF.
Such separation is unneeded because the features are the same.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/nics/features/bnx2x.ini | 1 +
doc/guides/nics/features/bnx2x_vf.ini | 18 -----------------
doc/guides/nics/features/nfp_vf.ini | 29 ---------------------------
3 files changed, 1 insertion(+), 47 deletions(-)
delete mode 100644 doc/guides/nics/features/bnx2x_vf.ini
delete mode 100644 doc/guides/nics/features/nfp_vf.ini
diff --git a/doc/guides/nics/features/bnx2x.ini b/doc/guides/nics/features/bnx2x.ini
index 3e33e9abd6..e17bf60689 100644
--- a/doc/guides/nics/features/bnx2x.ini
+++ b/doc/guides/nics/features/bnx2x.ini
@@ -10,6 +10,7 @@ Link status event = Y
Promiscuous mode = Y
Unicast MAC filter = Y
Multicast MAC filter = Y
+SR-IOV = Y
Basic stats = Y
Extended stats = Y
Linux UIO = Y
diff --git a/doc/guides/nics/features/bnx2x_vf.ini b/doc/guides/nics/features/bnx2x_vf.ini
deleted file mode 100644
index c270902e35..0000000000
--- a/doc/guides/nics/features/bnx2x_vf.ini
+++ /dev/null
@@ -1,18 +0,0 @@
-;
-; Supported features of the 'bnx2x_vf' network poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
-Speed capabilities = P
-Link status = Y
-Link status event = Y
-Promiscuous mode = Y
-Unicast MAC filter = Y
-Multicast MAC filter = Y
-SR-IOV = Y
-Basic stats = Y
-Extended stats = Y
-Linux UIO = Y
-x86-64 = Y
-Usage doc = Y
diff --git a/doc/guides/nics/features/nfp_vf.ini b/doc/guides/nics/features/nfp_vf.ini
deleted file mode 100644
index 70297b0907..0000000000
--- a/doc/guides/nics/features/nfp_vf.ini
+++ /dev/null
@@ -1,29 +0,0 @@
-;
-; Supported features of the 'nfp' network poll mode driver.
-;
-; Refer to default.ini for the full list of available PMD features.
-;
-[Features]
-Speed capabilities = Y
-Link status = Y
-Link status event = Y
-Rx interrupt = Y
-Queue start/stop = Y
-MTU update = Y
-Jumbo frame = Y
-Promiscuous mode = Y
-TSO = Y
-RSS hash = Y
-RSS key update = Y
-RSS reta update = Y
-Flow control = Y
-VLAN offload = Y
-L3 checksum offload = Y
-L4 checksum offload = Y
-Basic stats = Y
-Stats per queue = Y
-Linux UIO = Y
-Linux VFIO = Y
-Multiprocess aware = Y
-x86-64 = Y
-Usage doc = Y
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-11 23:01 [dpdk-dev] [PATCH 0/3] refresh NIC features matrix Thomas Monjalon
` (2 preceding siblings ...)
2020-03-11 23:01 ` [dpdk-dev] [PATCH 3/3] doc: remove similar " Thomas Monjalon
@ 2020-03-18 11:42 ` Thomas Monjalon
2020-03-20 5:35 ` Zhang, Qi Z
2020-04-16 21:57 ` Thomas Monjalon
5 siblings, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2020-03-18 11:42 UTC (permalink / raw)
To: dev
Cc: rahul.lakkireddy, qi.z.zhang, xiao.w.wang, xavier.huwei,
beilei.xing, wenzhuo.lu, qiming.yang, konstantin.ananyev,
ferruh.yigit, jerinj, rmody, shshaikh, maxime.coquelin,
xiaolong.ye
Ping for review and action on follow-up patches please.
I hope we won't have to block patches to get things done.
Ferruh, I think we need an action plan.
12/03/2020 00:01, Thomas Monjalon:
> This series aims to clean-up the big table of ethdev features:
> http://doc.dpdk.org/guides/nics/overview.html#id1
>
> We could reorganize the information in this table,
> maybe split it or add/remove some rows.
> Before going to such reorganization, we should clean it up.
>
> The first patch is fixing the look & size of the table with recent sphinx.
>
> The second and third patches are removing 8 columns which are
> clearly unneeded:
> - bnx2x_vf
> - bonding
> - kni
> - nfp_vf
> - null
> - ring
> - softnic
> - vdev_netvsc
>
> More columns can be removed by merging PF/VF and vector datapaths.
> If a feature cannot be supported in all cases, it should be marked
> as partially supported (P).
> If a feature is PF-specific (like flow control), that's OK to mark
> it fully supported because it's obviously impossible for VF.
> There are also some features which were probably marked in some
> columns and missed in its VF or vector counterpart.
> Please work to merge and drop these 16 columns:
> - cxgbevf
> - fm10k_vf
> - hns3_vf
> - i40e_vec
> - i40e_vf
> - i40e_vf_vec
> - iavf_vec
> - ice_vec
> - igb_vf
> - ixgbe_vec
> - ixgbe_vf
> - ixgbe_vf_vec
> - octeontx2_vec
> - octeontx2_vf
> - qede_vf
> - virtio_vec
>
> The total gain is to reduce the table size from 71 to 47 columns.
>
> Please send patches for Chelsio, Huawei, Intel, Marvell and virtio.
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-11 23:01 [dpdk-dev] [PATCH 0/3] refresh NIC features matrix Thomas Monjalon
` (3 preceding siblings ...)
2020-03-18 11:42 ` [dpdk-dev] [PATCH 0/3] refresh " Thomas Monjalon
@ 2020-03-20 5:35 ` Zhang, Qi Z
2020-03-20 10:44 ` Thomas Monjalon
2020-04-16 21:57 ` Thomas Monjalon
5 siblings, 1 reply; 13+ messages in thread
From: Zhang, Qi Z @ 2020-03-20 5:35 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: rahul.lakkireddy, Wang, Xiao W, xavier.huwei, Xing, Beilei, Lu,
Wenzhuo, Yang, Qiming, Ananyev, Konstantin, Yigit, Ferruh,
jerinj, rmody, shshaikh, maxime.coquelin, Ye, Xiaolong
Hi Thomas:
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, March 12, 2020 7:02 AM
> To: dev@dpdk.org
> Cc: rahul.lakkireddy@chelsio.com; Zhang, Qi Z <qi.z.zhang@intel.com>; Wang,
> Xiao W <xiao.w.wang@intel.com>; xavier.huwei@huawei.com; Xing, Beilei
> <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerinj@marvell.com; rmody@marvell.com; shshaikh@marvell.com;
> maxime.coquelin@redhat.com; Ye, Xiaolong <xiaolong.ye@intel.com>
> Subject: [PATCH 0/3] refresh NIC features matrix
>
> This series aims to clean-up the big table of ethdev features:
> http://doc.dpdk.org/guides/nics/overview.html#id1
>
> We could reorganize the information in this table, maybe split it or add/remove
> some rows.
> Before going to such reorganization, we should clean it up.
>
> The first patch is fixing the look & size of the table with recent sphinx.
>
> The second and third patches are removing 8 columns which are clearly
> unneeded:
> - bnx2x_vf
> - bonding
> - kni
> - nfp_vf
> - null
> - ring
> - softnic
> - vdev_netvsc
>
> More columns can be removed by merging PF/VF and vector datapaths.
> If a feature cannot be supported in all cases, it should be marked as partially
> supported (P).
> If a feature is PF-specific (like flow control), that's OK to mark it fully supported
> because it's obviously impossible for VF.
> There are also some features which were probably marked in some columns
> and missed in its VF or vector counterpart.
> Please work to merge and drop these 16 columns:
> - cxgbevf
> - fm10k_vf
> - hns3_vf
> - i40e_vec
> - i40e_vf
> - i40e_vf_vec
> - iavf_vec
> - ice_vec
> - igb_vf
> - ixgbe_vec
> - ixgbe_vf
> - ixgbe_vf_vec
> - octeontx2_vec
> - octeontx2_vf
> - qede_vf
> - virtio_vec
>
> The total gain is to reduce the table size from 71 to 47 columns.
I agree to remove all the column with "vec", since vector PMD can be regarded as a feature of the a PMD.
But I'm not sure if it is a good idea to merge VF and PF into one column.
From my view, for intel device, VF driver and PF driver just share the code, but they actually are running at two different context.
And likely they will support different feature, merge into one column may confuse our customer if they want to understand what exactly the PMD support.
Thanks
Qi
>
> Please send patches for Chelsio, Huawei, Intel, Marvell and virtio.
>
>
> Thomas Monjalon (3):
> doc: fix matrix CSS for recent sphinx
> doc: remove empty columns from NIC features matrix
> doc: remove similar columns from NIC features matrix
>
> doc/guides/conf.py | 16 +++++++++----
> doc/guides/nics/features/bnx2x.ini | 1 +
> doc/guides/nics/features/bnx2x_vf.ini | 18 ---------------
> doc/guides/nics/features/bonding.ini | 6 -----
> doc/guides/nics/features/kni.ini | 7 ------
> doc/guides/nics/features/nfp_vf.ini | 29 ------------------------
> doc/guides/nics/features/null.ini | 6 -----
> doc/guides/nics/features/ring.ini | 6 -----
> doc/guides/nics/features/softnic.ini | 9 --------
> doc/guides/nics/features/vdev_netvsc.ini | 12 ----------
> 10 files changed, 13 insertions(+), 97 deletions(-) delete mode 100644
> doc/guides/nics/features/bnx2x_vf.ini
> delete mode 100644 doc/guides/nics/features/bonding.ini
> delete mode 100644 doc/guides/nics/features/kni.ini delete mode 100644
> doc/guides/nics/features/nfp_vf.ini
> delete mode 100644 doc/guides/nics/features/null.ini delete mode 100644
> doc/guides/nics/features/ring.ini delete mode 100644
> doc/guides/nics/features/softnic.ini
> delete mode 100644 doc/guides/nics/features/vdev_netvsc.ini
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-20 5:35 ` Zhang, Qi Z
@ 2020-03-20 10:44 ` Thomas Monjalon
2020-03-20 11:15 ` Zhang, Qi Z
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Monjalon @ 2020-03-20 10:44 UTC (permalink / raw)
To: Zhang, Qi Z
Cc: dev, rahul.lakkireddy, Wang, Xiao W, xavier.huwei, Xing, Beilei,
Lu, Wenzhuo, Yang, Qiming, Ananyev, Konstantin, Yigit, Ferruh,
jerinj, rmody, shshaikh, maxime.coquelin, Ye, Xiaolong
20/03/2020 06:35, Zhang, Qi Z:
> Hi Thomas:
>
> From: Thomas Monjalon <thomas@monjalon.net>
> >
> > This series aims to clean-up the big table of ethdev features:
> > http://doc.dpdk.org/guides/nics/overview.html#id1
> >
> > We could reorganize the information in this table, maybe split it or add/remove
> > some rows.
> > Before going to such reorganization, we should clean it up.
> >
> > The first patch is fixing the look & size of the table with recent sphinx.
> >
> > The second and third patches are removing 8 columns which are clearly
> > unneeded:
> > - bnx2x_vf
> > - bonding
> > - kni
> > - nfp_vf
> > - null
> > - ring
> > - softnic
> > - vdev_netvsc
> >
> > More columns can be removed by merging PF/VF and vector datapaths.
> > If a feature cannot be supported in all cases, it should be marked as partially
> > supported (P).
> > If a feature is PF-specific (like flow control), that's OK to mark it fully supported
> > because it's obviously impossible for VF.
> > There are also some features which were probably marked in some columns
> > and missed in its VF or vector counterpart.
> > Please work to merge and drop these 16 columns:
> > - cxgbevf
> > - fm10k_vf
> > - hns3_vf
> > - i40e_vec
> > - i40e_vf
> > - i40e_vf_vec
> > - iavf_vec
> > - ice_vec
> > - igb_vf
> > - ixgbe_vec
> > - ixgbe_vf
> > - ixgbe_vf_vec
> > - octeontx2_vec
> > - octeontx2_vf
> > - qede_vf
> > - virtio_vec
> >
> > The total gain is to reduce the table size from 71 to 47 columns.
>
> I agree to remove all the column with "vec", since vector PMD can be regarded as a feature of the a PMD.
> But I'm not sure if it is a good idea to merge VF and PF into one column.
> From my view, for intel device, VF driver and PF driver just share the code, but they actually are running at two different context.
> And likely they will support different feature, merge into one column may confuse our customer if they want to understand what exactly the PMD support.
I understand you have 2 different datapaths.
My arguments are:
- it is the same NIC
- you cannot summarize everything in a table
- we have two many columns to make it readable
I think the right solution is mark features as partially available (P),
and give details in the driver guide documentation.
Can you please, at least, remove the "vec" columns, as a first step?
Thanks
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-20 10:44 ` Thomas Monjalon
@ 2020-03-20 11:15 ` Zhang, Qi Z
2020-03-24 8:36 ` Andrew Rybchenko
0 siblings, 1 reply; 13+ messages in thread
From: Zhang, Qi Z @ 2020-03-20 11:15 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, rahul.lakkireddy, Wang, Xiao W, xavier.huwei, Xing, Beilei,
Lu, Wenzhuo, Yang, Qiming, Ananyev, Konstantin, Yigit, Ferruh,
jerinj, rmody, shshaikh, maxime.coquelin, Ye, Xiaolong
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, March 20, 2020 6:45 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; rahul.lakkireddy@chelsio.com; Wang, Xiao W
> <xiao.w.wang@intel.com>; xavier.huwei@huawei.com; Xing, Beilei
> <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerinj@marvell.com; rmody@marvell.com; shshaikh@marvell.com;
> maxime.coquelin@redhat.com; Ye, Xiaolong <xiaolong.ye@intel.com>
> Subject: Re: [PATCH 0/3] refresh NIC features matrix
>
> 20/03/2020 06:35, Zhang, Qi Z:
> > Hi Thomas:
> >
> > From: Thomas Monjalon <thomas@monjalon.net>
> > >
> > > This series aims to clean-up the big table of ethdev features:
> > > http://doc.dpdk.org/guides/nics/overview.html#id1
> > >
> > > We could reorganize the information in this table, maybe split it or
> > > add/remove some rows.
> > > Before going to such reorganization, we should clean it up.
> > >
> > > The first patch is fixing the look & size of the table with recent sphinx.
> > >
> > > The second and third patches are removing 8 columns which are
> > > clearly
> > > unneeded:
> > > - bnx2x_vf
> > > - bonding
> > > - kni
> > > - nfp_vf
> > > - null
> > > - ring
> > > - softnic
> > > - vdev_netvsc
> > >
> > > More columns can be removed by merging PF/VF and vector datapaths.
> > > If a feature cannot be supported in all cases, it should be marked
> > > as partially supported (P).
> > > If a feature is PF-specific (like flow control), that's OK to mark
> > > it fully supported because it's obviously impossible for VF.
> > > There are also some features which were probably marked in some
> > > columns and missed in its VF or vector counterpart.
> > > Please work to merge and drop these 16 columns:
> > > - cxgbevf
> > > - fm10k_vf
> > > - hns3_vf
> > > - i40e_vec
> > > - i40e_vf
> > > - i40e_vf_vec
> > > - iavf_vec
> > > - ice_vec
> > > - igb_vf
> > > - ixgbe_vec
> > > - ixgbe_vf
> > > - ixgbe_vf_vec
> > > - octeontx2_vec
> > > - octeontx2_vf
> > > - qede_vf
> > > - virtio_vec
> > >
> > > The total gain is to reduce the table size from 71 to 47 columns.
> >
> > I agree to remove all the column with "vec", since vector PMD can be
> regarded as a feature of the a PMD.
> > But I'm not sure if it is a good idea to merge VF and PF into one column.
> > From my view, for intel device, VF driver and PF driver just share the code,
> but they actually are running at two different context.
> > And likely they will support different feature, merge into one column may
> confuse our customer if they want to understand what exactly the PMD
> support.
>
> I understand you have 2 different datapaths.
> My arguments are:
> - it is the same NIC
Yes, but one device can be polymorphic, ideally i40e and i40evf could be in two different folder, and the common part can be a library in driver/common/i40e.
> - you cannot summarize everything in a table
> - we have two many columns to make it readable
I don't think columns number is critical, typically user just need to focus on the first column and the specific driver's column,
I guess it may not a big challenge to enable some filter by front end web technique?
>
> I think the right solution is mark features as partially available (P), and give
> details in the driver guide documentation.
>
> Can you please, at least, remove the "vec" columns, as a first step?
Sure, as I said, I agree to remove "vec".
Thanks
Qi
> Thanks
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-20 11:15 ` Zhang, Qi Z
@ 2020-03-24 8:36 ` Andrew Rybchenko
2020-04-16 20:13 ` Thomas Monjalon
2020-04-17 16:32 ` Thomas Monjalon
0 siblings, 2 replies; 13+ messages in thread
From: Andrew Rybchenko @ 2020-03-24 8:36 UTC (permalink / raw)
To: Zhang, Qi Z, Thomas Monjalon
Cc: dev, rahul.lakkireddy, Wang, Xiao W, xavier.huwei, Xing, Beilei,
Lu, Wenzhuo, Yang, Qiming, Ananyev, Konstantin, Yigit, Ferruh,
jerinj, rmody, shshaikh, maxime.coquelin, Ye, Xiaolong
On 3/20/20 2:15 PM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Thomas Monjalon <thomas@monjalon.net>
>> Sent: Friday, March 20, 2020 6:45 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org; rahul.lakkireddy@chelsio.com; Wang, Xiao W
>> <xiao.w.wang@intel.com>; xavier.huwei@huawei.com; Xing, Beilei
>> <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> jerinj@marvell.com; rmody@marvell.com; shshaikh@marvell.com;
>> maxime.coquelin@redhat.com; Ye, Xiaolong <xiaolong.ye@intel.com>
>> Subject: Re: [PATCH 0/3] refresh NIC features matrix
>>
>> 20/03/2020 06:35, Zhang, Qi Z:
>>> Hi Thomas:
>>>
>>> From: Thomas Monjalon <thomas@monjalon.net>
>>>>
>>>> This series aims to clean-up the big table of ethdev features:
>>>> http://doc.dpdk.org/guides/nics/overview.html#id1
>>>>
>>>> We could reorganize the information in this table, maybe split it or
>>>> add/remove some rows.
>>>> Before going to such reorganization, we should clean it up.
>>>>
>>>> The first patch is fixing the look & size of the table with recent sphinx.
>>>>
>>>> The second and third patches are removing 8 columns which are
>>>> clearly
>>>> unneeded:
>>>> - bnx2x_vf
>>>> - bonding
>>>> - kni
>>>> - nfp_vf
>>>> - null
>>>> - ring
>>>> - softnic
>>>> - vdev_netvsc
>>>>
>>>> More columns can be removed by merging PF/VF and vector datapaths.
>>>> If a feature cannot be supported in all cases, it should be marked
>>>> as partially supported (P).
>>>> If a feature is PF-specific (like flow control), that's OK to mark
>>>> it fully supported because it's obviously impossible for VF.
>>>> There are also some features which were probably marked in some
>>>> columns and missed in its VF or vector counterpart.
>>>> Please work to merge and drop these 16 columns:
>>>> - cxgbevf
>>>> - fm10k_vf
>>>> - hns3_vf
>>>> - i40e_vec
>>>> - i40e_vf
>>>> - i40e_vf_vec
>>>> - iavf_vec
>>>> - ice_vec
>>>> - igb_vf
>>>> - ixgbe_vec
>>>> - ixgbe_vf
>>>> - ixgbe_vf_vec
>>>> - octeontx2_vec
>>>> - octeontx2_vf
>>>> - qede_vf
>>>> - virtio_vec
>>>>
>>>> The total gain is to reduce the table size from 71 to 47 columns.
>>>
>>> I agree to remove all the column with "vec", since vector PMD can be
>> regarded as a feature of the a PMD.
>>> But I'm not sure if it is a good idea to merge VF and PF into one column.
>>> From my view, for intel device, VF driver and PF driver just share the code,
>> but they actually are running at two different context.
>>> And likely they will support different feature, merge into one column may
>> confuse our customer if they want to understand what exactly the PMD
>> support.
>>
>> I understand you have 2 different datapaths.
>> My arguments are:
>> - it is the same NIC
>
> Yes, but one device can be polymorphic, ideally i40e and i40evf could be in two different folder, and the common part can be a library in driver/common/i40e.
For me, it does not sound like a good idea. Too many folders on
the first level does not look nice. Should we go Linux way and
group by vendor? Too early? However, it is not directly
related to the topic.
>> - you cannot summarize everything in a table
>> - we have two many columns to make it readable
>
> I don't think columns number is critical, typically user just need to focus on the first column and the specific driver's column,
Too many columns still makes it harder to read/analyze. I think
the main goal of the table is too help making NIC choice to
be installed in a server and you can't make a choice between
PF and VF. Difference between PF and VF capabilities is
a separate story and out-of-scope of the table.
We have a new driver(s) in each DPDK release and table is
already big and will grow more and more.
> I guess it may not a big challenge to enable some filter by front end web technique?
>
>> I think the right solution is mark features as partially available (P), and give
>> details in the driver guide documentation.
>>
>> Can you please, at least, remove the "vec" columns, as a first step?
>
> Sure, as I said, I agree to remove "vec".
>
> Thanks
> Qi
>
>> Thanks
>>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-24 8:36 ` Andrew Rybchenko
@ 2020-04-16 20:13 ` Thomas Monjalon
2020-04-17 16:32 ` Thomas Monjalon
1 sibling, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2020-04-16 20:13 UTC (permalink / raw)
To: dev
Cc: Zhang, Qi Z, rahul.lakkireddy, Wang, Xiao W, xavier.huwei, Xing,
Beilei, Lu, Wenzhuo, Yang, Qiming, Ananyev, Konstantin, Yigit,
Ferruh, jerinj, rmody, shshaikh, maxime.coquelin, Ye, Xiaolong,
Andrew Rybchenko, galco, david.marchand
Any more opinion about removing VF columns from the NIC matrix?
24/03/2020 09:36, Andrew Rybchenko:
> On 3/20/20 2:15 PM, Zhang, Qi Z wrote:
> > From: Thomas Monjalon <thomas@monjalon.net>
> >> 20/03/2020 06:35, Zhang, Qi Z:
> >>> From: Thomas Monjalon <thomas@monjalon.net>
> >>>> The second and third patches are removing 8 columns which are
> >>>> clearly
> >>>> unneeded:
> >>>> - bnx2x_vf
> >>>> - bonding
> >>>> - kni
> >>>> - nfp_vf
> >>>> - null
> >>>> - ring
> >>>> - softnic
> >>>> - vdev_netvsc
> >>>>
> >>>> More columns can be removed by merging PF/VF and vector datapaths.
> >>>> If a feature cannot be supported in all cases, it should be marked
> >>>> as partially supported (P).
> >>>> If a feature is PF-specific (like flow control), that's OK to mark
> >>>> it fully supported because it's obviously impossible for VF.
> >>>> There are also some features which were probably marked in some
> >>>> columns and missed in its VF or vector counterpart.
> >>>> Please work to merge and drop these 16 columns:
> >>>> - cxgbevf
> >>>> - fm10k_vf
> >>>> - hns3_vf
> >>>> - i40e_vec
> >>>> - i40e_vf
> >>>> - i40e_vf_vec
> >>>> - iavf_vec
> >>>> - ice_vec
> >>>> - igb_vf
> >>>> - ixgbe_vec
> >>>> - ixgbe_vf
> >>>> - ixgbe_vf_vec
> >>>> - octeontx2_vec
> >>>> - octeontx2_vf
> >>>> - qede_vf
> >>>> - virtio_vec
> >>>>
> >>>> The total gain is to reduce the table size from 71 to 47 columns.
> >>>
> >>> I agree to remove all the column with "vec", since vector PMD can be
> >> regarded as a feature of the a PMD.
> >>> But I'm not sure if it is a good idea to merge VF and PF into one column.
> >>> From my view, for intel device, VF driver and PF driver just share the code,
> >> but they actually are running at two different context.
> >>> And likely they will support different feature, merge into one column may
> >> confuse our customer if they want to understand what exactly the PMD
> >> support.
> >>
> >> I understand you have 2 different datapaths.
> >> My arguments are:
> >> - it is the same NIC
> >
> > Yes, but one device can be polymorphic, ideally i40e and i40evf could be in two different folder, and the common part can be a library in driver/common/i40e.
>
> For me, it does not sound like a good idea. Too many folders on
> the first level does not look nice. Should we go Linux way and
> group by vendor? Too early? However, it is not directly
> related to the topic.
>
> >> - you cannot summarize everything in a table
> >> - we have two many columns to make it readable
> >
> > I don't think columns number is critical, typically user just need to focus on the first column and the specific driver's column,
>
> Too many columns still makes it harder to read/analyze. I think
> the main goal of the table is too help making NIC choice to
> be installed in a server and you can't make a choice between
> PF and VF. Difference between PF and VF capabilities is
> a separate story and out-of-scope of the table.
> We have a new driver(s) in each DPDK release and table is
> already big and will grow more and more.
>
> > I guess it may not a big challenge to enable some filter by front end web technique?
> >
> >> I think the right solution is mark features as partially available (P), and give
> >> details in the driver guide documentation.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-24 8:36 ` Andrew Rybchenko
2020-04-16 20:13 ` Thomas Monjalon
@ 2020-04-17 16:32 ` Thomas Monjalon
2020-04-17 18:21 ` Ajit Khaparde
1 sibling, 1 reply; 13+ messages in thread
From: Thomas Monjalon @ 2020-04-17 16:32 UTC (permalink / raw)
To: dev, jerinj, maxime.coquelin, Ye, Xiaolong, Nithin Dabilpuram,
Kiran Kumar K, Zhihong Wang
Cc: Zhang, Qi Z, rahul.lakkireddy, Wang, Xiao W, xavier.huwei, Xing,
Beilei, Lu, Wenzhuo, Yang, Qiming, Ananyev, Konstantin, Yigit,
Ferruh, rmody, shshaikh, Andrew Rybchenko
Call for action below (especially for octeontx2 and virtio):
24/03/2020 09:36, Andrew Rybchenko:
> On 3/20/20 2:15 PM, Zhang, Qi Z wrote:
> > From: Thomas Monjalon <thomas@monjalon.net>
> >> 20/03/2020 06:35, Zhang, Qi Z:
> >>> From: Thomas Monjalon <thomas@monjalon.net>
> >>>>
> >>>> This series aims to clean-up the big table of ethdev features:
> >>>> http://doc.dpdk.org/guides/nics/overview.html#id1
> >>>>
> >>>> We could reorganize the information in this table, maybe split it or
> >>>> add/remove some rows.
> >>>> Before going to such reorganization, we should clean it up.
[...]
> >>>> More columns can be removed by merging PF/VF and vector datapaths.
> >>>> If a feature cannot be supported in all cases, it should be marked
> >>>> as partially supported (P).
I see that Intel merged "vec" columns for its PMDs.
We are still missing octeontx2 and virtio.
In order to make sure the message is received,
I suggest blocking any patch in these PMDs until features matrix is fixed.
> >>>> If a feature is PF-specific (like flow control), that's OK to mark
> >>>> it fully supported because it's obviously impossible for VF.
> >>>> There are also some features which were probably marked in some
> >>>> columns and missed in its VF or vector counterpart.
Ideally we should remove all these columns (VF to be discussed):
> >>>> - cxgbevf
> >>>> - fm10k_vf
> >>>> - hns3_vf
> >>>> - i40e_vf
> >>>> - igb_vf
> >>>> - ixgbe_vf
> >>>> - octeontx2_vec
> >>>> - octeontx2_vf
> >>>> - qede_vf
> >>>> - virtio_vec
> >>>>
> >>>> The total gain is to reduce the table size from 71 to 47 columns.
> >>>
> >>> I agree to remove all the column with "vec", since vector PMD can be
> >>> regarded as a feature of the a PMD.
> >>> But I'm not sure if it is a good idea to merge VF and PF into one column.
> >>> From my view, for intel device, VF driver and PF driver just share the code,
> >>> but they actually are running at two different context.
> >>> And likely they will support different feature, merge into one column may
> >>> confuse our customer if they want to understand what exactly the PMD
> >>> support.
> >>
> >> I understand you have 2 different datapaths.
> >> My arguments are:
> >> - it is the same NIC
> >
> > Yes, but one device can be polymorphic, ideally i40e and i40evf
> > could be in two different folder, and the common part can be a
> > library in driver/common/i40e.
[...]
>
> >> - you cannot summarize everything in a table
> >> - we have two many columns to make it readable
> >
> > I don't think columns number is critical, typically user just need
> > to focus on the first column and the specific driver's column,
>
> Too many columns still makes it harder to read/analyze. I think
> the main goal of the table is too help making NIC choice to
> be installed in a server and you can't make a choice between
> PF and VF. Difference between PF and VF capabilities is
> a separate story and out-of-scope of the table.
> We have a new driver(s) in each DPDK release and table is
> already big and will grow more and more.
>
> > I guess it may not a big challenge to enable some filter by front end web technique?
> >
> >> I think the right solution is mark features as partially available (P), and give
> >> details in the driver guide documentation.
Other opinions about removing/merging VF columns?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-04-17 16:32 ` Thomas Monjalon
@ 2020-04-17 18:21 ` Ajit Khaparde
0 siblings, 0 replies; 13+ messages in thread
From: Ajit Khaparde @ 2020-04-17 18:21 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dpdk-dev, jerinj, maxime.coquelin, Ye, Xiaolong,
Nithin Dabilpuram, Kiran Kumar K, Zhihong Wang, Zhang, Qi Z,
rahul.lakkireddy, Wang, Xiao W, xavier.huwei, Xing, Beilei, Lu,
Wenzhuo, Yang, Qiming, Ananyev, Konstantin, Yigit, Ferruh, rmody,
shshaikh, Andrew Rybchenko
On Fri, Apr 17, 2020 at 9:32 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> Call for action below (especially for octeontx2 and virtio):
>
> 24/03/2020 09:36, Andrew Rybchenko:
> > On 3/20/20 2:15 PM, Zhang, Qi Z wrote:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > >> 20/03/2020 06:35, Zhang, Qi Z:
> > >>> From: Thomas Monjalon <thomas@monjalon.net>
> > >>>>
> > >>>> This series aims to clean-up the big table of ethdev features:
> > >>>> http://doc.dpdk.org/guides/nics/overview.html#id1
> > >>>>
> > >>>> We could reorganize the information in this table, maybe split it or
> > >>>> add/remove some rows.
> > >>>> Before going to such reorganization, we should clean it up.
> [...]
> > >>>> More columns can be removed by merging PF/VF and vector datapaths.
> > >>>> If a feature cannot be supported in all cases, it should be marked
> > >>>> as partially supported (P).
>
> I see that Intel merged "vec" columns for its PMDs.
> We are still missing octeontx2 and virtio.
> In order to make sure the message is received,
> I suggest blocking any patch in these PMDs until features matrix is fixed.
>
>
> > >>>> If a feature is PF-specific (like flow control), that's OK to mark
> > >>>> it fully supported because it's obviously impossible for VF.
> > >>>> There are also some features which were probably marked in some
> > >>>> columns and missed in its VF or vector counterpart.
>
> Ideally we should remove all these columns (VF to be discussed):
>
> > >>>> - cxgbevf
> > >>>> - fm10k_vf
> > >>>> - hns3_vf
> > >>>> - i40e_vf
> > >>>> - igb_vf
> > >>>> - ixgbe_vf
> > >>>> - octeontx2_vec
> > >>>> - octeontx2_vf
> > >>>> - qede_vf
> > >>>> - virtio_vec
> > >>>>
> > >>>> The total gain is to reduce the table size from 71 to 47 columns.
> > >>>
> > >>> I agree to remove all the column with "vec", since vector PMD can be
> > >>> regarded as a feature of the a PMD.
> > >>> But I'm not sure if it is a good idea to merge VF and PF into one
> column.
> > >>> From my view, for intel device, VF driver and PF driver just share
> the code,
> > >>> but they actually are running at two different context.
> > >>> And likely they will support different feature, merge into one
> column may
> > >>> confuse our customer if they want to understand what exactly the PMD
> > >>> support.
> > >>
> > >> I understand you have 2 different datapaths.
> > >> My arguments are:
> > >> - it is the same NIC
> > >
> > > Yes, but one device can be polymorphic, ideally i40e and i40evf
> > > could be in two different folder, and the common part can be a
> > > library in driver/common/i40e.
> [...]
> >
> > >> - you cannot summarize everything in a table
> > >> - we have two many columns to make it readable
> > >
> > > I don't think columns number is critical, typically user just need
> > > to focus on the first column and the specific driver's column,
> >
> > Too many columns still makes it harder to read/analyze. I think
> > the main goal of the table is too help making NIC choice to
> > be installed in a server and you can't make a choice between
> > PF and VF. Difference between PF and VF capabilities is
> > a separate story and out-of-scope of the table.
> > We have a new driver(s) in each DPDK release and table is
> > already big and will grow more and more.
> >
> > > I guess it may not a big challenge to enable some filter by front end
> web technique?
>
+1
> > >
> > >> I think the right solution is mark features as partially available
> (P), and give
> > >> details in the driver guide documentation.
>
> Other opinions about removing/merging VF columns?
>
PF and VF devices can have different feature support.
It will be good to keep them separate.
If it is difficult to tabulate the capabilities for various devices
in a single page, then marking it with (P) is fine.
The Driver guide should carry the differences between PF and VF
capabilities anyway.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix
2020-03-11 23:01 [dpdk-dev] [PATCH 0/3] refresh NIC features matrix Thomas Monjalon
` (4 preceding siblings ...)
2020-03-20 5:35 ` Zhang, Qi Z
@ 2020-04-16 21:57 ` Thomas Monjalon
5 siblings, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2020-04-16 21:57 UTC (permalink / raw)
To: dev
Cc: rahul.lakkireddy, qi.z.zhang, xiao.w.wang, xavier.huwei,
beilei.xing, wenzhuo.lu, qiming.yang, konstantin.ananyev,
ferruh.yigit, jerinj, rmody, shshaikh, maxime.coquelin,
xiaolong.ye
12/03/2020 00:01, Thomas Monjalon:
> This series aims to clean-up the big table of ethdev features:
> http://doc.dpdk.org/guides/nics/overview.html#id1
>
> We could reorganize the information in this table,
> maybe split it or add/remove some rows.
> Before going to such reorganization, we should clean it up.
>
> The first patch is fixing the look & size of the table with recent sphinx.
>
> The second and third patches are removing 8 columns which are
> clearly unneeded:
> - bnx2x_vf
> - bonding
> - kni
> - nfp_vf
> - null
> - ring
> - softnic
> - vdev_netvsc
>
[...]
> Thomas Monjalon (3):
> doc: fix matrix CSS for recent sphinx
> doc: remove empty columns from NIC features matrix
> doc: remove similar columns from NIC features matrix
Applied
^ permalink raw reply [flat|nested] 13+ messages in thread