From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2BDFA0567; Fri, 13 Mar 2020 06:54:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8456D1BFBF; Fri, 13 Mar 2020 06:54:20 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6BEC02BE3 for ; Fri, 13 Mar 2020 06:54:18 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 22:54:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,547,1574150400"; d="scan'208";a="232313254" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga007.jf.intel.com with ESMTP; 12 Mar 2020 22:54:15 -0700 Date: Fri, 13 Mar 2020 13:51:38 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com, beilei.xing@intel.com, wei.zhao1@intel.com Message-ID: <20200313055138.GD44839@intel.com> References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200310065029.40966-1-haiyue.wang@intel.com> <20200310065029.40966-4-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310065029.40966-4-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For the subject, since this patch is about acquire + disable, how about net/ice: support DCF capability acquire/disable On 03/10, Haiyue Wang wrote: >Since the DCF (Device Config Function) controls the flow setting of >other VFs by the mailbox with PF, for security, it needs to acquire >the DCF capability from PF when starts, and exits to disable it. s/exits to disable it/disable it when exits > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf.c | 28 +++++++++++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c >index efb258a5a..7a3626939 100644 >--- a/drivers/net/ice/ice_dcf.c >+++ b/drivers/net/ice/ice_dcf.c >@@ -227,7 +227,7 @@ ice_dcf_get_vf_resource(struct ice_dcf_hw *hw) > int err, i; > > caps = VIRTCHNL_VF_OFFLOAD_WB_ON_ITR | VIRTCHNL_VF_OFFLOAD_RX_POLLING | >- VIRTCHNL_VF_CAP_ADV_LINK_SPEED | >+ VIRTCHNL_VF_CAP_ADV_LINK_SPEED | VIRTCHNL_VF_CAP_DCF | > VF_BASE_MODE_OFFLOADS; > > err = ice_dcf_send_cmd_req_no_irq(hw, VIRTCHNL_OP_GET_VF_RESOURCES, >@@ -264,6 +264,31 @@ ice_dcf_get_vf_resource(struct ice_dcf_hw *hw) > return 0; > } > >+static int >+ice_dcf_mode_disable(struct ice_dcf_hw *hw) >+{ >+ int err; >+ >+ err = ice_dcf_send_cmd_req_no_irq(hw, VIRTCHNL_OP_DCF_DISABLE, >+ NULL, 0); >+ if (err) { >+ PMD_DRV_LOG(ERR, "Fail to send msg OP_DCF_DISABLE"); >+ return err; >+ } >+ >+ err = ice_dcf_recv_cmd_rsp_no_irq(hw, VIRTCHNL_OP_DCF_DISABLE, >+ (uint8_t *)hw->arq_buf, >+ ICE_DCF_AQ_BUF_SZ, NULL); >+ if (err) { >+ PMD_DRV_LOG(ERR, >+ "Fail to get response of OP_DCF_DISABLE %d", >+ err); >+ return -1; >+ } >+ >+ return 0; >+} >+ > static int > ice_dcf_check_reset_done(struct ice_dcf_hw *hw) > { >@@ -467,6 +492,7 @@ ice_dcf_uninit_hw(struct rte_eth_dev *eth_dev, struct ice_dcf_hw *hw) > rte_intr_callback_unregister(intr_handle, > ice_dcf_dev_interrupt_handler, hw); > >+ ice_dcf_mode_disable(hw); > iavf_shutdown_adminq(&hw->avf); > > rte_free(hw->arq_buf); >-- >2.25.1 > For the patch, Reviewed-by: Xiaolong Ye