From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 657E4A0567;
	Fri, 13 Mar 2020 07:07:00 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EB31C1BFBF;
	Fri, 13 Mar 2020 07:06:59 +0100 (CET)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 27F19FEB
 for <dev@dpdk.org>; Fri, 13 Mar 2020 07:06:58 +0100 (CET)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 12 Mar 2020 23:06:58 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.70,547,1574150400"; d="scan'208";a="278105116"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17])
 by fmsmga002.fm.intel.com with ESMTP; 12 Mar 2020 23:06:56 -0700
Date: Fri, 13 Mar 2020 14:04:19 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com,
 beilei.xing@intel.com, wei.zhao1@intel.com
Message-ID: <20200313060419.GE44839@intel.com>
References: <20200309141437.11800-1-haiyue.wang@intel.com>
 <20200310065029.40966-1-haiyue.wang@intel.com>
 <20200310065029.40966-4-haiyue.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200310065029.40966-4-haiyue.wang@intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF
	capability
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/10, Haiyue Wang wrote:

> 
>+static int
>+ice_dcf_mode_disable(struct ice_dcf_hw *hw)
>+{
>+	int err;
>+
>+	err = ice_dcf_send_cmd_req_no_irq(hw, VIRTCHNL_OP_DCF_DISABLE,
>+					  NULL, 0);
>+	if (err) {
>+		PMD_DRV_LOG(ERR, "Fail to send msg OP_DCF_DISABLE");
>+		return err;
>+	}
>+
>+	err = ice_dcf_recv_cmd_rsp_no_irq(hw, VIRTCHNL_OP_DCF_DISABLE,
>+					  (uint8_t *)hw->arq_buf,

Unnecessary cast.

>+					  ICE_DCF_AQ_BUF_SZ, NULL);
>+	if (err) {
>+		PMD_DRV_LOG(ERR,
>+			    "Fail to get response of OP_DCF_DISABLE %d",
>+			    err);
>+		return -1;
>+	}
>+
>+	return 0;
>+}