From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B408BA0559; Mon, 16 Mar 2020 12:34:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7F45FEB; Mon, 16 Mar 2020 12:34:04 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BB9083B5; Mon, 16 Mar 2020 12:34:02 +0100 (CET) IronPort-SDR: W/CnkrvlwsQkpCK5hfEbpdhf3ZgctfcwkDHC6DCXPtaGH2RXSJXV3jIuhvK7uXhPzM4bZvob79 pQFYhx2FTupg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 04:34:01 -0700 IronPort-SDR: VsWD5x21GjyqgHppfce/B6vFE2NCNhh1QSXcncD8BeMDjku7RX/zwDEaAgZDUzUdpLgJeXYl2H MwVHLBCqztrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,560,1574150400"; d="scan'208";a="445094050" Received: from silpixa00399126.ir.intel.com ([10.237.222.218]) by fmsmga006.fm.intel.com with ESMTP; 16 Mar 2020 04:33:59 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: thomas@monjalon.net, Dmitry Kozlyuk , Bruce Richardson , gaetan.rivet@6wind.com, stable@dpdk.org Date: Mon, 16 Mar 2020 11:29:51 +0000 Message-Id: <20200316112951.35428-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_pci.h file includes more header files than are actually needed, which means that all users of it also include those headers. This patch removes the unneeded headers - adding them elsewhere where other components were requiring them but not including them directly. Fixes: c752998b5e2e ("pci: introduce library and driver") Cc: gaetan.rivet@6wind.com Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- drivers/bus/ifpga/rte_bus_ifpga.h | 1 + drivers/common/mlx5/mlx5_common.h | 1 + lib/librte_pci/rte_pci.h | 6 ------ 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h b/drivers/bus/ifpga/rte_bus_ifpga.h index 88a628964..a6eeaaf56 100644 --- a/drivers/bus/ifpga/rte_bus_ifpga.h +++ b/drivers/bus/ifpga/rte_bus_ifpga.h @@ -17,6 +17,7 @@ extern "C" { #include #include +#include #include /** Name of Intel FPGA Bus */ diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h index 961c60634..16de1b397 100644 --- a/drivers/common/mlx5/mlx5_common.h +++ b/drivers/common/mlx5/mlx5_common.h @@ -8,6 +8,7 @@ #include #include +#include #include #include #include diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h index c87891405..c591af010 100644 --- a/lib/librte_pci/rte_pci.h +++ b/lib/librte_pci/rte_pci.h @@ -16,17 +16,11 @@ extern "C" { #endif -#include #include #include -#include #include -#include #include -#include -#include - /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ #define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 #define PCI_PRI_STR_SIZE sizeof("XXXXXXXX:XX:XX.X") -- 2.20.1