From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56147A0559; Mon, 16 Mar 2020 18:36:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4249C1C0B8; Mon, 16 Mar 2020 18:36:01 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9F6C51C0B3 for ; Mon, 16 Mar 2020 18:35:59 +0100 (CET) IronPort-SDR: HAKjTa9ed24qkZ4/xlRVSQJnyX5NeoKhs6UQnfJuaBB7S17AAcZBJRHOtNJl+dRFwZa8JwHEMe FAJtmrK0Be2g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 10:35:58 -0700 IronPort-SDR: 8jEnt51aVn2l2KRrgpShkZemKYx4hOG/c/qi87l1EJMJBzw+tM38fMgtmRcaytIQf0D9On3uXl M6yCRMZ1L9dA== X-IronPort-AV: E=Sophos;i="5.70,561,1574150400"; d="scan'208";a="236083752" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.180.130]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 16 Mar 2020 10:35:56 -0700 Date: Mon, 16 Mar 2020 17:35:52 +0000 From: Bruce Richardson To: Mit Matelske Cc: dev@dpdk.org Message-ID: <20200316173552.GA1972@bricha3-MOBL.ger.corp.intel.com> References: <20191120201056.63818-1-mit@pt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191120201056.63818-1-mit@pt.net> Subject: Re: [dpdk-dev] [PATCH] eal/freebsd: fix queuing duplicate eal_alarm_callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 02:10:56PM -0600, Mit Matelske wrote: > The source callback list grows infinitely when more than alarm > is queued. > > This fix recognizes that an alarm interrupt in FreeBSD should never > have more than one callback on its list, so if > rte_intr_callback_register() is called with an interrupt handle type > of RTE_INTR_HANDLE_ALARM, so if such an interrupt type already has a > non-empty list, then a new callback is not created, but the kevent > timer is restarted properly. > > Signed-off-by: Mit Matelske > Acked-by: Bruce Richardson