From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64690A0559; Tue, 17 Mar 2020 08:09:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D651292D; Tue, 17 Mar 2020 08:09:44 +0100 (CET) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id E31BFCF3 for ; Tue, 17 Mar 2020 08:09:42 +0100 (CET) Received: by mail-lf1-f66.google.com with SMTP id f3so5989838lfc.1 for ; Tue, 17 Mar 2020 00:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rod7XxExXTtHUIhcSoMVHE5vX972DIq7mx+drRqK5eY=; b=j6Ut+4Q2ax0VdFru68mpSiu0JvPef7A2Rvv7+D/pMWDeBPTwFNpk2i9Glf5+ij8mug B9B7j94/Ip+Z7cQ76nEqkXFDpOqF7TD0qt6ozW7YPvN40NEl/iaCp/EiTNhx5STRj1dT sJgIYMYMX+u1au/iQ3E/N1tjfaJfR3JnVRr6uSa3T2JJOnj4j8amSITLdw/RM3k9gMCh IhZ8PWk9cUxcpnO5rxlXr/gxvWsddq3Nf2M97+qPI7Ier38vtrye/zPcQX90uNX3OVow BnwSzFoJEyh55yuUsqqOf0IIh2iB2qeqKdNYcGsqfPmxAk7IYPpWa2Do6BfapZJWHHkY 39XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rod7XxExXTtHUIhcSoMVHE5vX972DIq7mx+drRqK5eY=; b=lrm/jQ21Y6lrmWekL5Q8t5DR0bmLfk8/5SSCEClAIbHjq8Erp4IN1bDz7zdkz4n7pr gLrbGjfrkgCs2RiKOCVYvr1sJVKpuX2Z6J2pKNhTtH94gZaSqAES6WMhk7AUuEKR4Fc7 ve5AzFdqpJ8zO6lIM7+9UPZxjXlO8M4tv7rU7Rjl5FybNlMx0CzGKIB69wXc351ZkmKX QEM6NJV6AWNDjUD5VswpLzXRz8IZtGiA3cAWBytsKEFtW31ku5FaiPc8h56BNkjIvaZa KE4ymhNAdCstmah1xaR9+hqkN/wBl5ho6TYNdvGyd6Kd8CkvDUKEpMoA/UOMV0zlcFeN rwoA== X-Gm-Message-State: ANhLgQ2DHqygqZ7yknovqaOEHRdo58bSuUYRWVp8XnAO2d+b9rIICAX3 APcEUECXxlLcFpnchodgX7E= X-Google-Smtp-Source: ADFU+vt6enQUeV8uHHYrXGYr8w9QEybpYsQMF7H7n5p+/It1O2CF1Rv5gDsTzyGMBMgUciaXEtVEHw== X-Received: by 2002:a19:6449:: with SMTP id b9mr1972346lfj.5.1584428982412; Tue, 17 Mar 2020 00:09:42 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id m28sm1693032lfq.39.2020.03.17.00.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 00:09:41 -0700 (PDT) Date: Tue, 17 Mar 2020 10:09:40 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: bruce.richardson@intel.com, dev@dpdk.org, david.marchand@redhat.com, Jerin Jacob , Gavin Hu , Jan Viktorin , Cristian Dumitrescu Message-ID: <20200317100940.726df3a2@Sovereign> In-Reply-To: <4502147.F8r316W7xa@xps> References: <20200316120454.933575-1-thomas@monjalon.net> <4502147.F8r316W7xa@xps> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > This case is now better fixed with a patch removing EAL dependencies > > from the PCI library, which drops rte_common.h inclusion from pmdinfogen: > > http://patches.dpdk.org/patch/66701/ > > Actually rte_common.h is directly included by buildtools/pmdinfogen/pmdinfogen.c > so we need this patch in my opinion. > > > As a consequence, I send this EAL patch just in case we need it > > in future. We can decide to apply or leave it. > > This patch is now gating acceptance of MinGW support. Applied on top of this patch, MinGW patchset builds OK: * by host Clang and target GCC on Linux, * by host Clang and target MinGW on Linux, * by Clang on Windows, * and by MinGW on Windows. Acked-by: Dmitry Kozlyuk -- Dmitry Kozlyuk