From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBCEEA056A; Wed, 18 Mar 2020 04:00:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE56C1C06C; Wed, 18 Mar 2020 04:00:26 +0100 (CET) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 1EFF61C067 for ; Wed, 18 Mar 2020 04:00:26 +0100 (CET) Received: by mail-pj1-f67.google.com with SMTP id ck23so577999pjb.4 for ; Tue, 17 Mar 2020 20:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QB/2rzB1trkWbsnc1vmRMDxwxMzQCmaQBck9wWR6J3I=; b=j9rUmQMJ+RVCPvDHcSn0OZ5Caho0uqnFOfkxWMnHJrfy1okpMOqqrveFrHgsxeHH4E chDEtcl3M6WQOCzt2Gnd7rNzA7KF9BCtUC3urHOkur+hVHqBMCI9ZfGio66qa8py5Bh5 4m8iKBcSsWW8bwgJjhfHybq7ZpHvFQ23eOnMmYq8cBxftGfON7iZAJ3u1+0m0mF+ypCj ejk6tx0/3MEwiyJbM9vBlZeiRzxK6cJH7pcT3Fu+1gC6D5FeO32Jf4VU0ZzELjZuu8xX kWcSsAMJe/jO4b3GBmiJLy0YuF0+dk+vxuaGiwPMJbNwgWy5xvxZaV6kDebk7Tn1bv+s xukw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QB/2rzB1trkWbsnc1vmRMDxwxMzQCmaQBck9wWR6J3I=; b=e4iszeh35B5dX3MNqt4mTzLF5bS7ofwOFqgPHqlvs/FNnqsofYPBbcCWyAkF2/5iH/ OjNT+qaYMYnspGqv2lgrAi2yyFWb3L96p8WjixIPLfyodUDevrsLSi75YIk058AWsDX+ iDib1O260M0TpVb5h1jCn5Wtb9B0fD/en7HOYdnERa5W1msuFRtDRVdmmiwdGcwBuC6C 6oTAbWA/El4sVr91Sk5rmkK3STNiFrswVjFtvQpu9zOx06uNh01LUybkp8G/B+stS9tp 1CxIqvVCleucHy71XUvcdIABmO4qk70YKeKTfN2QBtvk9CbU4kk5SeiH3ChMzGJ40+Nc i3yg== X-Gm-Message-State: ANhLgQ1QQDLKxlR6Oa8dqmMYfGqgs5V93eI2o1673vW/3KAwsGYBpYq7 yGLPk/nuZsw7edZEB5+lZ4T0FQ== X-Google-Smtp-Source: ADFU+vuL5OCsh1CLMJc0BZZ+siG4iElr4DHS//fN3aYr3kWMUFhwMKDiOc4u+qVRoL9Zpf9Om1fVng== X-Received: by 2002:a17:90b:3007:: with SMTP id hg7mr2390234pjb.70.1584500425032; Tue, 17 Mar 2020 20:00:25 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d4sm4352649pfo.217.2020.03.17.20.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 20:00:24 -0700 (PDT) Date: Tue, 17 Mar 2020 20:00:13 -0700 From: Stephen Hemminger To: Chenxu Di Cc: dev@dpdk.org, Yang Qiming Message-ID: <20200317200013.230a3a57@hermes.lan> In-Reply-To: <20200318014710.13577-1-chenxux.di@intel.com> References: <20200318014710.13577-1-chenxux.di@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/4] drivers/net: remove legacy filter API and switch to rte flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 18 Mar 2020 01:47:06 +0000 Chenxu Di wrote: > remove legacy filter functions already implemented in rte_flow > for drivers igb, ixgbe, and i40e. > implement hash function include set hash function and set hash > input set in rte_flow for driver i40e. > > Chenxu Di (4): > net/e1000: remove the legacy filter functions > net/ixgbe: remove the legacy filter functions > net/i40e: remove the legacy filter functions > net/i40e: implement hash function in rte flow API > > doc/guides/nics/i40e.rst | 14 + > doc/guides/rel_notes/release_20_05.rst | 9 + > drivers/net/e1000/igb_ethdev.c | 36 - > drivers/net/i40e/i40e_ethdev.c | 913 +++++++++++-------------- > drivers/net/i40e/i40e_ethdev.h | 26 +- > drivers/net/i40e/i40e_fdir.c | 393 ----------- > drivers/net/i40e/i40e_flow.c | 186 ++++- > drivers/net/ixgbe/ixgbe_ethdev.c | 78 --- > drivers/net/ixgbe/ixgbe_fdir.c | 11 - > 9 files changed, 610 insertions(+), 1056 deletions(-) > This looks like an API break for users using the legacy filter API. Even though filter_ctrl is marked as deprecated. That probably has to wait for 20.11 until it is removed. At that point, drop the ethdev ops handle, the rte_eth_dev_filter_ctrl API (etc) and fix all the test code.