From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFE00A056A; Wed, 18 Mar 2020 01:28:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2039E1C0BD; Wed, 18 Mar 2020 01:28:58 +0100 (CET) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id C78081C0B5 for ; Wed, 18 Mar 2020 01:28:56 +0100 (CET) Received: by mail-lf1-f65.google.com with SMTP id a28so7019419lfr.13 for ; Tue, 17 Mar 2020 17:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cBZAmP2DqKyMhd4iGCtzGWq90anx65j0kfb+CH0pYYo=; b=M0wkLBUjecdSwfAblTb/y58R7j1v/B3usNMB5JzM3g4wrLexUCpMCLkFWi3vCm3wZg ImrIgxYcW1SDQAPuc/L5+wY0/ZYm0l4bG8kaG5nhAjph6pBpldIhs4w1PHJAszD0NIs7 +Mw+0xVJ+cSVaVMbYVroCmqb4287npBIJaAbE6ssmQiCu4+i7wda623VRaF2nqb89gLG 9DZRbPyb/yYxVaI9TGqRK30+G7lxW2Fhwlp6mZ9KvsjVNcfCzHWMCKpwd//HEnb1HoGM tbn8XDcI5SLIYXFuk0Fyw/+oD5sE9Sy3Bp33RF/bBUhRb/fdY64HIM2fxskYy7UNT+U7 z4gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cBZAmP2DqKyMhd4iGCtzGWq90anx65j0kfb+CH0pYYo=; b=PgVZ5Cp78ZByHa9HzgBtFdRLdHC15ZCJbg/2YSJV+B8gaBbylb5d0ULLONFIQONBXP G94TlSptFXU9NOH7BkWBuG5HFtJoPpW3B5c2mX6C7sZL+yAYcXoZhecWQEecR3ok8+de wCXSyIrGEisUPy+FalhQ40YdXLg9IbI2pHOFraaAC4YJErtT1ckXHXXX1NqE+xshht4T knWi66uPmepox1K9kG7+uiAAWc+ofun04kDdNLTaUQULb06ddgHECV0PiEfb/HPqTlbx +9qLazBUco70UtQ0/Z0wmDXQO1uc5H/uZ/vnNZVedqrLZXQn9z5jpuWGNRDRfz2/RIc+ kHFA== X-Gm-Message-State: ANhLgQ2zWNlOwF60bXtdmwtidRyk0BJ75+dkk1SyEjLiuWxRo/ggC+yQ C7o9m0C7kr6PoMoNHKS2dCo= X-Google-Smtp-Source: ADFU+vtDQ+bGCq+gICcUHfa9CjKeLoxizTVuV70+y6ABeoS97rTJ0WuAPKLv1UQTvloPvncDMXx44g== X-Received: by 2002:ac2:51bc:: with SMTP id f28mr1167058lfk.112.1584491336114; Tue, 17 Mar 2020 17:28:56 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id x6sm3345542lji.47.2020.03.17.17.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 17:28:55 -0700 (PDT) Date: Wed, 18 Mar 2020 03:28:48 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: Pallavi Kadam , dev@dpdk.org, ranjit.menon@intel.com, talshn@mellanox.com, narcisa.vasile@microsoft.com Message-ID: <20200318032848.3b6e1d1a@Sovereign> In-Reply-To: <10706758.F0gNSz5aLb@xps> References: <20200317004802.11424-1-pallavi.kadam@intel.com> <20200317004802.11424-3-pallavi.kadam@intel.com> <10706758.F0gNSz5aLb@xps> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] build: add module definitions and pci lib support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 17/03/2020 01:48, Pallavi Kadam: > > Added mman functions to eal exports list. > [...] > > --- a/lib/librte_eal/rte_eal_exports.def > > +++ b/lib/librte_eal/rte_eal_exports.def > > This file is generated. Only the .map can be updated. A minor correction: this file is not generated, it overrides generation of *.def from *.map, see buildtools/map_to_def.py. > > @@ -7,3 +7,5 @@ EXPORTS > > rte_eal_remote_launch > > rte_log > > rte_vlog > > + mmap > > + munmap > > These functions should not be exported for Linux. > > And in general, I think it would be better to state what is > the memory management strategy on Windows first. > Maybe we will need to use a different abstraction. I concur, this patch should be postponed at least. Hopefully we'll settle to something regarding Windows MM at the nearest Community Call. EAL will have to export mmap/munmap-like functions for mapping files and anonymous pages to support library code. Depending on the approach to MM implementation for Windows, not all mmap() calls may even translate into its Win32 equivalent. For example, hugepage allocation on Windows will use different approach that MMF. Mapping device BARs can only be done using IOCTLs on Windows, so rte_pci_map/unmap_resource() code will not work even if it compiles. -- Dmitry Kozlyuk