From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id B583DA0579;
Wed, 18 Mar 2020 20:04:46 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A37B21BF82;
Wed, 18 Mar 2020 20:03:08 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 3236925D9
for <dev@dpdk.org>; Wed, 18 Mar 2020 20:03:07 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
02IJ1QIm019380; Wed, 18 Mar 2020 12:03:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=pfpt0818;
bh=jCJY2cT13LW4W6pDmcbmmxSYE6dSwwEq4BwmANVpCok=;
b=M1j9FdAXZolra0iV/JCzGXHaN2VRtILbQRU71bMMcxRNWFfaBK2RhjeRIOp4i14yNgtD
ntnJrmqAR8YJnfjoBaWBAtQD/v7688oUH9FTbbboS4KoGMJKQaJYIpn0ZMeUjMiMLjST
352Z8QgLBHijuLLxc1lFqjIH5k9ZwPs05SiAnKJ/a1NPYMCSiHpmclOH14citZ3iYzGq
j29jSOrzTSYhmrd3XKEvmdw2kITLzx6IsBr+ur5zQLNBMoI0QZTc3MCPhdoQW87Pmsbq
Wbk5LBoA6jlrrOQEmV4+aIePh+aKyi/xUChRt4Re5ILJc1dwqc6wmHdd5o3wg69WhnOa uQ==
Received: from sc-exch04.marvell.com ([199.233.58.184])
by mx0b-0016f401.pphosted.com with ESMTP id 2yu9rpbrw5-3
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Wed, 18 Mar 2020 12:03:06 -0700
Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com
(10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Wed, 18 Mar 2020 12:03:04 -0700
Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Wed, 18 Mar 2020 12:03:03 -0700
Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com
(10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend
Transport; Wed, 18 Mar 2020 12:03:03 -0700
Received: from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])
by maili.marvell.com (Postfix) with ESMTP id 4C8343F703F;
Wed, 18 Mar 2020 12:03:01 -0700 (PDT)
From: <jerinj@marvell.com>
To: Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
CC: <dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,
<mattias.ronnblom@ericsson.com>
Date: Thu, 19 Mar 2020 00:32:25 +0530
Message-ID: <20200318190241.3150971-17-jerinj@marvell.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20200318190241.3150971-1-jerinj@marvell.com>
References: <20200318190241.3150971-1-jerinj@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645
definitions=2020-03-18_07:2020-03-18,
2020-03-18 signatures=0
Subject: [dpdk-dev] [PATCH v1 16/32] eal/trace: add generic tracepoints
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Jerin Jacob <jerinj@marvell.com>
This patch creates the following generic tracepoint for
generic tracing when there is no dedicated tracepoint is
available.
rte_trace_lib_eal_generic_void()
rte_trace_lib_eal_generic_u64()
rte_trace_lib_eal_generic_u32()
rte_trace_lib_eal_generic_u16()
rte_trace_lib_eal_generic_u8()
rte_trace_lib_eal_generic_i64()
rte_trace_lib_eal_generic_i32()
rte_trace_lib_eal_generic_i16()
rte_trace_lib_eal_generic_i8()
rte_trace_lib_eal_generic_int()
rte_trace_lib_eal_generic_long()
rte_trace_lib_eal_generic_float()
rte_trace_lib_eal_generic_double()
rte_trace_lib_eal_generic_ptr()
rte_trace_lib_eal_generic_str()
For example, if an application wishes to emit an int datatype,
it can call rte_trace_lib_eal_generic_int(val) to emit the trace.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
lib/librte_eal/common/Makefile | 2 +-
.../common/eal_common_trace_points.c | 60 +++++++++
lib/librte_eal/common/include/rte_trace_eal.h | 122 ++++++++++++++++++
lib/librte_eal/common/meson.build | 2 +
lib/librte_eal/freebsd/eal/Makefile | 1 +
lib/librte_eal/linux/eal/Makefile | 1 +
lib/librte_eal/rte_eal_version.map | 17 +++
7 files changed, 204 insertions(+), 1 deletion(-)
create mode 100644 lib/librte_eal/common/eal_common_trace_points.c
create mode 100644 lib/librte_eal/common/include/rte_trace_eal.h
diff --git a/lib/librte_eal/common/Makefile b/lib/librte_eal/common/Makefile
index 8f2f25c1d..452e5e93d 100644
--- a/lib/librte_eal/common/Makefile
+++ b/lib/librte_eal/common/Makefile
@@ -9,7 +9,7 @@ INC += rte_debug.h rte_eal.h rte_eal_interrupts.h
INC += rte_errno.h rte_launch.h rte_lcore.h
INC += rte_log.h rte_memory.h rte_memzone.h
INC += rte_per_lcore.h rte_random.h
-INC += rte_trace.h rte_trace_provider.h rte_trace_register.h
+INC += rte_trace.h rte_trace_eal.h rte_trace_provider.h rte_trace_register.h
INC += rte_tailq.h rte_interrupts.h rte_alarm.h
INC += rte_string_fns.h rte_version.h
INC += rte_eal_memconfig.h
diff --git a/lib/librte_eal/common/eal_common_trace_points.c b/lib/librte_eal/common/eal_common_trace_points.c
new file mode 100644
index 000000000..ff521c981
--- /dev/null
+++ b/lib/librte_eal/common/eal_common_trace_points.c
@@ -0,0 +1,60 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2020 Marvell International Ltd.
+ */
+
+#define RTE_TRACE_POINT_REGISTER_SELECT /* Select trace point register macros */
+
+#include <rte_trace_eal.h>
+
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_void);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_u64);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_u32);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_u16);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_u8);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_i64);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_i32);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_i16);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_i8);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_int);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_long);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_float);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_double);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_ptr);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_str);
+RTE_TRACE_POINT_DEFINE(rte_trace_lib_eal_generic_func);
+
+RTE_INIT(eal_trace_init)
+{
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_void,
+ lib.eal.generic.void, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_u64,
+ lib.eal.generic.u64, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_u32,
+ lib.eal.generic.u32, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_u16,
+ lib.eal.generic.u16, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_u8,
+ lib.eal.generic.u8, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_i64,
+ lib.eal.generic.i64, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_i32,
+ lib.eal.generic.i32, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_i16,
+ lib.eal.generic.i16, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_i8,
+ lib.eal.generic.i8, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_int,
+ lib.eal.generic.int, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_long,
+ lib.eal.generic.long, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_float,
+ lib.eal.generic.float, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_double,
+ lib.eal.generic.double, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_ptr,
+ lib.eal.generic.ptr, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_str,
+ lib.eal.generic.string, INFO);
+ RTE_TRACE_POINT_REGISTER(rte_trace_lib_eal_generic_func,
+ lib.eal.generic.func, INFO);
+}
diff --git a/lib/librte_eal/common/include/rte_trace_eal.h b/lib/librte_eal/common/include/rte_trace_eal.h
new file mode 100644
index 000000000..269ef7502
--- /dev/null
+++ b/lib/librte_eal/common/include/rte_trace_eal.h
@@ -0,0 +1,122 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2020 Marvell International Ltd.
+ */
+
+#ifndef _RTE_TRACE_EAL_H_
+#define _RTE_TRACE_EAL_H_
+
+/**
+ * @file
+ *
+ * API for EAL trace support
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include <rte_trace.h>
+
+/* Generic */
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_void,
+ RTE_TRACE_POINT_ARGS(void),
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_u64,
+ RTE_TRACE_POINT_ARGS(uint64_t in),
+ rte_trace_ctf_u64(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_u32,
+ RTE_TRACE_POINT_ARGS(uint32_t in),
+ rte_trace_ctf_u32(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_u16,
+ RTE_TRACE_POINT_ARGS(uint16_t in),
+ rte_trace_ctf_u16(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_u8,
+ RTE_TRACE_POINT_ARGS(uint8_t in),
+ rte_trace_ctf_u8(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_i64,
+ RTE_TRACE_POINT_ARGS(int64_t in),
+ rte_trace_ctf_i64(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_i32,
+ RTE_TRACE_POINT_ARGS(int32_t in),
+ rte_trace_ctf_i32(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_i16,
+ RTE_TRACE_POINT_ARGS(int16_t in),
+ rte_trace_ctf_i16(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_i8,
+ RTE_TRACE_POINT_ARGS(int8_t in),
+ rte_trace_ctf_i8(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_int,
+ RTE_TRACE_POINT_ARGS(int in),
+ rte_trace_ctf_int(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_long,
+ RTE_TRACE_POINT_ARGS(long in),
+ rte_trace_ctf_long(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_float,
+ RTE_TRACE_POINT_ARGS(float in),
+ rte_trace_ctf_float(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_double,
+ RTE_TRACE_POINT_ARGS(double in),
+ rte_trace_ctf_double(in);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_ptr,
+ RTE_TRACE_POINT_ARGS(const void *ptr),
+ rte_trace_ctf_ptr(ptr);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_str,
+ RTE_TRACE_POINT_ARGS(const char *str),
+ rte_trace_ctf_string(str);
+)
+
+RTE_TRACE_POINT(
+ rte_trace_lib_eal_generic_func,
+ RTE_TRACE_POINT_ARGS(const char *func),
+ rte_trace_ctf_string(func);
+)
+
+#define RTE_TRACE_LIB_EAL_GENERIC_FUNC rte_trace_lib_eal_generic_func(__func__)
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* _RTE_TRACE_EAL_H_ */
diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index 4ccdf1eee..7f11377b3 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -30,6 +30,7 @@ common_sources = files(
'eal_common_timer.c',
'eal_common_trace.c',
'eal_common_trace_ctf.c',
+ 'eal_common_trace_points.c',
'eal_common_trace_utils.c',
'eal_common_uuid.c',
'hotplug_mp.c',
@@ -88,6 +89,7 @@ common_headers = files(
'include/rte_string_fns.h',
'include/rte_tailq.h',
'include/rte_trace.h',
+ 'include/rte_trace_eal.h',
'include/rte_trace_provider.h',
'include/rte_trace_register.h',
'include/rte_time.h',
diff --git a/lib/librte_eal/freebsd/eal/Makefile b/lib/librte_eal/freebsd/eal/Makefile
index 546d79514..07232ba97 100644
--- a/lib/librte_eal/freebsd/eal/Makefile
+++ b/lib/librte_eal/freebsd/eal/Makefile
@@ -62,6 +62,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_fbarray.c
SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_uuid.c
SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_trace.c
SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_trace_ctf.c
+SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_trace_points.c
SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += eal_common_trace_utils.c
SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += rte_malloc.c
SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) += hotplug_mp.c
diff --git a/lib/librte_eal/linux/eal/Makefile b/lib/librte_eal/linux/eal/Makefile
index 1980e9fc5..6158eb0b8 100644
--- a/lib/librte_eal/linux/eal/Makefile
+++ b/lib/librte_eal/linux/eal/Makefile
@@ -70,6 +70,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_fbarray.c
SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_uuid.c
SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_trace.c
SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_trace_ctf.c
+SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_trace_points.c
SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += eal_common_trace_utils.c
SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += rte_malloc.c
SRCS-$(CONFIG_RTE_EXEC_ENV_LINUX) += hotplug_mp.c
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 0c787302f..5c2ff73db 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -364,4 +364,21 @@ EXPERIMENTAL {
rte_trace_from_name;
rte_trace_metadata_dump;
rte_trace_dump;
+
+ __rte_trace_lib_eal_generic_void;
+ __rte_trace_lib_eal_generic_u64;
+ __rte_trace_lib_eal_generic_u32;
+ __rte_trace_lib_eal_generic_u16;
+ __rte_trace_lib_eal_generic_u8;
+ __rte_trace_lib_eal_generic_i64;
+ __rte_trace_lib_eal_generic_i32;
+ __rte_trace_lib_eal_generic_i16;
+ __rte_trace_lib_eal_generic_i8;
+ __rte_trace_lib_eal_generic_int;
+ __rte_trace_lib_eal_generic_long;
+ __rte_trace_lib_eal_generic_float;
+ __rte_trace_lib_eal_generic_double;
+ __rte_trace_lib_eal_generic_ptr;
+ __rte_trace_lib_eal_generic_str;
+ __rte_trace_lib_eal_generic_func;
};
--
2.25.1