From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80719A057D; Wed, 18 Mar 2020 21:34:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55C871C06C; Wed, 18 Mar 2020 21:34:23 +0100 (CET) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 6A717CF3 for ; Wed, 18 Mar 2020 21:34:19 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id w3so12011plz.5 for ; Wed, 18 Mar 2020 13:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d4prE4SN6ZkDoTHAHNXtLgoL+X3q4iJTfZM8yaxA7Qc=; b=t36/nQ8uiCSdiOTCY2YTRq5m4/K4u+TAjeZhp+T2bXhS2gZQXwR6hm/OVQrgD17LxO cf1pqRCTE5NCt4wCDJ06G7OOVLLWsAlayEoKthH4J0iYKmlliQ4omEkW/qeGdLf8nUGa 38PVHgodNzrHeTxTDqBPK1vMM6vN2lCw/+V5yMHokz3o7amf/+Ao1N5DgGJxu3CZx/rp fgVXDT4wfQ3wduVlK5N/+ihSzJ90+lYfc/WTNl01MeVBIx5XgFMblDWFsMN1wlf6bjHQ uazFDiuDBjyhn8/fpDcJkEXZKsXPMCArTKYW2ScRpn7iR/dFzaqQctb/D+f6QsxNwNV+ AVWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d4prE4SN6ZkDoTHAHNXtLgoL+X3q4iJTfZM8yaxA7Qc=; b=jGbCwW+NEpBGqToqrzCtJwpv25o0v8EUbnsv5bf+xQtLCQJh1vJwnj5WGjPxl87nb3 Mun+rgbOlYlHSW4Yig9BhjKWSurVE5DbFdRu/2X4ARWU+uXQnXc58z25KPDydEmMucq9 s48fF+0DUxUsV+4+J04fpTLC37ZuS5Ey26TIccDR7GEy1eES3Z1RwHUHsDwii7TRzIKH m/I9mRrX/MI2LDu08DthdO3etAlOBvPyWwnGE8yx+EAtWos7EPbXYeDiXSqST3sa4gST Jclu+jU8Tb6YRE2j05JTpH7vzHkcHOrGCbPf6XRTnLmjv1XQ3wVl6C6G+FXj/de332a3 TFeA== X-Gm-Message-State: ANhLgQ1kvL/tZyNwqscj9OF4fsFERoURke3qgvLD5Jso+LMLn0iO+ZnO mhmy9MQ8wdyV88JxkcGEbnDGdqQHcEQ= X-Google-Smtp-Source: ADFU+vsqF7k7VphSJJy7DzApdq5ElpwuHzIYAxf0yI7L5i+T4Zo5ou3Yg+Oc1WAojhnciARaOw7kxQ== X-Received: by 2002:a17:90b:1883:: with SMTP id mn3mr6237284pjb.147.1584563658117; Wed, 18 Mar 2020 13:34:18 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p2sm7627591pfb.41.2020.03.18.13.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 13:34:17 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org Date: Wed, 18 Mar 2020 13:29:57 -0700 Message-Id: <20200318202957.18121-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200318202957.18121-1-stephen@networkplumber.org> References: <20200316235612.29854-1-stephen@networkplumber.org> <20200318202957.18121-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 4/4] net/netvsc: don't enable RSS if only single receive queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If application has multiple transmit queues but only a single receive queue, then do not enable RSS. Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index ac6610838008..85f43996a623 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -597,11 +597,14 @@ static int hn_dev_configure(struct rte_eth_dev *dev) return err; } - err = hn_rndis_conf_rss(hv, 0); - if (err) { - PMD_DRV_LOG(NOTICE, - "initial RSS config failed"); - return err; + if ((dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH) && + dev->data->nb_rx_queues > 1) { + err = hn_rndis_conf_rss(hv, 0); + if (err) { + PMD_DRV_LOG(NOTICE, + "initial RSS config failed"); + return err; + } } } -- 2.20.1