From: Stephen Hemminger <stephen@networkplumber.org>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs
Date: Thu, 19 Mar 2020 08:17:33 -0700 [thread overview]
Message-ID: <20200319081733.7c9a6a56@hermes.lan> (raw)
In-Reply-To: <20200319133147.24180-1-sarosh.arif@emumba.com>
On Thu, 19 Mar 2020 18:31:47 +0500
Sarosh Arif <sarosh.arif@emumba.com> wrote:
> - ${OPTIONS[our_entry]} ${our_entry}
>
> + re='^[0-9]+$'
> + if [[ $our_entry =~ $re ]] ; then
> + ${OPTIONS[our_entry]} ${our_entry}
> + fi
> +
Some comments:
1. Use same indentation style as the rest of the script
This follows the mantra that all repairs should like
the original code.
2. If user gives bad data, an error should be printed
and not silently ignored.
3.The variable "re" doesn't need to be a temporary variable.
4. The [[ construct is a bash only thing, and not used elsewhere
in the script.
prev parent reply other threads:[~2020-03-19 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 13:31 Sarosh Arif
2020-03-19 15:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319081733.7c9a6a56@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).