From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EAE9A0583; Fri, 20 Mar 2020 10:34:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEE9A2BBD; Fri, 20 Mar 2020 10:34:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 9F187F94 for ; Fri, 20 Mar 2020 10:34:34 +0100 (CET) IronPort-SDR: o+75bMwRDMTf/ybO4jUh9rFo4InY3bmavOOiuUXH2x3nISvom5aKvYmxulG7d0ZmpP89/EJUV5 w/qimm/BLIAQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2020 02:34:32 -0700 IronPort-SDR: 0yRKvvL5QQd3pn6Oy4JOcQibX5M6AE7i5llZW4wzKo3TYckvaYKt36S4NyUxLA8zMHKCDZFxqJ BN9NGyk6I8+Q== X-IronPort-AV: E=Sophos;i="5.72,284,1580803200"; d="scan'208";a="446600324" Received: from bricha3-mobl.ger.corp.intel.com ([10.254.147.163]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Mar 2020 02:34:23 -0700 Date: Fri, 20 Mar 2020 09:34:18 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, Neil Horman , John McNamara , Marko Kovacevic , Hemant Agrawal , Sachin Saxena , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Gagandeep Singh , Akhil Goyal , Nipun Gupta , Maxime Coquelin , Zhihong Wang , Xiaolong Ye , Ferruh Yigit , Cristian Dumitrescu , Jan Viktorin , Gavin Hu , Jerin Jacob , Harry van Haaren , Anatoly Burakov , Phil Yang , Joyce Kong , Mattias =?iso-8859-1?Q?R=F6nnblom?= , David Christensen , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon , Konstantin Ananyev , Olivier Matz Message-ID: <20200320093418.GA1502@bricha3-MOBL.ger.corp.intel.com> References: <20200320001220.150235-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320001220.150235-1-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH] eal: reorganize directories layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 20, 2020 at 01:12:18AM +0100, Thomas Monjalon wrote: > Some clean-up is done in EAL sub-directories. > The goal is to make organization easier to understand, > and to prepare moving some files from common to Unix-only place. > > Since the kernel modules are moved to kernel/ directory, > there is no need anymore for the sub-directory eal/ in > linux/, freebsd/ and windows/. > > The EAL API (with doxygen documentation) is moved from > common/include/ to include/, which makes more clear that > it is the global API for all environments and architectures. > Note that the arch-specific and os-specific include files are not > in this global include directory, but include/generic/ should > cover the doxygen documentation for them. > > The arch-specific directories arm, ppc_64 and x86 in common/arch/ > and in common/include/arch are moved at the same level as the > os-specific directories, adding an include/ sub-directory. > It makes more clear that EAL is covering a matrix combining OS and arch. > Note that ppc_64 is renamed to ppc. > > These moves offer the opportunity to simplify the make and meson files. > > Signed-off-by: Thomas Monjalon > > --- > > This change was proposed to the Technical Board in advance: > http://mails.dpdk.org/archives/dev/2020-January/156732.html > > If required, the patch may be split: > 1/ remove FreeBSD kernel Makefile > 2/ move arch .c files > 3/ move arch .h files > 4/ move common and generic includes > 5/ move os/eal/ to os/ > I've scanned through this patch and it is quite long. I like the idea of cleanup, but I do think splitting would make reviewing easier, since it's hard to track what is moving where all in one go.