From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9830A0583; Fri, 20 Mar 2020 14:50:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACB1F2BB9; Fri, 20 Mar 2020 14:50:51 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3B272F90 for ; Fri, 20 Mar 2020 14:50:50 +0100 (CET) IronPort-SDR: oL+2o0NGG0xnsagOdWc6GpkCmGRXQf5wPrb9EkEmLdgF6oRwI5Z3z1+hMWadZ1MpjNSPZd++ra TdE6IfXeO2Mg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2020 06:50:48 -0700 IronPort-SDR: E1Zo62ERN/mUCSmQrsJ621yiYIWuoqV9J34BPgfUMF5RYokjyX4eM8cIrIzIJozWtNLHP0Menc wsmxWj763LlQ== X-IronPort-AV: E=Sophos;i="5.72,284,1580803200"; d="scan'208";a="291924199" Received: from bricha3-mobl.ger.corp.intel.com ([10.254.147.163]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Mar 2020 06:50:46 -0700 Date: Fri, 20 Mar 2020 13:50:41 +0000 From: Bruce Richardson To: Jerin Jacob Cc: Ciara Power , "Laatz, Kevin" , dpdk-dev , Reshma Pattan Message-ID: <20200320135041.GA1509@bricha3-MOBL.ger.corp.intel.com> References: <20200319171907.60891-1-ciara.power@intel.com> <20200319171907.60891-12-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 11/12] lib: add telemetry as eal dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 20, 2020 at 05:33:38PM +0530, Jerin Jacob wrote: > On Thu, Mar 19, 2020 at 11:07 PM Ciara Power wrote: > > > > This patch moves telemetry further down the build, and adds it as a > > dependency for EAL. Telemetry is now configured to build by default, and > > has EAL flags, shown below: > > "--telemetry" = Enables telemetry (this is default if no flags given) > > "--no-telemetry" = Disables telemetry > > > > When telemetry is enabled, it will attempt to open the new socket > > version, and also the legacy support socket (this will depend on Jansson > > external dependency, as before). > > > > Signed-off-by: Ciara Power > > Signed-off-by: Bruce Richardson > > --- > > config/common_base | 2 +- > > I think, update to doc/guides/linux_gsg/eal_args.include.rst file is missing. > Yes. I think doc updates generally are missing from this set, but we felt it worthwhile to get a version out now for initial reviews. We'll get the doc updates in a v2, along with some other enhancements to this work. /Bruce