From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92ACCA057C; Thu, 26 Mar 2020 23:02:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCA8C1C038; Thu, 26 Mar 2020 23:02:01 +0100 (CET) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 13DAB1C030 for ; Thu, 26 Mar 2020 23:02:00 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id g2so2686782plo.3 for ; Thu, 26 Mar 2020 15:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tGnABIz2Zw7nFyb36d7uNkcXgtTIlzfQiorFauulDRk=; b=S0WeqRSP+QM3nDFUyv3Gbqxvtwq9Hl8MmiqHahZhjkwE74YVwN+H0b2eRZxQJg+uls Z2mz3NzbmXBLYfc5iWFljI9mzcfyY24yF5tL+J8OyXQR1fR947pN8M7/PephFYiHCbVT B5dxFraTvsfIJoGvpwEZY1MXT0LCMRnoLotXp/FfR9EZtRhf4K2X/1IJ8Nh7DOcRb5Cf QBJ/W2rJPE9bJpjlpal2V2GkOSj8W2lnXtC7L1+JIKTsIdiwB6nnZ5+PBophv02NL5em OeVgsyvBAb9vF0hrEy4ABumkli67UhqoxfXyVlxX21M/tPyEdJ25aFynbyluJ11dJKK8 8XRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tGnABIz2Zw7nFyb36d7uNkcXgtTIlzfQiorFauulDRk=; b=sW76lLbSzUvPm0NAuXwKT6JTbf53gemhBuFV6kOU5O+Vwyto/8LVlZwokUmtP9EuKy GJCjl9Bc8FytkPe28uEMDSf/LybHNhQl6Q44TjKKUQ11y+v2nXSCu50+8+SFA91t7EEv 2oz+pevjxzPoJNdC96tLoK77gS9p3w7fWLCo+f4XmUzn/IgXdPn8HtXFXhI13uFJM6+x VAEZLTJZlUV4HihHv+5OYwJ2wlLHS3GeqZnrvuLbj02YUXCkoL86mHAOiTdGOF1NZFfp WVf93YOLKWUQc+w5Snt02Enh1ZF2Nh4XRNc9sv5GBnNyu3aSCFC19ebO/Wf9KFkS6Q8n rCZg== X-Gm-Message-State: ANhLgQ0FZpDOw+KrjY6vBVOEQH2fbK1NCKMWtuwEBT5hYe4B2KYZrEO1 OzHbUGDN57PrxOIdekuYnkDM1g== X-Google-Smtp-Source: ADFU+vt6djQF7p370OqkFRHFVRu9YNbxeBpHZQutxYF9cNCMVHUFkFqmbkcv2NZUyIlTbZ/KxfU2ng== X-Received: by 2002:a17:902:788e:: with SMTP id q14mr10106032pll.72.1585260120012; Thu, 26 Mar 2020 15:02:00 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e184sm2453995pfh.219.2020.03.26.15.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 15:01:59 -0700 (PDT) Date: Thu, 26 Mar 2020 15:01:50 -0700 From: Stephen Hemminger To: zhihongx.peng@intel.com Cc: xiaolong.ye@intel.com, wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org, liang-min.wang@intel.com Message-ID: <20200326150150.6ac5829f@hermes.lan> In-Reply-To: <20200325033111.9650-1-zhihongx.peng@intel.com> References: <20200325033111.9650-1-zhihongx.peng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 24 Mar 2020 23:31:11 -0400 zhihongx.peng@intel.com wrote: > +/*BSD has no interrupt mechanism, so force NIC status synchronization.*/ > +#ifdef RTE_EXEC_ENV_FREEBSD > + wait = 1; > +#endif > + Please format comments correctly. Is there a better way to detect interrupt mechanism with a function? #ifdef's make for hard to maintain code.