From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94EE0A057C; Fri, 27 Mar 2020 15:54:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6DD21C225; Fri, 27 Mar 2020 15:54:53 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id E32E71C214 for ; Fri, 27 Mar 2020 15:54:52 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id t24so4684474pgj.7 for ; Fri, 27 Mar 2020 07:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LEZJelVOWMIkPIWGM2NIO4k5VC4xbOZP4BQXXl6bVr0=; b=HiIMJBbOkhHCTNcQihNLs1kVIKZY4JKAv+RPXSDxc4RKB2eU2zufD+8L3rXHJ2Omlo 2t8IesvrSSukgkQ/sj2gGumz98FrLXTm00Dj8TcYR0x30VMj+HShcu4BqjmV0eRDZZAt cMfiGMS3pbetygNCMHVm+7SKEEoT3RX/jt52XuQkKQ9Ziaw6q9fLT/STR7BxOKXiaoZv bSwdKtWIuB4fAwCRYmjGfhR3z+uErqQdvcopoiH4UZO+UJyvbz1pckvz3R9jOrjgOz0g XLhDAgIl3otbeaJ9hEv6vJl92ragEV9yEXIGVBTFWNxsEt5ptp5L9emt8andE4B38JHk eFDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LEZJelVOWMIkPIWGM2NIO4k5VC4xbOZP4BQXXl6bVr0=; b=XlYfB2yrb70kcuPF0pM9TTEY8YhViK1CnOY/izmkQwGBc4hHQ3SSjIEPeplfVoXfAS Ru18ZD1Tuz0A5R040h56HPw4vYkQpkSAwrAyov3CYlpFrjrkJyXapigQOnUqPEtgbAZp C4NqoHvf8lvz3Al74FhjA+3CxVIp1E9Z1IwTLQLGoH/UMswqHcTFH8Q2H1S9YiJpRL92 ZoQOomhR+1BkF48STGQBhpFDXgjCqjBqNUtUxQ/IwLlMrdj4cMBhxIlXJr5cqSW0OOys hgGS+dZr/lbfI4xmT2EiOupgCStPqnIuSNn45wxZycGEtGXGqkZaVEhjyvCONha84mS1 Mq2Q== X-Gm-Message-State: ANhLgQ0i+F9svfa72poS0S4fSQKLNXZMAz/YonneC0wtQvFR/u/VR9Sg yCRNP757EBgQqcTYfDy8C+a+2w== X-Google-Smtp-Source: ADFU+vvY2FPz8AayHfJ4jgMKQL4NIfuYXdgzUeEf8L5H78UtWlOTjRzYs8XjVae9eSzXmG/o4ogeWw== X-Received: by 2002:a63:7b5e:: with SMTP id k30mr14235602pgn.209.1585320892109; Fri, 27 Mar 2020 07:54:52 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g81sm4263749pfb.188.2020.03.27.07.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 07:54:51 -0700 (PDT) Date: Fri, 27 Mar 2020 07:54:48 -0700 From: Stephen Hemminger To: Michal Krawczyk Cc: dev@dpdk.org, mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, igorch@amazon.com, stable@dpdk.org Message-ID: <20200327075448.417ef984@hermes.lan> In-Reply-To: <20200327101823.12646-3-mk@semihalf.com> References: <20200327101823.12646-1-mk@semihalf.com> <20200327101823.12646-3-mk@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/29] net/ena/base: make allocation macros thread-safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 27 Mar 2020 11:17:56 +0100 Michal Krawczyk wrote: > From: Igor Chauskin > > Memory allocation region id could possibly be non-unique > due to non-atomic increment, causing allocation failure. > > Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") > Cc: stable@dpdk.org > > Signed-off-by: Igor Chauskin > Reviewed-by: Michal Krawczyk > Reviewed-by: Guy Tzalik With DPDK all control operations are the device are supposed to be single threaded by the caller. Do you have an allocation in some datapath?