From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6293A0589; Fri, 27 Mar 2020 11:32:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABAB71C1A0; Fri, 27 Mar 2020 11:29:44 +0100 (CET) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 73BD91C123 for ; Fri, 27 Mar 2020 11:29:34 +0100 (CET) Received: by mail-lj1-f193.google.com with SMTP id i20so9633392ljn.6 for ; Fri, 27 Mar 2020 03:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UMPTAuIUCLBkm3BNq8Bn3aKNefqVi/wSP1ap2gT7O+g=; b=NuvS5EEPvRieqaKoquSTvw+9tTY9nYNu7OtAvzj/2wX6G/wYbv07JYfl/1WbJ8vhlX MZzOxaGkRtLdEY2Au9PjyhsXvyyp4vKTucut8K024VJnIZtTDhRIZGPz5hOhtwU+aTIZ hF1w1pfUiAzxLpJujPTm7Hgvv1bLJvV2JxpZmp6s54zHyMrRUss3XlOGEJBkeXhnKS5Q 8BTDSYVdgT8l/1VF30eXjoafznR4h2wwVmqDTuN1O8TMtV3kMYE7Z5lxgvKUmE2YR3ME ukOAxeRuZtuqzhbS8CyrSnk7WPGpJIJSATVmoBTVv+RqK7v8UusPujwchVWiyAHQOT60 wdbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UMPTAuIUCLBkm3BNq8Bn3aKNefqVi/wSP1ap2gT7O+g=; b=XyU3zYKziankf813KX9YTOSezRQ4Ka58CBGpnQYO1d38UMYUMBb68mxWXL7ODJurHv l+mz/bhO+mbwQNIxp1P6RXybBA9Q0cGhJJ/KB8v++bXqpUgVkAFZNCVyb504YMOG0Sx4 nXYs4cv0J0l52rWxhrIlRRFSGsL6T5WD4ffihMnqo6FeLCNxAS7Y+fOtLXm5Lfdm5pJh ds6zZ5y1N9tcxk7J5bfUQwQMfUDNh/7vCUFLdQaDh692toy0Fn65lrdh9Opq+wD5svAF NWbbMUSF+JGoE+1SvBlEc+TspJ43vCCX2yIr/Ujwxt+Mz7O1YBd2UJZAejjSA3hCfTqW 8d3w== X-Gm-Message-State: AGi0PublQKslhSK+U5CReCFWQthQKbU8RrbgW9fumsB9Ugijrt6BjfqQ /mDXbHhTvqiNxnYjEuGC6ZZF4jeN+pxh/A== X-Google-Smtp-Source: APiQypLPLVFtv+3b3VJLrG/TtzjjhVt/8bZasysHaxzSMvHHUvpD2Z5oE2aU3o22JRcVntVwp0/rsw== X-Received: by 2002:a2e:a312:: with SMTP id l18mr7940156lje.229.1585304973816; Fri, 27 Mar 2020 03:29:33 -0700 (PDT) Received: from localhost.localdomain (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id i11sm2789587lfo.84.2020.03.27.03.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 03:29:33 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, igorch@amazon.com, Michal Krawczyk Date: Fri, 27 Mar 2020 11:18:12 +0100 Message-Id: <20200327101823.12646-19-mk@semihalf.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200327101823.12646-1-mk@semihalf.com> References: <20200327101823.12646-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 18/29] net/ena: remove memory barriers before doorbells X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The doorbell code is already issuing the doorbell by using rte_write. Because of that, there is no need to do that before calling the function. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/ena_ethdev.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index b8bf31be7c..19a43400d5 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1451,12 +1451,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count) /* When we submitted free recources to device... */ if (likely(i > 0)) { - /* ...let HW know that it can fill buffers with data - * - * Add memory barrier to make sure the desc were written before - * issue a doorbell - */ - rte_wmb(); + /* ...let HW know that it can fill buffers with data. */ ena_com_write_sq_doorbell(rxq->ena_com_io_sq); rxq->next_to_use = next_to_use; @@ -2389,7 +2384,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, PMD_DRV_LOG(DEBUG, "llq tx max burst size of queue %d" " achieved, writing doorbell to send burst\n", tx_ring->id); - rte_wmb(); ena_com_write_sq_doorbell(tx_ring->ena_com_io_sq); } @@ -2412,7 +2406,6 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, /* If there are ready packets to be xmitted... */ if (sent_idx > 0) { /* ...let HW do its best :-) */ - rte_wmb(); ena_com_write_sq_doorbell(tx_ring->ena_com_io_sq); tx_ring->tx_stats.doorbells++; tx_ring->next_to_use = next_to_use; -- 2.20.1