From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76722A0562; Mon, 30 Mar 2020 08:54:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDF0B1BFD9; Mon, 30 Mar 2020 08:54:28 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EA7B62C15; Mon, 30 Mar 2020 08:54:27 +0200 (CEST) IronPort-SDR: S+Nb90Wah4ulAkrZjBounhangguzQW/3ztSbUedVBSuiMAe7YGN7StF0UMBi0E3LAsnttWNZc+ euQblEgg7OSw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2020 23:54:26 -0700 IronPort-SDR: H701x288F2YnOhTQXM7F7WZ6v6/1BNCB+0eMolJpsPm+AHVmc68AIWxxvzYmLBhBgrgFd0Gbla DpIiOR4NDxoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,323,1580803200"; d="scan'208";a="241536659" Received: from unknown (HELO localhost.localdomain.bj.intel.com) ([172.16.182.123]) by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2020 23:54:25 -0700 From: Wei Zhao To: dev@dpdk.org Cc: stable@dpdk.org, xiaolong.ye@intel.com, Wei Zhao Date: Mon, 30 Mar 2020 14:33:23 +0800 Message-Id: <20200330063323.5371-1-wei.zhao1@intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <1582760662-9263-1-git-send-email-wei.zhao1@intel.com> References: <1582760662-9263-1-git-send-email-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix issue for e-tag defination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" An issue has been caused after change definations of bool, we had better use uint16_t to define e-tag ethertype, not 8 bits length bool, that patch will change bool bits length, which introduce a bug for etag/etag_strip for x550 NIC. So change to the 16 bits defination. Cc: stable@dpdk.org Fixes: ad43b7bce95b ("net/ixgbe: avoid multiple definitions of bool") Signed-off-by: Wei Zhao v2: -add more info and find root cause for this issue --- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h index e1cd8fd16..c5d0e0912 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.h +++ b/drivers/net/ixgbe/ixgbe_ethdev.h @@ -358,7 +358,7 @@ struct ixgbe_l2_tn_info { struct rte_hash *hash_handle; bool e_tag_en; /* e-tag enabled */ bool e_tag_fwd_en; /* e-tag based forwarding enabled */ - bool e_tag_ether_type; /* ether type for e-tag */ + uint16_t e_tag_ether_type; /* ether type for e-tag */ }; struct rte_flow { -- 2.19.1