DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 2/7] net/virtio: do not use PMD logtype
Date: Mon, 30 Mar 2020 21:41:51 -0700	[thread overview]
Message-ID: <20200331044156.31935-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org>

Virtio driver has its own logtype adn should not use legacy
PMD logtype.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/virtio/virtio_rxtx.c        | 6 +++---
 drivers/net/virtio/virtio_user_ethdev.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 752faa0f6e7e..060410577af4 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -1085,7 +1085,7 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev,
 			RTE_MIN(vq->vq_nentries / 4, DEFAULT_TX_FREE_THRESH);
 
 	if (tx_free_thresh >= (vq->vq_nentries - 3)) {
-		RTE_LOG(ERR, PMD, "tx_free_thresh must be less than the "
+		PMD_DRV_LOG(ERR, "tx_free_thresh must be less than the "
 			"number of TX entries minus 3 (%u)."
 			" (tx_free_thresh=%u port=%u queue=%u)\n",
 			vq->vq_nentries - 3,
@@ -1133,7 +1133,7 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m)
 		error = virtqueue_enqueue_recv_refill(vq, &m, 1);
 
 	if (unlikely(error)) {
-		RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf");
+		PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf");
 		rte_pktmbuf_free(m);
 	}
 }
@@ -1145,7 +1145,7 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m)
 
 	error = virtqueue_enqueue_refill_inorder(vq, &m, 1);
 	if (unlikely(error)) {
-		RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf");
+		PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf");
 		rte_pktmbuf_free(m);
 	}
 }
diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index e61af4068322..4f565f913bf2 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -561,7 +561,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)
 		const char *name = rte_vdev_device_name(dev);
 		eth_dev = rte_eth_dev_attach_secondary(name);
 		if (!eth_dev) {
-			RTE_LOG(ERR, PMD, "Failed to probe %s\n", name);
+			PMD_INIT_LOG(ERR,"Failed to probe %s", name);
 			return -1;
 		}
 
-- 
2.20.1


  parent reply	other threads:[~2020-03-31  4:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31  4:41 [dpdk-dev] [PATCH 0/7] Remove uses of " Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 1/7] net/mvneta: do not use " Stephen Hemminger
2020-03-31  4:41 ` Stephen Hemminger [this message]
2020-03-31  4:41 ` [dpdk-dev] [PATCH 3/7] net/tap: " Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 4/7] net/pfe: " Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 5/7] net/bnxt: don't " Stephen Hemminger
2020-03-31  4:43   ` Somnath Kotur
2020-03-31  4:41 ` [dpdk-dev] [PATCH 6/7] net/dpaa: use dynamic logtype Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 7/7] net/thunderx: " Stephen Hemminger
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 0/7] Remove some uses of PMD logtype Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 1/7] net/mvneta: do not use " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 2/7] net/virtio: " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 3/7] net/tap: " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 4/7] net/pfe: " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 5/7] net/bnxt: don't " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 6/7] net/dpaa: use dynamic logtype Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 7/7] net/thunderx: " Stephen Hemminger
2020-03-31 17:43   ` [dpdk-dev] [PATCH v2 0/7] Remove some uses of PMD logtype Ferruh Yigit
2020-03-31 17:49     ` Ferruh Yigit
2020-03-31 17:42 ` [dpdk-dev] [PATCH 0/7] Remove " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200331044156.31935-3-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).