From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D923A0562; Tue, 31 Mar 2020 06:42:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55B781C0B1; Tue, 31 Mar 2020 06:42:14 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 4FE881C025 for ; Tue, 31 Mar 2020 06:42:10 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id x7so9784623pgh.5 for ; Mon, 30 Mar 2020 21:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qs9zlBE4fyG5LqFpaPm/c6MNr1pbJrv1ZOQDh6idtJM=; b=BZ2QQZ732fj2dn5geDc+7xPeLWLMRsCQ701s8K6PXNTSGjKlFMMsGBzT4vly8lpcZf Knm0cIUSYhWZjkehvGuyDiLH48cmk/WKWVsuybaWaSg8aqNMnkK1kPciFu/F0z8dafgl Ls8PEcmmU4fyURs7aGGTqAauNg99k7UXaTmH3/N9/YJXIs3TX2IMfwRGSC20OIa4TFgC pa3gonJUiR0eYYKTjNVPcqbUmFKyt2Tm+zmS50RPSwbwmqs0FPbJ9vKIanNW93n4uOyi UMvDFTQwEijZEJv7D5hDye4QTvwXPhewifWivsdPdIMciysQRZe4RzU0Cm+2I/PQJ4h6 s/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qs9zlBE4fyG5LqFpaPm/c6MNr1pbJrv1ZOQDh6idtJM=; b=W7rg8SgXiR2WAV6kWYntZaGDBwIFj8NCNhlnlhDSKhE46ek+gnSEhQHEjcUXFAr7FQ bRXFy13yWD95mA9sNUEa852021h3JIR0XiO3bxPLOQuw5PA4dUUvopvIZJUSV38NpnRd N/cE/Kgu2Mh0USdQX2o7/GOyn0182SCpCMDgGB1/lTqIp2CUsIJMMJgdehRDDwlMYYD4 7sZiRa/4qbXlLPLCI4KOkBqK6N+BbJD5+ufQN7MlFWmYxoY+VdXgi3VM3tYI2XJRSWDC u0PhL7aRIv91Xy8NkeuKHXRdpleO9VijKAT430UoqBNFt5OFZTOmjEZDVu2GE+JlcgBI pxfA== X-Gm-Message-State: ANhLgQ0i4/+X1FhQptw2QWUvsL/pq+16YHvPimKynXYr1pasc1RuQyEp yw3MsbPZCz89wO6GZgKtVS4/4n7JzLFa8w== X-Google-Smtp-Source: ADFU+vvCAB9w+EzuupDEqXsBKMAUkC5HWs6p8tXiH3eGYwx/n6orLtqTmCD8E0RzQUaHLGxFxfW/JA== X-Received: by 2002:a62:6244:: with SMTP id w65mr16560496pfb.89.1585629728936; Mon, 30 Mar 2020 21:42:08 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u129sm11417107pfb.101.2020.03.30.21.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 21:42:08 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 30 Mar 2020 21:41:51 -0700 Message-Id: <20200331044156.31935-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 2/7] net/virtio: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Virtio driver has its own logtype adn should not use legacy PMD logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 6 +++--- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 752faa0f6e7e..060410577af4 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1085,7 +1085,7 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, RTE_MIN(vq->vq_nentries / 4, DEFAULT_TX_FREE_THRESH); if (tx_free_thresh >= (vq->vq_nentries - 3)) { - RTE_LOG(ERR, PMD, "tx_free_thresh must be less than the " + PMD_DRV_LOG(ERR, "tx_free_thresh must be less than the " "number of TX entries minus 3 (%u)." " (tx_free_thresh=%u port=%u queue=%u)\n", vq->vq_nentries - 3, @@ -1133,7 +1133,7 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_recv_refill(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } @@ -1145,7 +1145,7 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_refill_inorder(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index e61af4068322..4f565f913bf2 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -561,7 +561,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev) const char *name = rte_vdev_device_name(dev); eth_dev = rte_eth_dev_attach_secondary(name); if (!eth_dev) { - RTE_LOG(ERR, PMD, "Failed to probe %s\n", name); + PMD_INIT_LOG(ERR,"Failed to probe %s", name); return -1; } -- 2.20.1