DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	jerin.jacob@caviumnetworks.com
Subject: [dpdk-dev] [PATCH 7/7] net/thunderx: use dynamic logtype
Date: Mon, 30 Mar 2020 21:41:56 -0700	[thread overview]
Message-ID: <20200331044156.31935-8-stephen@networkplumber.org> (raw)
In-Reply-To: <20200331044156.31935-1-stephen@networkplumber.org>

The PMD static logtype is original DPDK legacy and should not be used.

Fixes: 43362c6a7647 ("net/thunderx: support RSS and RETA query and update")
Cc: jerin.jacob@caviumnetworks.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/thunderx/nicvf_ethdev.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index 6f43541a5d42..00e8287fac38 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -496,9 +496,10 @@ nicvf_dev_reta_query(struct rte_eth_dev *dev,
 	int ret, i, j;
 
 	if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) {
-		RTE_LOG(ERR, PMD, "The size of hash lookup table configured "
-			"(%d) doesn't match the number hardware can supported "
-			"(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
+		PMD_DRV_LOG(ERR,
+			    "The size of hash lookup table configured "
+			    "(%u) doesn't match the number hardware can supported "
+			    "(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
 		return -EINVAL;
 	}
 
@@ -526,9 +527,9 @@ nicvf_dev_reta_update(struct rte_eth_dev *dev,
 	int ret, i, j;
 
 	if (reta_size != NIC_MAX_RSS_IDR_TBL_SIZE) {
-		RTE_LOG(ERR, PMD, "The size of hash lookup table configured "
-			"(%d) doesn't match the number hardware can supported "
-			"(%d)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
+		PMD_DRV_LOG(ERR,"The size of hash lookup table configured "
+			"(%u) doesn't match the number hardware can supported "
+			"(%u)", reta_size, NIC_MAX_RSS_IDR_TBL_SIZE);
 		return -EINVAL;
 	}
 
@@ -569,8 +570,8 @@ nicvf_dev_rss_hash_update(struct rte_eth_dev *dev,
 
 	if (rss_conf->rss_key &&
 		rss_conf->rss_key_len != RSS_HASH_KEY_BYTE_SIZE) {
-		RTE_LOG(ERR, PMD, "Hash key size mismatch %d",
-				rss_conf->rss_key_len);
+		PMD_DRV_LOG(ERR, "Hash key size mismatch %u",
+			    rss_conf->rss_key_len);
 		return -EINVAL;
 	}
 
-- 
2.20.1


  parent reply	other threads:[~2020-03-31  4:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31  4:41 [dpdk-dev] [PATCH 0/7] Remove uses of PMD logtype Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 1/7] net/mvneta: do not use " Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 2/7] net/virtio: " Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 3/7] net/tap: " Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 4/7] net/pfe: " Stephen Hemminger
2020-03-31  4:41 ` [dpdk-dev] [PATCH 5/7] net/bnxt: don't " Stephen Hemminger
2020-03-31  4:43   ` Somnath Kotur
2020-03-31  4:41 ` [dpdk-dev] [PATCH 6/7] net/dpaa: use dynamic logtype Stephen Hemminger
2020-03-31  4:41 ` Stephen Hemminger [this message]
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 0/7] Remove some uses of PMD logtype Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 1/7] net/mvneta: do not use " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 2/7] net/virtio: " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 3/7] net/tap: " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 4/7] net/pfe: " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 5/7] net/bnxt: don't " Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 6/7] net/dpaa: use dynamic logtype Stephen Hemminger
2020-03-31 17:31   ` [dpdk-dev] [PATCH v2 7/7] net/thunderx: " Stephen Hemminger
2020-03-31 17:43   ` [dpdk-dev] [PATCH v2 0/7] Remove some uses of PMD logtype Ferruh Yigit
2020-03-31 17:49     ` Ferruh Yigit
2020-03-31 17:42 ` [dpdk-dev] [PATCH 0/7] Remove " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200331044156.31935-8-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).