From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 841F5A0562; Tue, 31 Mar 2020 17:58:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBEE61BFC6; Tue, 31 Mar 2020 17:58:46 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id B37821BFC5 for ; Tue, 31 Mar 2020 17:58:44 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id kx8so1248681pjb.5 for ; Tue, 31 Mar 2020 08:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jFY80kTd8ZzeW2YXSl+2Hx8qg2Wf3M4PIle7GC9Ico4=; b=PFBp4KgNGnK8KEfuLIrvuOCWXXg3wdGKtTHezNeLNVm75QvITf+R9pJkGuSpNrmTav 6oMA+ZQJj+SAOFdGgCK2SkU8ACbSsOrNDFVZ+e8wecMg/QVZuKBqoxUU0yeGHQqUAPR5 rYnkdtpGwdp3SBTuUJvrnnHEFvpd1/rbk1+dyUXWUnIABwcrmfwKQrQGbGtQgUvbdgUa V3DMTKVX+54zPyX620VlN4KdL31OBAQG17IL8SnBpI3FH44CWyCUPYRFzk/vwRBoPA6P S1VsDeun/3FUWWxfTi4M2K0qP2cBJl5RY+c0ZmaihqxCPt8N5YAyjJdmktPKZqjW4DPt +knw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jFY80kTd8ZzeW2YXSl+2Hx8qg2Wf3M4PIle7GC9Ico4=; b=RI0YR6iLatkKyqIm3R5SQYeVGsm9cM6jWNEIDKdkA2Qv93RRUrxJSJIRyVysi2X+yG dIrZ9Hw5Os919X7RmoRlbCMdxTFLbz536wltdeFgi1SG9UY7WU6SwLeNsAVxR5JCbmNb j00vexdg1j9+aoBTv/kIuONzykbDQZ0n/L1tiZ2a6HuRMDHAc38tLnpoffKOEdPz71rs uC/n5T6WBYsIJR+lPkJ/gpe7mCBnXntn+6oYfxWapgOoW3dQLub6tKp7OMnDi5hltM7s ui0f963HD+1n9btBsCHI+tx1jo7mNCHa6wCsaYHdDsxCQK95m6+xnWn1GwQAh/fHjr8D IcmQ== X-Gm-Message-State: AGi0PuaBgfcALa1GBos4TF1QlxQ+qwfbCcNWa9pEZORJO9S5RKe8pIUv BluDeLhTRqEOG7lx9esCvZ6m7Q== X-Google-Smtp-Source: APiQypJ+zMpTvI1W/z9QEDy7eAGrw1kANciuFh2oLD0nOhNvsYaJ6AMUUtUgbpEy3wolPE9NU6T2zw== X-Received: by 2002:a17:90a:1acd:: with SMTP id p71mr5084470pjp.112.1585670323782; Tue, 31 Mar 2020 08:58:43 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i189sm12797866pfc.148.2020.03.31.08.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 08:58:43 -0700 (PDT) Date: Tue, 31 Mar 2020 08:58:30 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Ferruh Yigit , Ajit Khaparde , Lance Richardson , dpdk-dev , dpdk stable , Bruce Richardson , Andrew Rybchenko Message-ID: <20200331085830.343dc7e6@hermes.lan> In-Reply-To: <2306774.KokGdZ0ToA@xps> References: <20200305064500.5634-1-stephen@networkplumber.org> <2306774.KokGdZ0ToA@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: allow configuring vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 31 Mar 2020 17:43:55 +0200 Thomas Monjalon wrote: > 31/03/2020 16:31, Ajit Khaparde: > > On Tue, Mar 31, 2020 at 4:36 AM Ferruh Yigit wrote: > > > > > On 3/5/2020 10:18 PM, Stephen Hemminger wrote: > > > > On Thu, 5 Mar 2020 15:10:48 -0500 > > > > Lance Richardson wrote: > > > > > > > >> Hi Stephen, > > > >> > > > >> On Thu, Mar 5, 2020 at 1:45 AM Stephen Hemminger > > > >> wrote: > > > >>> > > > >> > > > >>> > > > >>> Make the configuration use the same as other drivers with > > > >>> vector mode: ixge, i40e, ... > > > >> s/ixge/ixgbe/? > > > >> > > > >>> > > > >> > > > >>> This will also make future support of vector mode on other > > > >>> architectures possible. > > > >>> > > > >>> Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") > > > >> > > > >>> +#error "bnxt: IEEE1588 is incompatiable with vector mode" > > > >>> +#endif > > > >> s/incompatiable/incompatible/ > > > >> > > > >> > > > >> This was this approach taken in the initial patch set to add bnxt > > > >> vector mode support, > > > >> however based on feedback the current approach was used instead. That > > > discussion > > > >> can be found here: > > > >> http://patches.dpdk.org/patch/53683/ > > > >> > > > >> If mark support could be treated as a receive offload, it would be > > > >> possible to choose > > > >> the non-vector receive handler based on whether mark is enabled. Adding > > > a kvargs > > > >> option to disable vector mode might be another possibility. Otherwise, > > > >> a build-time > > > >> configuration option does seem to be useful. > > > >> > > > >> LGTM... with the above: > > > >> > > > >> Acked-by: Lance Richardson > > > > > > > > What ever solution must be consistent across all drivers. > > > > > > > > > > I saw Ajit merged this patch to brcm tree, but I am not sure about it. We > > > have > > > already removed this compile time option from some PMDs, and driver tries > > > to > > > detect to use or not to use vectorization transparently. > > > > > > This config is also a problem for the meson, which always sets the flag in > > > a > > > hardcoded way. > > > > > > But also I am not sure about to need to enable/disable vectorization > > > explicitly, > > > this patch seems because of this need. As far as I remember in the past > > > this > > > type of runtime configuration rejected to not make driver configuration > > > more > > > complex. > > > > Since we need a way to disable or enable vector mode. > > Why do you need to disable vector optimization? > Is it for debugging? The rte_flow mark operation does not work with the vector optimization. The choice to use vector mode is done by the driver earlier in the initialization process, and then when application programs rte_flow it has a problem; the flow create would fail.