DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	dpdk-dev <dev@dpdk.org>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 0/6] net/bnxt: bounds checking patches
Date: Tue, 31 Mar 2020 11:04:35 -0700	[thread overview]
Message-ID: <20200331110435.27507cf1@hermes.lan> (raw)
In-Reply-To: <CACZ4nhvLgFVoW0gyK-=vEK7-B4Bv3JZpmpe-CXV_MgQuDSUP8w@mail.gmail.com>

On Tue, 31 Mar 2020 10:52:47 -0700
Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:

> On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> > On 3/3/2020 5:59 PM, Stephen Hemminger wrote:  
> > > This set of patches came from security review of bnxt driver.
> > > It introduces a set of overflow macros that could be more widely
> > > used in other places in DPDK to check for math overflows.
> > >
> > > Stephen Hemminger (6):
> > >   eal: add portable way to check for math overflow
> > >   net/bnxt: fix potential data race
> > >   net/bnxt: avoid potential out of bounds read
> > >   net/bnxt: check for integer overflow in buffer sizing
> > >   net/bnxt: add integer underflow check
> > >   net/bnxt: sanitize max_l2_ctx
> > >  
> >
> > Hi Ajit,
> >
> > I can see this patchset has been merged into your tree, although the note
> > in the
> > mail list is missing. Since it has eal changes, I believe they should be
> > reviewed first before merging into brcm tree, can you separate the eal and
> > dependent patch for review, we can proceed with rest?
> >  
> I don't mind.
> But being original owner - Stephen, do you want to go ahead?
> 
> Thanks
> Ajit
> 
> >
> > Regards,
> > ferruh
> >  

Sure, I expected normal review cycle on this.
Hoped that other drivers and eal core would also add overflow checks

  reply	other threads:[~2020-03-31 18:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 17:59 Stephen Hemminger
2020-03-03 17:59 ` [dpdk-dev] [PATCH 1/6] eal: add portable way to check for math overflow Stephen Hemminger
2020-03-03 22:28   ` Dmitry Kozlyuk
2020-03-03 17:59 ` [dpdk-dev] [PATCH 2/6] net/bnxt: fix potential data race Stephen Hemminger
2020-03-03 18:13   ` [dpdk-dev] [EXTERNAL] " Christopher Ertl
2020-03-03 18:16     ` Stephen Hemminger
2020-03-03 17:59 ` [dpdk-dev] [PATCH 3/6] net/bnxt: avoid potential out of bounds read Stephen Hemminger
2020-03-03 17:59 ` [dpdk-dev] [PATCH 4/6] net/bnxt: check for integer overflow in buffer sizing Stephen Hemminger
2020-03-03 17:59 ` [dpdk-dev] [PATCH 5/6] net/bnxt: add integer underflow check Stephen Hemminger
2020-03-03 17:59 ` [dpdk-dev] [PATCH 6/6] net/bnxt: sanitize max_l2_ctx Stephen Hemminger
2020-03-31 11:47 ` [dpdk-dev] [PATCH 0/6] net/bnxt: bounds checking patches Ferruh Yigit
2020-03-31 17:52   ` Ajit Khaparde
2020-03-31 18:04     ` Stephen Hemminger [this message]
2020-10-19 22:28       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200331110435.27507cf1@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=somnath.kotur@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).