From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, ophirmu@mellanox.com
Subject: [dpdk-dev] [PATCH v2 3/7] net/tap: do not use PMD logtype
Date: Tue, 31 Mar 2020 10:31:06 -0700 [thread overview]
Message-ID: <20200331173110.25746-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org>
The PMD logtype is legacy and drivers should use their own logtype.
Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)")
Cc: ophirmu@mellanox.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/tap/rte_eth_tap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 05470a211588..2c9fb76b63de 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -778,7 +778,7 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request,
case SIOCSIFMTU:
break;
default:
- RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n",
+ TAP_LOG(WARNING, "%s: ioctl() called with wrong arg",
pmd->name);
return -EINVAL;
}
@@ -1301,7 +1301,9 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev)
SOCKET_ID_ANY);
if (!mp) {
struct pmd_internals *pmd = dev->data->dev_private;
- RTE_LOG(DEBUG, PMD, "%s: failed to create mbuf pool for device %s\n",
+
+ TAP_LOG(ERR,
+ "%s: failed to create mbuf pool for device %s\n",
pmd->name, dev->device->name);
return -1;
}
--
2.20.1
next prev parent reply other threads:[~2020-03-31 17:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 4:41 [dpdk-dev] [PATCH 0/7] Remove uses of " Stephen Hemminger
2020-03-31 4:41 ` [dpdk-dev] [PATCH 1/7] net/mvneta: do not use " Stephen Hemminger
2020-03-31 4:41 ` [dpdk-dev] [PATCH 2/7] net/virtio: " Stephen Hemminger
2020-03-31 4:41 ` [dpdk-dev] [PATCH 3/7] net/tap: " Stephen Hemminger
2020-03-31 4:41 ` [dpdk-dev] [PATCH 4/7] net/pfe: " Stephen Hemminger
2020-03-31 4:41 ` [dpdk-dev] [PATCH 5/7] net/bnxt: don't " Stephen Hemminger
2020-03-31 4:43 ` Somnath Kotur
2020-03-31 4:41 ` [dpdk-dev] [PATCH 6/7] net/dpaa: use dynamic logtype Stephen Hemminger
2020-03-31 4:41 ` [dpdk-dev] [PATCH 7/7] net/thunderx: " Stephen Hemminger
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 0/7] Remove some uses of PMD logtype Stephen Hemminger
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 1/7] net/mvneta: do not use " Stephen Hemminger
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 2/7] net/virtio: " Stephen Hemminger
2020-03-31 17:31 ` Stephen Hemminger [this message]
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 4/7] net/pfe: " Stephen Hemminger
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 5/7] net/bnxt: don't " Stephen Hemminger
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 6/7] net/dpaa: use dynamic logtype Stephen Hemminger
2020-03-31 17:31 ` [dpdk-dev] [PATCH v2 7/7] net/thunderx: " Stephen Hemminger
2020-03-31 17:43 ` [dpdk-dev] [PATCH v2 0/7] Remove some uses of PMD logtype Ferruh Yigit
2020-03-31 17:49 ` Ferruh Yigit
2020-03-31 17:42 ` [dpdk-dev] [PATCH 0/7] Remove " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331173110.25746-4-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ophirmu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).