DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ethdev: fix for compiler warning when vtune profiling option is enabled
@ 2020-04-01 11:16 eugeny.parshutin
  2020-04-01 12:26 ` [dpdk-dev] [PATCH v2] " eugeny.parshutin
  0 siblings, 1 reply; 3+ messages in thread
From: eugeny.parshutin @ 2020-04-01 11:16 UTC (permalink / raw)
  To: thomas, ferruh.yigit, john.mcnamara; +Cc: dev, eugeny.parshutin, roman.p.khatko

From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>

Add the previous prototype for the 'profile_hook_rx_burst_cb' function to fix the compiler warning when the DPDK is built with 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled:
/home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning: no previous prototype for ‘profile_hook_rx_burst_cb’ [-Wmissing-prototypes]

Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
---
 lib/librte_ethdev/ethdev_profile.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lib/librte_ethdev/ethdev_profile.h b/lib/librte_ethdev/ethdev_profile.h
index 65031e6f3..b8c3c6848 100644
--- a/lib/librte_ethdev/ethdev_profile.h
+++ b/lib/librte_ethdev/ethdev_profile.h
@@ -24,4 +24,14 @@
 int
 __rte_eth_dev_profile_init(uint16_t port_id, struct rte_eth_dev *dev);
 
+#ifdef RTE_ETHDEV_PROFILE_WITH_VTUNE
+
+uint16_t
+profile_hook_rx_burst_cb(
+	__rte_unused uint16_t port_id, __rte_unused uint16_t queue_id,
+	__rte_unused struct rte_mbuf *pkts[], uint16_t nb_pkts,
+	__rte_unused uint16_t max_pkts, __rte_unused void *user_param);
+
+#endif /* RTE_ETHDEV_PROFILE_WITH_VTUNE */
+
 #endif
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH v2] ethdev: fix for compiler warning when vtune profiling option is enabled
  2020-04-01 11:16 [dpdk-dev] [PATCH] ethdev: fix for compiler warning when vtune profiling option is enabled eugeny.parshutin
@ 2020-04-01 12:26 ` eugeny.parshutin
  2020-04-01 19:48   ` Alexander Kozyrev
  0 siblings, 1 reply; 3+ messages in thread
From: eugeny.parshutin @ 2020-04-01 12:26 UTC (permalink / raw)
  To: thomas, ferruh.yigit, john.mcnamara; +Cc: dev, eugeny.parshutin, roman.p.khatko

From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>

Add the previous prototype for the 'profile_hook_rx_burst_cb' function
to fix the compiler warning when the DPDK is built with
'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled:
/home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning:
no previous prototype for profile_hook_rx_burst_cb [-Wmissing-prototypes]

Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
---
v2: Fix the commit message
---
 lib/librte_ethdev/ethdev_profile.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lib/librte_ethdev/ethdev_profile.h b/lib/librte_ethdev/ethdev_profile.h
index 65031e6f3..b8c3c6848 100644
--- a/lib/librte_ethdev/ethdev_profile.h
+++ b/lib/librte_ethdev/ethdev_profile.h
@@ -24,4 +24,14 @@
 int
 __rte_eth_dev_profile_init(uint16_t port_id, struct rte_eth_dev *dev);
 
+#ifdef RTE_ETHDEV_PROFILE_WITH_VTUNE
+
+uint16_t
+profile_hook_rx_burst_cb(
+	__rte_unused uint16_t port_id, __rte_unused uint16_t queue_id,
+	__rte_unused struct rte_mbuf *pkts[], uint16_t nb_pkts,
+	__rte_unused uint16_t max_pkts, __rte_unused void *user_param);
+
+#endif /* RTE_ETHDEV_PROFILE_WITH_VTUNE */
+
 #endif
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ethdev: fix for compiler warning when vtune profiling option is enabled
  2020-04-01 12:26 ` [dpdk-dev] [PATCH v2] " eugeny.parshutin
@ 2020-04-01 19:48   ` Alexander Kozyrev
  0 siblings, 0 replies; 3+ messages in thread
From: Alexander Kozyrev @ 2020-04-01 19:48 UTC (permalink / raw)
  To: eugeny.parshutin, Thomas Monjalon, ferruh.yigit, john.mcnamara
  Cc: dev, roman.p.khatko

Hi Eugeny, 

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> eugeny.parshutin@linux.intel.com
> Sent: Wednesday, April 1, 2020 8:26
> To: Thomas Monjalon <thomas@monjalon.net>; ferruh.yigit@intel.com;
> john.mcnamara@intel.com
> Cc: dev@dpdk.org; eugeny.parshutin@linux.intel.com;
> roman.p.khatko@intel.com
> Subject: [dpdk-dev] [PATCH v2] ethdev: fix for compiler warning when vtune
> profiling option is enabled
> 
> From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> 
> Add the previous prototype for the 'profile_hook_rx_burst_cb' function to
> fix the compiler warning when the DPDK is built with
> 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled:
> /home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning:
> no previous prototype for profile_hook_rx_burst_cb [-Wmissing-
> prototypes]
> 
> Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> ---
> v2: Fix the commit message
> ---
>  lib/librte_ethdev/ethdev_profile.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/lib/librte_ethdev/ethdev_profile.h
> b/lib/librte_ethdev/ethdev_profile.h
> index 65031e6f3..b8c3c6848 100644
> --- a/lib/librte_ethdev/ethdev_profile.h
> +++ b/lib/librte_ethdev/ethdev_profile.h
> @@ -24,4 +24,14 @@
>  int
>  __rte_eth_dev_profile_init(uint16_t port_id, struct rte_eth_dev *dev);
> 
> +#ifdef RTE_ETHDEV_PROFILE_WITH_VTUNE
> +
> +uint16_t
> +profile_hook_rx_burst_cb(
> +	__rte_unused uint16_t port_id, __rte_unused uint16_t queue_id,
> +	__rte_unused struct rte_mbuf *pkts[], uint16_t nb_pkts,
> +	__rte_unused uint16_t max_pkts, __rte_unused void
> *user_param);
> +
> +#endif /* RTE_ETHDEV_PROFILE_WITH_VTUNE */
> +
>  #endif
> --
> 2.17.1

Could you please fix the check-git-log.sh warnings:

Headline too long:
        ethdev: fix for compiler warning when vtune profiling option is enabled
Missing 'Fixes' tag:
        ethdev: fix for compiler warning when vtune profiling option is enabled

Regards,
Alex


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-01 19:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01 11:16 [dpdk-dev] [PATCH] ethdev: fix for compiler warning when vtune profiling option is enabled eugeny.parshutin
2020-04-01 12:26 ` [dpdk-dev] [PATCH v2] " eugeny.parshutin
2020-04-01 19:48   ` Alexander Kozyrev

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git