From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 934E6A057B; Wed, 1 Apr 2020 15:19:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C46B51BEAA; Wed, 1 Apr 2020 15:19:06 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 77EF71BDAC for ; Wed, 1 Apr 2020 15:19:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585747144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wb0D5HgZ66vFFP8s3SSRe6vjYfLc1IdHq3fIMPsHgZ0=; b=Zh9yleJfYnYkIMTjWELyt9oEHecUKYuEbdvPKthW8oCKZknY+uDlkER5O92glCKxD2CGGq DzxYtdFAp7Lge3SZ9F4kRRyDbTtgMafotFcbyVy8CH9XlabZ9DM9/v95ra//YV6SH9U7CC e3kyGqOEoUnHxK87jLBQjLB3NcMPCIc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-Mg3eBJ45PGSrsnCEyJjUzA-1; Wed, 01 Apr 2020 09:19:01 -0400 X-MC-Unique: Mg3eBJ45PGSrsnCEyJjUzA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5AD19800D4E; Wed, 1 Apr 2020 13:18:59 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-116-136.phx2.redhat.com [10.3.116.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A6671001B07; Wed, 1 Apr 2020 13:18:57 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Cc: Konstantin Ananyev , Sunil Kumar Kori , Allain Legacy , Anatoly Burakov , Chas Williams , Piotr Azarewicz , Bruce Richardson , David Marchand Date: Wed, 1 Apr 2020 09:18:47 -0400 Message-Id: <20200401131849.2209336-3-aconole@redhat.com> In-Reply-To: <20200401131849.2209336-1-aconole@redhat.com> References: <20200331160714.697790-1-aconole@redhat.com> <20200401131849.2209336-1-aconole@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v2 2/4] ip_frag: ensure minimum v6 fragmentation length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Similar to v4, we should ensure that at least a minimum fragmentation length can be achieved. Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv6_fragmentation.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.c b/lib/librte_ip_fr= ag/rte_ipv6_fragmentation.c index 43449970e5..820a5dc725 100644 --- a/lib/librte_ip_frag/rte_ipv6_fragmentation.c +++ b/lib/librte_ip_frag/rte_ipv6_fragmentation.c @@ -79,6 +79,17 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in, =09uint16_t fragment_offset, frag_size; =09uint64_t frag_bytes_remaining; =20 +=09/* +=09 * The rules on ipv6 fragmentation means we need at least to be +=09 * greater than the smallest fragment possible - ipv6hdr + frag header +=09 * + min octets. We rely on the ipv6_extension_fragment header to +=09 * include 'data' octets. +=09 */ +=09if (unlikely(mtu_size < +=09=09 (sizeof(struct rte_ipv6_hdr) + +=09=09 sizeof(struct ipv6_extension_fragment)))) +=09=09return -EINVAL; + =09/* =09 * Ensure the IP payload length of all fragments (except the =09 * the last fragment) are a multiple of 8 bytes per RFC2460. --=20 2.25.1