From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16081A0562; Fri, 3 Apr 2020 11:10:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9EE41C128; Fri, 3 Apr 2020 11:10:43 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7B9E21C127 for ; Fri, 3 Apr 2020 11:10:41 +0200 (CEST) IronPort-SDR: 7NwD2fcS7vH0hE2rdWPwUGBKOUckftDBAYLIaDwsVtO5VCqn4wwRKFASl8dkJ7oo4+3Z2Yi9TF rOJYVNRXwv+w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 02:10:40 -0700 IronPort-SDR: gWmT8EcGBziAxpY8w12wq+t8WPv71oe3ZI/ZwSsSLpslhF/1iekt3Nhqtrm1ge2XiQmYGIjhbL rM5rpoYZowKQ== X-IronPort-AV: E=Sophos;i="5.72,339,1580803200"; d="scan'208";a="423463416" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.36.192]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Apr 2020 02:10:38 -0700 Date: Fri, 3 Apr 2020 10:10:34 +0100 From: Bruce Richardson To: David Marchand Cc: Pavan Nikhilesh Bhagavatula , Jerin Jacob , Thomas Monjalon , Ferruh Yigit , dev , Neil Horman Message-ID: <20200403091034.GA543@bricha3-MOBL.ger.corp.intel.com> References: <20200402183253.866-1-jerinjacobk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 03, 2020 at 10:18:02AM +0200, David Marchand wrote: > On Fri, Apr 3, 2020 at 10:06 AM Pavan Nikhilesh Bhagavatula > wrote: > > > > > wrote: > > >> On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob > > >wrote: > > >> - You can still find traces in meson files. > > >> $ git grep -il allow.experimental.api |grep meson.build$ |grep -vE > > >> '^((app|drivers|lib)/meson.build|examples/)' > > >> app/test/meson.build > > >> drivers/net/e1000/base/meson.build > > >> drivers/net/enic/meson.build > > >> drivers/net/i40e/base/meson.build > > >> drivers/net/i40e/meson.build > > >> drivers/net/ixgbe/base/meson.build > > >> drivers/net/octeontx/base/meson.build > > >> drivers/net/qede/base/meson.build > > >> drivers/net/sfc/base/meson.build > > >> drivers/net/thunderx/base/meson.build > > >> lib/librte_mempool/meson.build > > > > > >Sorry, those drivers passing directly the cflag were special cases. > > > > Yup. Mostly base static libs. > > Actually, how about something like this in drivers/meson.build ? > Bruce, do you see something wrong with this ? > > on top of Pavan patch: > > diff --git a/drivers/meson.build b/drivers/meson.build > index 987e616ae7..4d8f842ab8 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -20,7 +20,7 @@ dpdk_driver_classes = ['common', > disabled_drivers = run_command(list_dir_globs, get_option('disable_drivers'), > ).stdout().split() > > -default_cflags = machine_args > +default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API'] > if cc.has_argument('-Wno-format-truncation') > default_cflags += '-Wno-format-truncation' > endif I see nothing wrong with that. Out of interest, is there a reason we don't just set it at the top level as a project c_arg, e.g. after setting "-include rte_config.h" in config/meson.build?