* [dpdk-dev] [PATCH v1] fix memif does not free resources
@ 2020-04-04 10:15 Vadim Podovinnikov
2020-04-04 10:15 ` [dpdk-dev] [PATCH] " Vadim Podovinnikov
0 siblings, 1 reply; 4+ messages in thread
From: Vadim Podovinnikov @ 2020-04-04 10:15 UTC (permalink / raw)
To: dev; +Cc: Vadim Podovinnikov
Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
---
drivers/net/memif/rte_eth_memif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index 81d71c53a..653ffa9b8 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1510,7 +1510,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
}
- eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
+ eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
rte_eth_dev_probing_finish(eth_dev);
--
2.26.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] fix memif does not free resources
2020-04-04 10:15 [dpdk-dev] [PATCH v1] fix memif does not free resources Vadim Podovinnikov
@ 2020-04-04 10:15 ` Vadim Podovinnikov
2020-04-04 21:48 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: Vadim Podovinnikov @ 2020-04-04 10:15 UTC (permalink / raw)
To: dev; +Cc: Vadim Podovinnikov
Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
---
drivers/net/memif/rte_eth_memif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index 81d71c53a..653ffa9b8 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1510,7 +1510,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
}
- eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
+ eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
rte_eth_dev_probing_finish(eth_dev);
--
2.26.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] fix memif does not free resources
2020-04-04 10:15 ` [dpdk-dev] [PATCH] " Vadim Podovinnikov
@ 2020-04-04 21:48 ` Stephen Hemminger
2020-04-07 10:14 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2020-04-04 21:48 UTC (permalink / raw)
To: Vadim Podovinnikov; +Cc: dev
On Sat, 4 Apr 2020 13:15:57 +0300
Vadim Podovinnikov <podovinnikov@protei.ru> wrote:
> Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
> ---
> drivers/net/memif/rte_eth_memif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
> index 81d71c53a..653ffa9b8 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1510,7 +1510,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
> }
>
>
> - eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
> + eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>
> rte_eth_dev_probing_finish(eth_dev);
>
This looks like a bug fix, please add.
Fixes: c41a04958b09 ("net/memif: support multi-process")
Cc: jgrajcia@cisco.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] fix memif does not free resources
2020-04-04 21:48 ` Stephen Hemminger
@ 2020-04-07 10:14 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-04-07 10:14 UTC (permalink / raw)
To: Stephen Hemminger, Vadim Podovinnikov; +Cc: dev
On 4/4/2020 10:48 PM, Stephen Hemminger wrote:
> On Sat, 4 Apr 2020 13:15:57 +0300
> Vadim Podovinnikov <podovinnikov@protei.ru> wrote:
>
>> Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
>> ---
>> drivers/net/memif/rte_eth_memif.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
>> index 81d71c53a..653ffa9b8 100644
>> --- a/drivers/net/memif/rte_eth_memif.c
>> +++ b/drivers/net/memif/rte_eth_memif.c
>> @@ -1510,7 +1510,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
>> }
>>
>>
>> - eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
>> + eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>>
>> rte_eth_dev_probing_finish(eth_dev);
>>
>
> This looks like a bug fix, please add.
>
> Fixes: c41a04958b09 ("net/memif: support multi-process")
> Cc: jgrajcia@cisco.com
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-07 10:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-04 10:15 [dpdk-dev] [PATCH v1] fix memif does not free resources Vadim Podovinnikov
2020-04-04 10:15 ` [dpdk-dev] [PATCH] " Vadim Podovinnikov
2020-04-04 21:48 ` Stephen Hemminger
2020-04-07 10:14 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).