From: Stephen Hemminger <stephen@networkplumber.org>
To: Vadim Podovinnikov <podovinnikov@protei.ru>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fix memif does not free resources
Date: Sat, 4 Apr 2020 14:48:02 -0700 [thread overview]
Message-ID: <20200404144802.48c98083@hermes.lan> (raw)
In-Reply-To: <20200404101557.27567-2-podovinnikov@protei.ru>
On Sat, 4 Apr 2020 13:15:57 +0300
Vadim Podovinnikov <podovinnikov@protei.ru> wrote:
> Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
> ---
> drivers/net/memif/rte_eth_memif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
> index 81d71c53a..653ffa9b8 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1510,7 +1510,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
> }
>
>
> - eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
> + eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>
> rte_eth_dev_probing_finish(eth_dev);
>
This looks like a bug fix, please add.
Fixes: c41a04958b09 ("net/memif: support multi-process")
Cc: jgrajcia@cisco.com
next prev parent reply other threads:[~2020-04-04 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 10:15 [dpdk-dev] [PATCH v1] " Vadim Podovinnikov
2020-04-04 10:15 ` [dpdk-dev] [PATCH] " Vadim Podovinnikov
2020-04-04 21:48 ` Stephen Hemminger [this message]
2020-04-07 10:14 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200404144802.48c98083@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=podovinnikov@protei.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).