From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AEFBA0577; Mon, 6 Apr 2020 11:15:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D59822BE9; Mon, 6 Apr 2020 11:15:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 25D652B96 for ; Mon, 6 Apr 2020 11:15:05 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03695kjh011420; Mon, 6 Apr 2020 02:15:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=GIqSF8oVO6JVXvbxbW5NoVmsJk9qeNUm7sbvnuBWERI=; b=pldTcf77FTRPtoUBfu+WcHnnd92gc7/SJkV9lev4oD6Q15Pj+0jYGUDRa6EM2mHylOlF FaIRynUq3lfB+WnDheDGl96MKM3DvXET2brSdeKBNTtxwnuzUyN9PGEphM1j5T1D85K4 Fa7ggOyL72nrWNrvcDo/3HmGfG4xIgyDAU+WYOuWmPRscmZAEE2vIF3vV1QRjlPtlmHN +NqGaJUWiCBkRtcRdl+z8jhhOPrZ+rW/N96xe1TuBpFCQ6t0IGAyEVLIqqv+HA5CN/hU XsId5wWB7jVVXy5+8AoK42EsmRsgTpUOqcHT0s/9WP2XxR2tzWsUyfAGj2jPVwZDDB3I ww== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 306srm4yd6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 06 Apr 2020 02:15:04 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Apr 2020 02:15:02 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Apr 2020 02:15:01 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 6 Apr 2020 02:15:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aJH+VU7YrS/mHl2FFOuJBD8W5oJBJs2tmXwX/s7LjxFlyYd16mpkqxspzN+SxMuhpiYebKuibg2H/Edh4WRsNk6xjCTis4UX2MFHamBch0K/RJoxPZui9g1B6YkAihF5y6MnrCnmfN1hh4/fnUBdZKoKAVX/9GKKw4MDFi/jtrGgf+Ppt++5jIUrbfCQugF113MXJQAuA3tqHpbC5R1RwUQUgwFwzpRiEo1Q3Uvy0dMVHtodDh7zky1RjVqk64Nl0YgG9GCPQmr4BsDWq272iM8WaAcePHDdf0XOJeMSezeZL4/Dml6q1UF98hnOsnHahb10WJF+vZgKFIgzO7SpfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIqSF8oVO6JVXvbxbW5NoVmsJk9qeNUm7sbvnuBWERI=; b=UJIrH8K+OTXNB5hXPsOWGTrwBn2u3OapnVehLaLhZlvM+HIwnwmnhYjRY4yk/P7rQR11dlngtwbcREGPwZH0uBP5cce2b8dGKYzb4B1cs5z7CHeOUMUk2uQAE1Vcw3dqDRQC9SNqciT4mo7KKzpSLWe/LLdPPrgpKnabcf5ZAJbhne93odt2LA+EtvMTtfcbuf2F9gwBAjC6BLkxAIwTKlpRSaTazbj0/Dk2tYwlgrjGy06og0CM9ctagp93PwnMKFZSqVx18daNqTLHW6JRxV/2FP25v2GmKN47xZ6DId/7nzrrFKdWYvEUDpOR6LwaW32mFMwxjJyUGaC/usre3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIqSF8oVO6JVXvbxbW5NoVmsJk9qeNUm7sbvnuBWERI=; b=mfSGQbWPd30aMbz9F6O5n3dyP+X4CRaEg47uLr2NpiuUyKu+iW7he80CXgRTArTjuoQ68/QLCz/8IW0lcSAZDvwFKo/Qs+anFu/V29VDvEzEwoSKk8CISCJVGZLCDxYTaj1CrqwsNURgi7JJuajQ35zd3zHgmQGdAHtvLXYh6Fs= Received: from MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) by MWHPR1801MB1983.namprd18.prod.outlook.com (2603:10b6:301:69::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Mon, 6 Apr 2020 09:14:58 +0000 Received: from MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::380f:5ca1:ce60:6586]) by MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::380f:5ca1:ce60:6586%7]) with mapi id 15.20.2856.019; Mon, 6 Apr 2020 09:14:58 +0000 Date: Mon, 6 Apr 2020 14:44:41 +0530 From: Nithin Dabilpuram To: Jerin Jacob CC: Nithin Dabilpuram , Jerin Jacob , Kiran Kumar K , John McNamara , Marko Kovacevic , dpdk-dev , Krzysztof Kanas Message-ID: <20200406091441.GA20599@outlook.office365.com> References: <20200312111907.31555-1-ndabilpuram@marvell.com> <20200403085216.32684-1-nithind1988@gmail.com> <20200403085216.32684-12-nithind1988@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: PN1PR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::28) To MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by PN1PR01CA0112.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Mon, 6 Apr 2020 09:14:55 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f90ddc86-0318-45b5-dc52-08d7da0afa5e X-MS-TrafficTypeDiagnostic: MWHPR1801MB1983: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0365C0E14B X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1801MB2063.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(39860400002)(346002)(366004)(136003)(396003)(16526019)(107886003)(956004)(8936002)(52116002)(6916009)(53546011)(86362001)(2906002)(55236004)(6506007)(7696005)(9686003)(55016002)(316002)(8676002)(5660300002)(26005)(186003)(54906003)(4326008)(66476007)(66556008)(66946007)(478600001)(6666004)(1076003)(33656002)(81156014)(81166006); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GsAiywRGgs1rDH4DOrZBROWVGPxS7iWWhQ4SO8FgQ3uy3nNtjSNO05M5IV85Ebz5edDjt3VycnCkARJ6nDE1Oua+waB29fhGh1GfDGhPD91DCOBdu6rRnj+YszFG5wviuyEvNv4+Jw5W/JaJYkVseLPg7x4AxwPh1v/RT+MEFtODqiSJ7cl2JQaKmRicHs5mPRRaDLaXS1KAXm3EmMni1tnlVdZ+kCIZ73c0tJETHhlVRTgGeAMjBfwYFcksKpAQiAbfvbusMu96ErRVWdpqosfYkGvfrUiwRlI4a/kja0LhzDIAE9kaKtOM2ijSGw8wtLg/MzWe8ZbyWjIGuxN8FU8J+K6M82ZuXsh6iZOObwxd+tzxR8J8axZCofId1YLGIXSQDdDer2fKo2QLIzFXsUZsQbNXl0CHDvn0Vm+EavEd8owxr4oFRKIycACClr5o X-MS-Exchange-AntiSpam-MessageData: R1febSwshxMG8owjFDZX4r/namEVD7RzOJZ1tuBUa0YyIjjLqWA4IEUD5e9B0kS6g9GjDS1LsOv9cox5Lc2PeI/HbFYCeaRPBQ+y0JDZ4XLHvqA/7BNFVis0okGukVyudxeSJXY0hNBCEigjJKrlFQ== X-MS-Exchange-CrossTenant-Network-Message-Id: f90ddc86-0318-45b5-dc52-08d7da0afa5e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2020 09:14:58.3262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n0h6OzgiEYIBntoYlOU06bBESrsD9G6PMQjmnKHCQUw1kHBFTJ1TgIwBGTMy/R+3F/BtZY0VccU6COJ5cI0O5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1983 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-06_05:2020-04-03, 2020-04-06 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 11/11] net/octeontx2: add tm capability callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 06, 2020 at 11:18:36AM +0530, Jerin Jacob wrote: > External Email > > ---------------------------------------------------------------------- > On Fri, Apr 3, 2020 at 2:24 PM Nithin Dabilpuram wrote: > > > > From: Krzysztof Kanas > > > > Add Traffic Management capability callbacks to provide > > global, level and node capabilities. This patch also > > adds documentation on Traffic Management Support. > > > > Signed-off-by: Nithin Dabilpuram > > Signed-off-by: Krzysztof Kanas > > After fixing the below issues(inlined) > Series applied to dpdk-next-net-mrvl/master. Thanks. > > > > --- > > > > diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini > > index 473fe56..fb13517 100644 > > --- a/doc/guides/nics/features/octeontx2.ini > > +++ b/doc/guides/nics/features/octeontx2.ini > > @@ -31,6 +31,7 @@ Inline protocol = Y > > VLAN filter = Y > > Flow control = Y > > Flow API = Y > > +Rate limitation = Y > > Definition this "Rate limitation" and TM rate limitation functionally > the same. But the interface is different. > Following is the interface for the above "Rate limitation" feature. > So, Above "Y" is not applicable. Actually support to this feature is added via Patch 10/11. My bad, I added the document update in 11/11 which caused the confusion. Another reason is rate limit support depends on TM support in OCTEON TX2. I also missed to update octeontx2_vec.ini and octeontx2_vf.ini file. Can the above change be put back into Patch 10/11 ? Thanks for other corrections. > > Rate limitation > --------------- > > Supports Tx rate limitation for a queue. > > * **[implements] eth_dev_ops**: ``set_queue_rate_limit``. > * **[related] API**: ``rte_eth_set_queue_rate_limit()`` > > > > > > Jumbo frame = Y > > Scattered Rx = Y > > VLAN offload = Y > > diff --git a/doc/guides/nics/octeontx2.rst b/doc/guides/nics/octeontx2.rst > > index 60187ec..6b885d6 100644 > > --- a/doc/guides/nics/octeontx2.rst > > +++ b/doc/guides/nics/octeontx2.rst > > @@ -39,6 +39,7 @@ Features of the OCTEON TX2 Ethdev PMD are: > > - HW offloaded `ethdev Rx queue` to `eventdev event queue` packet injection > > - Support Rx interrupt > > - Inline IPsec processing support > > +- :ref:`Traffic Management API ` > > tmapi ref is pointing to mvpp2 driver index. > > > > > > Prerequisites > > ------------- > > @@ -213,6 +214,20 @@ Runtime Config Options > > parameters to all the PCIe devices if application requires to configure on > > all the ethdev ports. > > > > +Traffic Management API > > +---------------------- > > + > > +OCTEON TX2 PMD supports generic DPDK Traffic Management API which allows to > > +configure the following features: > > + > > +1. Hierarchical scheduling > > +2. Single rate - two color, Two rate - three color shaping > > Use #. to auto enumerate. > > > + > > +Both DWRR and Static Priority(SP) hierarchial scheduling is supported. > > +Every parent can have atmost 10 SP Children and unlimited DWRR children. > > +Both PF & VF supports traffic management API with PF supporting 6 levels > > +and VF supporting 5 levels of topology. > > + > > Limitations > > ----------- > > > > diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst > > index 000bbf5..47a9825 100644 > > --- a/doc/guides/rel_notes/release_20_05.rst > > +++ b/doc/guides/rel_notes/release_20_05.rst > > @@ -62,6 +62,14 @@ New Features > > > > * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit. > > > > +* **Updated Marvell OCTEON TX2 ethdev driver.** > > + > > + Updated Marvell OCTEON TX2 ethdev driver with traffic manager support with > > + below features. > > + > > + * Hierarchial Scheduling with DWRR and SP. > > + * Single rate - two color, Two rate - three color shaping. > > Alignment is not correct wrt to other items.