From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0A9AA0577; Tue, 7 Apr 2020 16:56:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80A552BE9; Tue, 7 Apr 2020 16:56:33 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 66C942B96 for ; Tue, 7 Apr 2020 16:56:31 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id a24so913474pfc.8 for ; Tue, 07 Apr 2020 07:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DR9Dp4f6g9CTBS8qtIbcciHiRsq/NsQU3zz2OTvaHX0=; b=ijvUSbL3we6ZgCnkrra1cKHi222i9ZYv6PcXOu1vUWIPXCUAS1vfqWspFSGbpXW06w wdX92jIWQoAEbkrvRWFN8PKbGJxgqLOTazneFvdwPanLviEQT64o0QLL5pfU4g+nvlp8 xTf47fKQLs2f6JAHZ+Q3K5K7e9pKujzZgXLjXcXdBPCGrMMu1/4d7jJqtt80sp/Cib8Q AFIeiTFZ2oI7thWMUeUldu7KjYVsXbYsm698ZTsu76xfvTJg+TiigrC23liVPztDp2kN t46xJ/My0a7aJqef2jtimWg4vqIr9keKNLTyLP6g5LPwGADiqLmNE1s+IuTM/e0Nsk+e pEzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DR9Dp4f6g9CTBS8qtIbcciHiRsq/NsQU3zz2OTvaHX0=; b=iy+OTaYa7UfVv5RNy7G/7Ibt4E/s8j5enM6UykXBM+mJt1Be/bNcVzQW/Yx53ywjgH xfrpPJHlcN26h4qc4Qf7uhiMHcN//TUoFSfr8ceaL9JdUOu54uec0ylbPejzobO2bfEc G2AFF9/RG7eikAQ9n9jH5t+c/NYu4O9qNfckbkS5/cdsion1BVk2Z0ChaL5BgtnBrFzt 0lHfhjKYd8qQSeHXP9hrdni1uW0LlS4DZ4cTMMCobSsVfCgetxK2RqsDO2TfsDdlaBlx 4XnKWEjVQBVck+uHC3vhfCba66iuq+LY+d3ZTzXhDXBzX9v9hdWC1fPN5zFVbmt9YRQt hHPw== X-Gm-Message-State: AGi0PuaF/rcD18cEFSrWGiaUsT/UOVBTxYECy88XzH64NUGiKEZgW8Gd ekuX4ooCvQK0se+20WCm73EzqQ== X-Google-Smtp-Source: APiQypLpWsfZfk3maeC6ZTqeSp2oRAb3KvEdL39PB60h1NypLPVrz6XYjiJAW1su4XGrywlE3VQsFQ== X-Received: by 2002:a63:c708:: with SMTP id n8mr2575381pgg.106.1586271390273; Tue, 07 Apr 2020 07:56:30 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 8sm14219208pfv.65.2020.04.07.07.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2020 07:56:30 -0700 (PDT) Date: Tue, 7 Apr 2020 07:56:00 -0700 From: Stephen Hemminger To: wangyunjian Cc: , , , , Message-ID: <20200407075600.0d83b7a1@hermes.lan> In-Reply-To: <1586233406-10268-1-git-send-email-wangyunjian@huawei.com> References: <1586233406-10268-1-git-send-email-wangyunjian@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 7 Apr 2020 12:23:26 +0800 wangyunjian wrote: > The internals is freed and setted NULL in the rte_eth_dev_release_port() The word "setted" is awkward in this phrase. Better wording would be: The internal structure is freed and set to NULL in rte_eth_dev_release_port()