From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4460CA057B; Tue, 7 Apr 2020 13:33:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 138172B96; Tue, 7 Apr 2020 13:33:24 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 5C7532B83 for ; Tue, 7 Apr 2020 13:33:22 +0200 (CEST) Received: from 2606-a000-111b-43ee-0000-0000-0000-1bf2.inf6.spectrum.com ([2606:a000:111b:43ee::1bf2] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1jLmTg-0005XB-If; Tue, 07 Apr 2020 07:33:19 -0400 Date: Tue, 7 Apr 2020 07:33:11 -0400 From: Neil Horman To: David Marchand Cc: dev , Thomas Monjalon , Kevin Laatz Message-ID: <20200407113311.GB128325@hmswarspite.think-freely.org> References: <20200406193430.81268-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote: > > > > Since we've moved away from our initial abi_versioning.sh script, in > > abi_versioning.sh does not exist (idem with the patch title). > I suppose you meant validate-abi.sh. > Crud, you're right, I was convoluting terms, sorry. Shall I repost with a corrected changelog? Neil > > favor of check_abi.sh, which uses libabigail, remove the old script from > > check-abi.sh > > > the tree, and update the docs accordingly > > > > [snip] > > > diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst > > index a21f4e7a4..1c4a3f927 100644 > > --- a/doc/guides/contributing/abi_versioning.rst > > +++ b/doc/guides/contributing/abi_versioning.rst > > @@ -482,9 +482,9 @@ Running the ABI Validator > > ------------------------- > > > > The ``devtools`` directory in the DPDK source tree contains a utility program, > > -``validate-abi.sh``, for validating the DPDK ABI based on the Linux `ABI > > -Compliance Checker > > -`_. > > +``check-abi.sh``, for validating the DPDK ABI based on the libabigail abidiff > > +utility: > > +https://sourceware.org/libabigail/manual/abidiff.html > > > > This has a dependency on the ``abi-compliance-checker`` and ``and abi-dumper`` > > utilities which can be installed via a package manager. For example:: > > @@ -492,9 +492,9 @@ utilities which can be installed via a package manager. For example:: > > sudo yum install abi-compliance-checker > > sudo yum install abi-dumper > > > > -The syntax of the ``validate-abi.sh`` utility is:: > > +The syntax of the ``check-abi.sh`` utility is:: > > > > - ./devtools/validate-abi.sh > > + ./devtools/check-abi.sh > > The new script is not a direct replacement. > It won't take git revisions, but build directories where versions of > dpdk have been compiled. > > devtools/test-build.sh and devtools/test-meson-builds.sh illustrate its use. > https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n127 > > > > -- > David Marchand > >