From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C7B8A0588; Wed, 8 Apr 2020 01:06:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DE821BFD7; Wed, 8 Apr 2020 01:06:53 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 1958F1BFC6 for ; Wed, 8 Apr 2020 01:06:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 4B80E5C0112; Tue, 7 Apr 2020 19:06:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 07 Apr 2020 19:06:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=DllzSYNMQJ AOfaSdjr+IoIjrmYSKn1XjienA0KhC7xw=; b=kcgRi1sY6M6A6I6xzcPIQ+jzFV nNjyEBx79ii6Sw1DVALNwE9x+C3zdaCPjWruLeo5rsGiu0OBVgc2UZS0VLw/5O7x V9auokqBj57NS+HGJEOlS+RY1ocdNWCzBY9x2d/aQnKTEo+EAoUIO1Y6EE7YgUR4 mYE+QqkQK8oFtsm0o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=DllzSYNMQJAOfaSdjr+IoIjrmYSKn1XjienA0KhC7xw=; b=jRpDryK4 mxsbsaSfNw7WzA3Ke4dOK2UZO3YXRvFzI8PRzEVKlv1LrdiFHHhFlAiPDG0nQfyK Dy1+caq4VpzZ0bLPa/lLPL9YUiNAEZZ23Mr4JNpOCacmEA09a2f/0BFRoaKAPnY6 qKaZjxNOJSnW53zqapPuNaBZIKgBlUdRJDTCk6QuA/BcTLvA6MbIQ+rsKWdEMbFT OgNQ4BjM3lugBZvjh249zOheciEzsOGEpL+I9z7rQUlEutZQnZ/TFP2gEtRnALXj 0ml7l5BxcHoJDxoKqRMrvjWN22NQ2YYU11Ll6otJvoQyscD1jXJeHewwRciG1Vr4 bIWJ5YI4hCVpSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeigddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertd ertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshes mhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A98D9306D621 for ; Tue, 7 Apr 2020 19:06:50 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Date: Wed, 8 Apr 2020 01:06:44 +0200 Message-Id: <20200407230647.59478-1-thomas@monjalon.net> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200210103216.1168439-1-thomas@monjalon.net> References: <20200210103216.1168439-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/3] mlx: fix build with -fno-common (gcc 10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In GCC 10, -fno-common will be the default. There are 2 ways of solving issues: - add -fcommon - stop allocating variables in .h files In this patchset, the variables are declared extern, because it is cleaner anyway. v2: do not initialize global variables and Cc stable Thomas Monjalon (3): common/mlx5: split glue initialization common/mlx5: fix build with -fno-common net/mlx4: fix build with -fno-common drivers/common/mlx5/mlx5_common.c | 78 +++++++++++++++++++------------ drivers/common/mlx5/mlx5_glue.h | 2 +- drivers/net/mlx4/mlx4.c | 4 ++ drivers/net/mlx4/mlx4_glue.h | 2 +- drivers/net/mlx4/mlx4_rxtx.h | 2 +- 5 files changed, 55 insertions(+), 33 deletions(-) -- 2.26.0