* Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group
[not found] <114e2ae0-3eb7-45c0-8ec8-d60507a9c862@orsmsx101.amr.corp.intel.com>
@ 2020-04-08 12:28 ` Bruce Richardson
2020-04-08 13:07 ` Alex Kiselev
0 siblings, 1 reply; 7+ messages in thread
From: Bruce Richardson @ 2020-04-08 12:28 UTC (permalink / raw)
To: Alex Kiselev; +Cc: dev
On Tue, Apr 07, 2020 at 02:52:57PM +0300, Alex Kiselev wrote:
> rte_lpm6: fix incorrect size of tbl8 group
>
Missing Cc: stable@dpdk.org and fixes line, which I believe should be:
Fixes: e480688dce6d ("lpm6: add incremental update on delete")
> Signed-off-by: Alex Kiselev <alex@therouter.net>
> ---
> lib/librte_lpm/rte_lpm6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
> index 1047efa8a..f5979fb15 100644
> --- a/lib/librte_lpm/rte_lpm6.c
> +++ b/lib/librte_lpm/rte_lpm6.c
> @@ -726,7 +726,8 @@ add_step(struct rte_lpm6 *lpm, struct rte_lpm6_tbl_entry *tbl,
> tbl8_group_start = tbl8_gindex *
> RTE_LPM6_TBL8_GROUP_NUM_ENTRIES;
> memset(&lpm->tbl8[tbl8_group_start], 0,
> - RTE_LPM6_TBL8_GROUP_NUM_ENTRIES);
> + RTE_LPM6_TBL8_GROUP_NUM_ENTRIES *
> + sizeof(struct rte_lpm6_tbl_entry));
>
> /* init the new table's header:
> * save the reference to the owner table
With fixes line and Cc of stable:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group
2020-04-08 12:28 ` [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group Bruce Richardson
@ 2020-04-08 13:07 ` Alex Kiselev
2020-04-08 13:11 ` Bruce Richardson
2020-04-08 13:38 ` Kevin Traynor
0 siblings, 2 replies; 7+ messages in thread
From: Alex Kiselev @ 2020-04-08 13:07 UTC (permalink / raw)
To: dev, Bruce Richardson; +Cc: stable
rte_lpm6: fix incorrect size of tbl8 group
Fixes: e480688dce6d ("lpm6: add incremental update on delete")
Signed-off-by: Alex Kiselev <alex@therouter.net>
---
lib/librte_lpm/rte_lpm6.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
index 1047efa8a..f5979fb15 100644
--- a/lib/librte_lpm/rte_lpm6.c
+++ b/lib/librte_lpm/rte_lpm6.c
@@ -726,7 +726,8 @@ add_step(struct rte_lpm6 *lpm, struct
rte_lpm6_tbl_entry *tbl,
tbl8_group_start = tbl8_gindex *
RTE_LPM6_TBL8_GROUP_NUM_ENTRIES;
memset(&lpm->tbl8[tbl8_group_start], 0,
- RTE_LPM6_TBL8_GROUP_NUM_ENTRIES);
+ RTE_LPM6_TBL8_GROUP_NUM_ENTRIES *
+ sizeof(struct rte_lpm6_tbl_entry));
/* init the new table's header:
* save the reference to the owner table
--
2.16.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group
2020-04-08 13:07 ` Alex Kiselev
@ 2020-04-08 13:11 ` Bruce Richardson
2020-04-24 17:09 ` Thomas Monjalon
2020-04-08 13:38 ` Kevin Traynor
1 sibling, 1 reply; 7+ messages in thread
From: Bruce Richardson @ 2020-04-08 13:11 UTC (permalink / raw)
To: Alex Kiselev; +Cc: dev, stable
On Wed, Apr 08, 2020 at 03:07:30PM +0200, Alex Kiselev wrote:
> rte_lpm6: fix incorrect size of tbl8 group
> Fixes: e480688dce6d ("lpm6: add incremental update on delete")
>
> Signed-off-by: Alex Kiselev <alex@therouter.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group
2020-04-08 13:11 ` Bruce Richardson
@ 2020-04-24 17:09 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-04-24 17:09 UTC (permalink / raw)
To: Alex Kiselev; +Cc: dev, stable, Bruce Richardson
08/04/2020 15:11, Bruce Richardson:
> On Wed, Apr 08, 2020 at 03:07:30PM +0200, Alex Kiselev wrote:
> > rte_lpm6: fix incorrect size of tbl8 group
> > Fixes: e480688dce6d ("lpm6: add incremental update on delete")
> >
> > Signed-off-by: Alex Kiselev <alex@therouter.net>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group
2020-04-08 13:07 ` Alex Kiselev
2020-04-08 13:11 ` Bruce Richardson
@ 2020-04-08 13:38 ` Kevin Traynor
1 sibling, 0 replies; 7+ messages in thread
From: Kevin Traynor @ 2020-04-08 13:38 UTC (permalink / raw)
To: Alex Kiselev, dev, Bruce Richardson; +Cc: stable
On 08/04/2020 14:07, Alex Kiselev wrote:
> rte_lpm6: fix incorrect size of tbl8 group
> Fixes: e480688dce6d ("lpm6: add incremental update on delete")
Cc: stable@dpdk.org
Thanks for Cc'ing stable. It is better to add the tag directly in the
commit message as we automate checking for the tag in dpdk master commit
messages to indicate it is requested for backport. Probably maintainer
can add on commit..
>
> Signed-off-by: Alex Kiselev <alex@therouter.net>
> ---
> lib/librte_lpm/rte_lpm6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
> index 1047efa8a..f5979fb15 100644
> --- a/lib/librte_lpm/rte_lpm6.c
> +++ b/lib/librte_lpm/rte_lpm6.c
> @@ -726,7 +726,8 @@ add_step(struct rte_lpm6 *lpm, struct
> rte_lpm6_tbl_entry *tbl,
> tbl8_group_start = tbl8_gindex *
> RTE_LPM6_TBL8_GROUP_NUM_ENTRIES;
> memset(&lpm->tbl8[tbl8_group_start], 0,
> - RTE_LPM6_TBL8_GROUP_NUM_ENTRIES);
> + RTE_LPM6_TBL8_GROUP_NUM_ENTRIES *
> + sizeof(struct rte_lpm6_tbl_entry));
>
> /* init the new table's header:
> * save the reference to the owner table
> --
> 2.16.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20200407131551.549E32BE9@dpdk.org>]
* Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group
[not found] <20200407131551.549E32BE9@dpdk.org>
@ 2020-04-16 13:09 ` Andrzej Ostruszka [C]
0 siblings, 0 replies; 7+ messages in thread
From: Andrzej Ostruszka [C] @ 2020-04-16 13:09 UTC (permalink / raw)
To: dev
On 4/7/20 1:52 PM, Alex Kiselev wrote:
> rte_lpm6: fix incorrect size of tbl8 group
>
> Signed-off-by: Alex Kiselev <alex@therouter.net>
> ---
> lib/librte_lpm/rte_lpm6.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
> index 1047efa8a..f5979fb15 100644
> --- a/lib/librte_lpm/rte_lpm6.c
> +++ b/lib/librte_lpm/rte_lpm6.c
> @@ -726,7 +726,8 @@ add_step(struct rte_lpm6 *lpm, struct rte_lpm6_tbl_entry *tbl,
> tbl8_group_start = tbl8_gindex *
> RTE_LPM6_TBL8_GROUP_NUM_ENTRIES;
> memset(&lpm->tbl8[tbl8_group_start], 0,
> - RTE_LPM6_TBL8_GROUP_NUM_ENTRIES);
> + RTE_LPM6_TBL8_GROUP_NUM_ENTRIES *
> + sizeof(struct rte_lpm6_tbl_entry));
Acked-by: Andrzej Ostruszka <aostruszka@marvell.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group
@ 2020-04-07 11:52 Alex Kiselev
0 siblings, 0 replies; 7+ messages in thread
From: Alex Kiselev @ 2020-04-07 11:52 UTC (permalink / raw)
To: dev, Bruce Richardson
rte_lpm6: fix incorrect size of tbl8 group
Signed-off-by: Alex Kiselev <alex@therouter.net>
---
lib/librte_lpm/rte_lpm6.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
index 1047efa8a..f5979fb15 100644
--- a/lib/librte_lpm/rte_lpm6.c
+++ b/lib/librte_lpm/rte_lpm6.c
@@ -726,7 +726,8 @@ add_step(struct rte_lpm6 *lpm, struct rte_lpm6_tbl_entry *tbl,
tbl8_group_start = tbl8_gindex *
RTE_LPM6_TBL8_GROUP_NUM_ENTRIES;
memset(&lpm->tbl8[tbl8_group_start], 0,
- RTE_LPM6_TBL8_GROUP_NUM_ENTRIES);
+ RTE_LPM6_TBL8_GROUP_NUM_ENTRIES *
+ sizeof(struct rte_lpm6_tbl_entry));
/* init the new table's header:
* save the reference to the owner table
--
2.16.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-04-24 17:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <114e2ae0-3eb7-45c0-8ec8-d60507a9c862@orsmsx101.amr.corp.intel.com>
2020-04-08 12:28 ` [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group Bruce Richardson
2020-04-08 13:07 ` Alex Kiselev
2020-04-08 13:11 ` Bruce Richardson
2020-04-24 17:09 ` Thomas Monjalon
2020-04-08 13:38 ` Kevin Traynor
[not found] <20200407131551.549E32BE9@dpdk.org>
2020-04-16 13:09 ` Andrzej Ostruszka [C]
2020-04-07 11:52 Alex Kiselev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).