From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17B6EA0597; Thu, 9 Apr 2020 13:16:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D8141C1FB; Thu, 9 Apr 2020 13:16:33 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 117121C1F7 for ; Thu, 9 Apr 2020 13:16:30 +0200 (CEST) IronPort-SDR: 18hhlztfuw1wpfWWCaec0G+T/Pvn0fxiV4tBZ+iqIAHGgvludzBDdrVvFQSXNq65w9NnmuokKP LTT/ujcmNwZg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 04:16:30 -0700 IronPort-SDR: 0eHM/Y2A2atSSMjUIBOZ0owbQLbnMctdjgtJwarHWnCBUX5sfJo1bLxZDC0FRDm/2Z822U0Bi4 PF5hrGabteXg== X-IronPort-AV: E=Sophos;i="5.72,362,1580803200"; d="scan'208";a="425476466" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.62.202]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Apr 2020 04:16:28 -0700 Date: Thu, 9 Apr 2020 12:16:25 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20200409111625.GD613@bricha3-MOBL.ger.corp.intel.com> References: <20200409105746.26955-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] build: add note about make system deprecation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 09, 2020 at 12:09:57PM +0100, Ferruh Yigit wrote: > On 4/9/2020 11:57 AM, Bruce Richardson wrote: > > When anyone uses the make build system, they are to be informed > > about upcoming plans to deprecate and subsequently remove that > > system and to use meson and ninja instead. > > > > Signed-off-by: Bruce Richardson > > --- > > mk/rte.sdkbuild.mk | 4 ++++ > > mk/rte.sdkconfig.mk | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk > > index b512de1ec..67d07a7ed 100644 > > --- a/mk/rte.sdkbuild.mk > > +++ b/mk/rte.sdkbuild.mk > > @@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-)) > > .PHONY: build > > build: $(ROOTDIRS-y) > > @echo "Build complete [$(RTE_TARGET)]" > > + @echo "==== NOTE ====" > > + @echo "It is recommended to build DPDK using 'meson' and 'ninja'" > > + @echo "Building DPDK with 'make' will be deprecated in a future release" > > + @echo "==============" > > > > .PHONY: clean > > clean: $(CLEANDIRS) > > diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk > > index f538649f2..9a7ffbe9a 100644 > > --- a/mk/rte.sdkconfig.mk > > +++ b/mk/rte.sdkconfig.mk > > @@ -62,6 +62,10 @@ else > > config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile > > @echo "Configuration done using" \ > > $(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE))) > > + @echo "==== NOTE ====" > > + @echo "It is recommended to build DPDK using 'meson' and 'ninja'" > > + @echo "Building DPDK with 'make' will be deprecated in a future release" > > + @echo "==============" > > What do you think providing a link to meson documentation too? > Not a bad idea - though it may need to wait until the instructions on the website itself get updated. Currently the best link is probably, http://doc.dpdk.org/guides/linux_gsg/build_dpdk.html#compiling-and-installing-dpdk-system-wide but it's rather long and unwieldy. /Bruce