From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50F05A0597; Thu, 9 Apr 2020 19:25:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D61F1C29F; Thu, 9 Apr 2020 19:25:32 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A61A51BF1B for ; Thu, 9 Apr 2020 19:25:30 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200409172529euoutp016efa7d5d0cb842eacf1a4d87ab00e14c~ENrdAB4fY0866708667euoutp01_ for ; Thu, 9 Apr 2020 17:25:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200409172529euoutp016efa7d5d0cb842eacf1a4d87ab00e14c~ENrdAB4fY0866708667euoutp01_ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1586453129; bh=MZSAWXzpy+Gp126h89ziHpW19shRrRGJJ6MiONifsOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Szobe9YOnQpVk/NBCKe4eVa6OJSZbiOZwwRVhPbZWi863wx8onh1O3OV3abFOLgl1 TDQW/bAxa2Q7J76eeH4XNifWsROXYCh/d2oGnWLeyMgyDaOS+i0wmn95ZoUmcaQQIp YoJhSdwdc7Y5j8tS27Ow+EUvPazvvYhL3+3rOqTM= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200409172529eucas1p1f2daa7b72b95b5f3fc6d4eb26d1af2f7~ENrc4FBzq0986409864eucas1p1r for ; Thu, 9 Apr 2020 17:25:29 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 71.50.60679.98A5F8E5; Thu, 9 Apr 2020 18:25:29 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200409172528eucas1p1186911653001cab0e69f10fc42790023~ENrcmLQZ00987109871eucas1p1m for ; Thu, 9 Apr 2020 17:25:28 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200409172528eusmtrp123a433439798f580abdafc1c369c7285~ENrclrXOx2215922159eusmtrp1i for ; Thu, 9 Apr 2020 17:25:28 +0000 (GMT) X-AuditID: cbfec7f4-0e5ff7000001ed07-cf-5e8f5a89eea6 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 0C.B9.08375.88A5F8E5; Thu, 9 Apr 2020 18:25:28 +0100 (BST) Received: from localhost.localdomain (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200409172528eusmtip1ad9c8e2115e50a91573f00ee341c9a61~ENrcRxGIl0696806968eusmtip1S for ; Thu, 9 Apr 2020 17:25:28 +0000 (GMT) From: Lukasz Wojciechowski To: Cc: dev@dpdk.org Date: Thu, 9 Apr 2020 19:24:49 +0200 Message-Id: <20200409172502.1693-1-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200408031351.4288-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsWy7djP87qdUf1xBqv28lq8+7SdyYHR49eC pawBjFFcNimpOZllqUX6dglcGfevuxbMEKw4/+4nSwPjRd4uRk4OCQETiZ0z3jOC2EICKxgl Zr/N7GLkArLbmSRmnF3GCOG0MUn8/7KQFabj275brBCJ5YwSDY/WMsFVHdzSCzaLTcBW4sjM r2AdIgIsEiu/f2cBsZkFBCQe33sGFhcWcJL48ekPE4jNIqAqcWTPM7AaXgEXiZ4Nj6C2yUus 3nCAuYuRg4NTwFVi91kukF0SAivYJK4tX8kIUeMicXfOL6h6YYlXx7ewQ9gyEqcn97BANGxj lLj6+ycjhLOfUeJ67wqoKmuJw/9+s4FsYBbQlFi/Sx8i7CixYfJPJpCwhACfxI23ghD380lM 2jadGSLMK9HRJgRRrSfxtGcqI8zaP2ufsEDYHhJLmr5Aw2cGo8TtYz/YJjDKz0JYtoCRcRWj eGppcW56arFRXmq5XnFibnFpXrpecn7uJkZgBJ/+d/zLDsZdf5IOMQpwMCrx8Bow9McJsSaW FVfmHmKU4GBWEuH1buqNE+JNSaysSi3Kjy8qzUktPsQozcGiJM5rvOhlrJBAemJJanZqakFq EUyWiYNTqoGRibWlJ/V6tPmRrBemG6c7zNn960Jr/dU2HoXvOtPn+D6vU90np+7of99/2sYH e9edUO7JZmB7uj3m/x9P3bQikQM33+w9Z2Lf5nxuXfSq4v2pv4weip5cX9n7L0Dock6XRfdJ MXX/RYd/Kc16pvqilz8yR9Zu9a6ylTbrmple7rR+wNbCkVCqxFKckWioxVxUnAgARzHoGdwC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJLMWRmVeSWpSXmKPExsVy+t/xu7odUf1xBkemWVi8+7SdyYHR49eC pawBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6 GfevuxbMEKw4/+4nSwPjRd4uRk4OCQETiW/7brF2MXJxCAksZZSYM+EnexcjB1BCRuLDJQGI GmGJP9e62CBqWpgkXs/4xgqSYBOwlTgy8yuYLSLAIrHy+3cWEJtZQEDi8b1nYHFhASeJH5/+ MIHYLAKqEkf2PAOr4RVwkejZ8IgVYoG8xOoNB5hB9nIKuErsPssFEhYCKln67S/zBEa+BYwM qxhFUkuLc9Nziw31ihNzi0vz0vWS83M3MQKDaduxn5t3MF7aGHyIUYCDUYmH14ChP06INbGs uDL3EKMEB7OSCK93U2+cEG9KYmVValF+fFFpTmrxIUZToJsmMkuJJucDAz2vJN7Q1NDcwtLQ 3Njc2MxCSZy3Q+BgjJBAemJJanZqakFqEUwfEwenVANjZNdhj9LlD2QzlSKWlMjKvpxSP9fo ucOkaXOXRlfo1y1SijTYNHPl1jxphi8dMTENFjzK4r9MmTdNMG1axMDzadsOrS3HlJ+pX83d 0/I6qtDwZcf+jQejfX9NkHjOWBJ7NnDWTWf5LXHbLFyuPFksWV7hvzVyzgT3CVnt8jv3398U ZqfgfeGsEktxRqKhFnNRcSIA1WAmrjwCAAA= X-CMS-MailID: 20200409172528eucas1p1186911653001cab0e69f10fc42790023 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200409172528eucas1p1186911653001cab0e69f10fc42790023 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200409172528eucas1p1186911653001cab0e69f10fc42790023 References: <20200408031351.4288-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Set of patches fix minor issues like proper verification of input parameters and aligning documentation with code in the matter of return values. Another fixed issue is invalid decrementation of the session counter which might cause inconsistency between counter values and a true number of sessions. All of these issues (and all the librte_security) code is covered with unit tests. The tests are added to dpdk-test application and can be launched with "security_autotest" command. --- v3: * Use generic RTE_DEBUG flag instead CONFIG_RTE_LIBRTE_SECURITY_DEBUG * Remove RTE_TEST_TRACE_FAILURE macro definition in app/test/test.h v2: * Fix patches' topics for librte_security to security * Introduce CONFIG_RTE_LIBRTE_SECURITY_DEBUG flag and: ** make it disabled by default ** verify parameters in dataplane API calls only when option is enabled ** skip tests of code disabled by the option * Add Fixes tags * Introduce RTE_PTR_CHAIN3_OR_ERR_RET macro for doing 3 chain checks * Removed C99 style comments * Remove check of m parameter in rte_security_set_pkt_metadata * Fix code style warnings Lukasz Wojciechowski (13): security: fix verification of parameters security: fix return types in documentation security: fix session counter app/test: remove macro definition app/test: introduce librte security tests app/test: add rte security session update tests app/test: add rte security session get size tests app/test: add rte security session stats get tests app/test: add rte security session destroy tests app/test: add rte security set pkt metadata tests app/test: add rte security get userdata tests app/test: add rte security capabilities get tests app/test: add rte security capability get tests app/test/Makefile | 2 + app/test/meson.build | 3 + app/test/test.h | 2 - app/test/test_security.c | 2435 ++++++++++++++++++++++++++++ lib/librte_security/rte_security.c | 71 +- lib/librte_security/rte_security.h | 8 +- 6 files changed, 2498 insertions(+), 23 deletions(-) create mode 100644 app/test/test_security.c -- 2.17.1