From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE028A0599; Fri, 10 Apr 2020 07:10:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82C661C132; Fri, 10 Apr 2020 07:10:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 840081C115 for ; Fri, 10 Apr 2020 07:10:03 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03A56gWj009621; Thu, 9 Apr 2020 22:10:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0818; bh=NIOraD56GKf4HfbVaZxvDDV3cW1MQtXOzqdayF3U6Vc=; b=PvqmEAPehi11d2q1+zLxCX3a/dv8XnRNCoGPGTVJwTTPCwd6DhJQG24GM6jsZJ+jSgPA mRBMfDazhSaWsL+AOEgrJZv8hq2M7jE5LCnKWnHRd2fjcUK9wwNMZ4Hnqb4uSpGEBmuM Cw4WfvgiXULKdAc62VN6n9LuZDfdJFW2g8QbjBwS4q7oCGLeh0xPc2qRF3oRMENq7SUo vw/ktg9ni3G7sb8iNGvowoeu5HotWqrplOe5Lht5Eof80btPeqlllIzB293MRq3lp8jW wR+LPtRVhc3VIDW2hI39p8XgfpukOnGtvBcHiTjLfM7wFz8oTeddgClAWzpzWKYHuQM8 bQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 3091mebs7w-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 09 Apr 2020 22:10:02 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Apr 2020 22:10:00 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 9 Apr 2020 22:10:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SMPb/Edisa5M/ZYWVCMJ9urcBST1FCGw/qG0EsIKMnTNtdTZN1qjv91oZXpinz6uaBIf5Np1zetSHg01jmtBmegNVl8hRuJnk0Ca5OqxLTQNwppH9jKfI+LeJgPPKrygI4jHL9gVbfCbykEZ9Z8dI5olG9kdW2Okaruwuj/cwr2UtGdUQG0+TmcPTiF/0GFO6GbdEZNM0fAC4lAcAUXNIsNUHXmBBe38m23j74G8efzLlNGXmeDAhPzUaS/ZWbmZBofdi255Hp1yuGu7AEE1uIY35e8A1vKPZA7c7R7Sbrx8bikGcANO3Q0AB/LK5OF3ms06Lm4iOMsiVqnYx/0Gwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NIOraD56GKf4HfbVaZxvDDV3cW1MQtXOzqdayF3U6Vc=; b=jUUCn7ZeZR6rkhKkzVIm2z6cXx9kp/9417ypz/bj0Z7QweRU+/AdJUadvSr7S4oSdwYzSx9fvFvm/6D6uEDZskJM/giKaJywVdPgJil1wo9GFamPfLFHCVUmtLv1ObbDwSGTSnTXQUWh+c12URE4rINBLCCcnKRCIPs0yo1JND7q7lmjWWL64mSMn8NvUfBO36eiNfdkMQL3c7qaqR7vk4JuxWbhmI8RI3NvqiTH11yJx+2T88p2++lMlAZ1MsveA7xa9XYqaQGWwwaYK6cmzpY+oEqMyHXPHBdpvG4HvpPOSyM4IGvKFTf61nyEz93CPN9OTzzbUaV1c0CcPQjqlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NIOraD56GKf4HfbVaZxvDDV3cW1MQtXOzqdayF3U6Vc=; b=IeGnickULVqyZNuubQLEYL/1wJ/hggPABJnvaH6VTFKWwRuAUbZJG2Ct6RAvH2qG04gPU5/mOWor5ne+EYuCDP2CX9ETMecj6ULXeAsO/cdrC8ZPEf0uTnUEhrNnS9YTzZ12cSj/c9KEBQAdV5uv1ogKYXmpHm6JjKVvFWXN/iQ= Received: from MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) by MWHPR1801MB1887.namprd18.prod.outlook.com (2603:10b6:301:65::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.21; Fri, 10 Apr 2020 05:09:59 +0000 Received: from MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::380f:5ca1:ce60:6586]) by MWHPR1801MB2063.namprd18.prod.outlook.com ([fe80::380f:5ca1:ce60:6586%7]) with mapi id 15.20.2856.027; Fri, 10 Apr 2020 05:09:59 +0000 Date: Fri, 10 Apr 2020 10:39:44 +0530 From: Nithin Dabilpuram To: Andrzej Ostruszka CC: Message-ID: <20200410050944.GA17335@outlook.office365.com> References: <20200331192945.2466880-1-jerinj@marvell.com> <20200405085613.1336841-1-jerinj@marvell.com> <20200405085613.1336841-19-jerinj@marvell.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (34cd43c) (2019-09-21) X-ClientProxiedBy: BM1PR0101CA0037.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::23) To MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (115.113.156.2) by BM1PR0101CA0037.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 05:09:57 +0000 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cafbe01-d909-48c7-3e3d-08d7dd0d6a8f X-MS-TrafficTypeDiagnostic: MWHPR1801MB1887: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1801MB2063.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(346002)(366004)(396003)(376002)(39860400002)(66476007)(81156014)(5660300002)(86362001)(55236004)(53546011)(66556008)(8936002)(33656002)(7696005)(8676002)(66946007)(6506007)(6916009)(2906002)(52116002)(26005)(478600001)(16526019)(316002)(956004)(9686003)(1076003)(4326008)(55016002)(186003)(6666004); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AqQXaUAkTB/7ooLVXDx3EMKJ008JdPqQ7you/4ITeyjNIJe5uzY78CZCmDM4PhQnjrIuS6Bl6DqaNA+4Xrht5GUdzG7I5Nf9eDZJ+OZnt/VlCFAdrR7qPuoXPxbth7QGDV5dTlt9iejBbYxgMBVs8MSs8eGOKkk2VVZU5e16qxlrA/sIDgXYd+VJk3it/zBrFBT7vNNKbYJd0AzETQIW88aLM5/y8tdyQLdYaW028hxw5xsRZO4TvxyegOcbdGk7N+cH3wVUXn01jmspcF3l7G/SdfRYg1wJDXi3hGyyr0LS3LEo5k7Uinzyafnk5fB1YxFkm62F6lXVBnJg9XwUuhqaoa6b5jbe0epMO3e04PHmj04Eonwlw8RRQG1AUiaIgijT+moyT1u8VkQYVy4uUQjFCqSAFDOHOXZ9YVKEv3izPWymxIcrOjcWBi28+iPU X-MS-Exchange-AntiSpam-MessageData: SdRqcxVR0DrcmR1IEvkyC9dwd6HL4/IECfvKRwBlQOlv+7REHbl22b+QGaohIyDOmWuKBic4lhS1VxsP9tBqj1xN7/lAYEoByuznjyHQTQC/YW+6T6Dj2kiOcVrmffbs+YcXgUBmhkQMy2Nj+mywHA== X-MS-Exchange-CrossTenant-Network-Message-Id: 1cafbe01-d909-48c7-3e3d-08d7dd0d6a8f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 05:09:59.2278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zyTUwkZXUg4ZpTCmOev8bPpVAPuECZBPvzt/hLvZmEvsVWqCAucphT22D2oeP70oU/BYMR3aXDbf7FpPb9SZ3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1887 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-10_01:2020-04-07, 2020-04-10 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 18/29] node: add ethdev Rx and Tx node ctrl API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 10, 2020 at 01:07:17AM +0200, Andrzej Ostruszka wrote: > On 4/5/20 10:56 AM, jerinj@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add ctrl api to setup ethdev_rx and ethdev_tx node. > > This ctrl api clones 'N' number of ethdev_rx and ethdev_tx > > nodes with specific (port, queue) pairs updated in their context. > > All the ethdev ports and queues are setup before this api > > is called. > > > > Signed-off-by: Nithin Dabilpuram > > Signed-off-by: Pavan Nikhilesh > > Signed-off-by: Kiran Kumar K > > --- > [...] > > +struct rte_node_mbuf_priv1 { > > + union { > > + /* IP4 rewrite */ > > + struct { > > + uint16_t nh; > > + uint16_t ttl; > > + uint32_t cksum; > > + }; > > + > > + uint64_t u; > > + }; > > +}; > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Node mbuf private data to store crypto operation. > > + */ > > +struct rte_node_mbuf_priv2 { > > + union { > > + /* Sym crypto */ > > + struct { > > + struct rte_crypto_op op; > > + }; > > + }; > > +} __rte_cache_aligned; > > Why such definition? For communication b/w nodes, we need some per mbuf private space. We defined it into two halfs for performance reasons as #1 rte_node_mbuf_priv1(8 bytes) mapped to mbuf->udata64 #2 rte_node_mbuf_priv2(RTE_CACHE_LINE_SIZE bytes) mapped to mbuf private area. #1 is smaller area and will not have a cache miss when accessed as mbuf is already in cache. #2 is larger area and probably good enough for many use cases like ipsec, crypto etc, and there will be an extra cost of cache miss to access it. Atleast in OCTEONTX2, we are able to see 27% performance drop, if use single private area #2 for everything instead. Since pkt_mbuf pool are created by application, we these structures are defined here have a check in ctrl api if the pkt_mbuf pool meets the mbuf private area size requirement. > > With regards > Andrzej Ostruszka