From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBD8CA059B; Fri, 10 Apr 2020 11:46:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 397681D517; Fri, 10 Apr 2020 11:46:31 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4B3401D50E for ; Fri, 10 Apr 2020 11:46:30 +0200 (CEST) IronPort-SDR: HkzP3VoaMQuSPm7enb3QpPZEaE7FPK9rm+QPLqDlrg34FHkxL2nDGZkGnc8nEn25jhp5W/XkL2 MpL1w+73V91Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2020 02:46:29 -0700 IronPort-SDR: +BB2JuMju970AUBt3rhMd/WDOH+FeTGorNV6OJ5Kf1gh34ae8M8yODOg9WrQKa0P/FP5e4ZtM7 HT1hsjvkHJ9A== X-IronPort-AV: E=Sophos;i="5.72,366,1580803200"; d="scan'208";a="425841031" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.50.46]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Apr 2020 02:46:28 -0700 Date: Fri, 10 Apr 2020 10:46:24 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: dev@dpdk.org Message-ID: <20200410094624.GB625@bricha3-MOBL.ger.corp.intel.com> References: <1586441688-29190-1-git-send-email-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1586441688-29190-1-git-send-email-juraj.linkes@pantheon.tech> Subject: Re: [dpdk-dev] [PATCH] build: add arm 32bit cross compilation to Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 09, 2020 at 04:14:48PM +0200, Juraj Linkeš wrote: > * Add arm-linux-gnueabihf cross-file > * Add generic and default arm 32 bit flags to arm meson.build > * Add support for disabling drivers using flags defined in Meson > * Change checks from dpdk_conf.has() to dpdk.conf.get() > * When processing which drivers to build, check whether the > appropriate RTE flag isn't set to false > This is probably best done as separate patches that can be reviewed separately. While the first two seem straight-forward, the last item seems strange and should be reviewed separately. Why do you want flags defined in meson to enable/disable drivers? It's taking a big step back towards having a statically defined configuration, which is something we really want to get away from. /Bruce