From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDB26A059F; Fri, 10 Apr 2020 15:25:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 657151C1D9; Fri, 10 Apr 2020 15:25:55 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A8C891C1D8 for ; Fri, 10 Apr 2020 15:25:53 +0200 (CEST) IronPort-SDR: aLo+WHsuQUNf0pAN5eW79qOGj76YsDYAsOMpHfi/Vx8vwcCHOv56HspJ/lKbdmDcYh+mCfVpWv NZrAqu2lBR1A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2020 06:25:52 -0700 IronPort-SDR: xWS0EtSo9x3tfxI/4YC4AABhmstPkV5E0aVL5j5/ee5HkvRO5cc1rUTmguLqx0dasS+A6mkmw4 5+bREmlyOg1A== X-IronPort-AV: E=Sophos;i="5.72,366,1580803200"; d="scan'208";a="425884909" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.50.46]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Apr 2020 06:25:50 -0700 Date: Fri, 10 Apr 2020 14:25:47 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, Lukasz Wojciechowski , Aaron Conole , Ruifeng Wang , David Marchand , Gavin Hu Message-ID: <20200410132547.GB42@bricha3-MOBL.ger.corp.intel.com> References: <20200409180332.592074-1-thomas@monjalon.net> <20200410102951.1398001-1-thomas@monjalon.net> <20200410104219.GE625@bricha3-MOBL.ger.corp.intel.com> <1813726.1xdlsreqCQ@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1813726.1xdlsreqCQ@thomas> Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: > 10/04/2020 12:42, Bruce Richardson: > > On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > > > --- a/app/test/meson.build > > > +++ b/app/test/meson.build > > > has_hugepage = true > > > if is_linux > > > > Since you check for linux in the script, you can drop these two lines, > > The issue is for Windows. > I am not sure how we will skip shell scripts > when adding Windows support for this application. > So there are two options now: > a) remove Linux check before calling the script and ignore Windows support for now > b) keep Linux check without knowing whether it will be useful for Windows support > > We vote a? > c) Write all such scripts in python, to allow them to run everywhere. :-) Given that windows is the problem, having the is_linux check in the meson.build file makes most sense - in which case I don't think we need the check for linux in the script. /Bruce