Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 10 Apr 2020 22:47:44 +0200
Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> wrote:

> W dniu 10.04.2020 o 16:41, Thomas Monjalon pisze:
> > 10/04/2020 15:25, Bruce Richardson:  
> >> On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote:  
> >>> 10/04/2020 12:42, Bruce Richardson:  
> >>>> On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote:  
> >>>>> --- a/app/test/meson.build
> >>>>> +++ b/app/test/meson.build
> >>>>>   has_hugepage = true
> >>>>>   if is_linux  
> >>>> Since you check for linux in the script, you can drop these two lines,  
> >>> The issue is for Windows.
> >>> I am not sure how we will skip shell scripts
> >>> when adding Windows support for this application.
> >>> So there are two options now:
> >>> 	a) remove Linux check before calling the script and ignore Windows support for now
> >>> 	b) keep Linux check without knowing whether it will be useful for Windows support
> >>>
> >>> We vote a?
> >>>  
> >> c) Write all such scripts in python, to allow them to run everywhere. :-)
> >>
> >> Given that windows is the problem, having the is_linux check in the
> >> meson.build file makes most sense - in which case I don't think we need the
> >> check for linux in the script.  
> > Yes, let's make it simple for now.
> >  
> 
> a) is ok as the current meson.build won't work in Windows environment at 
> all.
> c) would be best, but I guess it's a little bit to much for this patch 
> and the whole build system could be adjusted to windows in separate thread.
> 
> And I agree with Bruce, that the check for Linux in script is not needed.
> 
> >  

Building in a container may not give access to /proc.