From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D415A0577; Mon, 13 Apr 2020 03:49:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A37DB2B83; Mon, 13 Apr 2020 03:48:59 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 22D232A66; Mon, 13 Apr 2020 03:48:56 +0200 (CEST) IronPort-SDR: IMOOH7Hf/XGKporfBnhloKSTX1Usg6SJ/Z6s98sa+61vyAsYA7+7wePTum/6FqnjjCgf8ujrPV EO7eKc14GwCQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2020 18:48:56 -0700 IronPort-SDR: 5cFDt6Z8ukXsdIfUxQRfhmUnjVaLERhD4vQqQRHoiqUdrevbW6AvZZNLvCW2T/qP/xkWSHf9Vc sU7qRKekCbSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,375,1580803200"; d="scan'208";a="270935845" Received: from unknown (HELO localhost.localdomain) ([10.239.255.57]) by orsmga002.jf.intel.com with ESMTP; 12 Apr 2020 18:48:53 -0700 From: Shougang Wang To: dev@dpdk.org Cc: Wenzhuo Lu , Qiming Yang , Shougang Wang , stable@dpdk.org Date: Mon, 13 Apr 2020 01:38:39 +0000 Message-Id: <20200413013839.71374-1-shougangx.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It's a normal behavior to change the link status to up after resetting the port. So it is unnecessary to set link down before starting port, and changing the link state(link up/down) frequently will cause link speed unstable. Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") Cc: stable@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 23b3f5b0c..206358b85 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -1196,7 +1196,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) diag = ixgbe_bypass_init_hw(hw); #else diag = ixgbe_init_hw(hw); - hw->mac.autotry_restart = false; #endif /* RTE_LIBRTE_IXGBE_BYPASS */ /* @@ -1307,8 +1306,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) /* enable support intr */ ixgbe_enable_intr(eth_dev); - ixgbe_dev_set_link_down(eth_dev); - /* initialize filter info */ memset(filter_info, 0, sizeof(struct ixgbe_filter_info)); -- 2.17.1