From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E986A0577; Tue, 14 Apr 2020 06:07:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB7B31C06C; Tue, 14 Apr 2020 06:07:09 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id A573C1C06C for ; Tue, 14 Apr 2020 06:07:08 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id d17so5463693pgo.0 for ; Mon, 13 Apr 2020 21:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OAzNLLxBi97RiIURAGbosUP1hj5kq4QS4KnYIayXbHc=; b=gBigjRHQbtZx7Szm9u/25zT0HRr11RM1x/ma2rp0HMtuKGhU/piNjtmq183oefhNSg COsZlNEP0LY9fIincrEEL4fGFhU6OaeV0FXKx7kwF5lv7G7/r5VzYZsI1BxVVrExnERc uvea0VJmV4XsJlz7zN7SWoMXOjZJJFX6TxEXiv/w4Q3S+99bV+QFaRRhtvmpqxzGJWOT 8qcPdKaJMvmNUSCDYGOOdSic66NB1GHYILeGN4PptExl3s8WvfzMio8FHF3jzAMq/633 MR/D20ighO6ia+wxl2xYEsCMMuCZNdk/4ZreTMZdFldEmZfFrsFa1RZQWF4ro+aiB06E mbPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OAzNLLxBi97RiIURAGbosUP1hj5kq4QS4KnYIayXbHc=; b=IfuOejy65894bFKFFxd52m4nM2rkdz2Y4ItHdl056IUONFebck8SMlLJsT1viYiW9n xPcjldQmO64KUf2HMKl9XTDGLnxnpVTt/WSz4cEQoc2+4aaDJ/n55NQOQfmH4aqUkPND Bsec6Qr6a9ifeWyjiMvCXFIPfJz+NH+5/q1Y6rBQgaurb4u6PMNA0KmvwMg5UMJq4XU3 Ucwuf3z2ad+P3iVSuDCflgXsi9shL79JBm0WJUfEHnDIPW/WKAa1KgK1Sd1lTlHh3EXZ awO5KYYytkDMKK6GIF8qNPBCWC5KTV352rb7mlAPtRXan6WVOUPaQJIfuTOUNvIYx21n sqJA== X-Gm-Message-State: AGi0Pub6ShjhHglYDaWq+NmarFOkY0r0sZGsIXshxRwIaecH1n9BYkFW Z/cG/3WR8k2FvZPdvIt/Bi+sSQ== X-Google-Smtp-Source: APiQypIsR6m58K657PHlUb1Oh9E7E3GCGTVX4aVYW2ZTBzQV+k/B7mCwD2VbtfKMumSy4JxCuXoUxA== X-Received: by 2002:aa7:9a4b:: with SMTP id x11mr20925767pfj.73.1586837227597; Mon, 13 Apr 2020 21:07:07 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l30sm8238259pgu.29.2020.04.13.21.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2020 21:07:07 -0700 (PDT) Date: Mon, 13 Apr 2020 21:06:58 -0700 From: Stephen Hemminger To: xiangxia.m.yue@gmail.com Cc: mattias.ronnblom@ericsson.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20200413210658.2308b86e@hermes.lan> In-Reply-To: <1586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 12 Apr 2020 16:27:53 +0800 xiangxia.m.yue@gmail.com wrote: > From: Tonghao Zhang > > When rte_rand_init is invoked, and the kernel > (kernel version < 3.17) running dpdk does't support > *getentropy, at the same time, the cpu does't support > rdseed, the rte_rand_init will invoke rte_get_timer_cycles > which function will invoke rte_get_hpet_cycles > (RTE_LIBEAL_USE_HPET was enabled) while *eal_hpet is not > allocated. > > Fixes: faf8fd252785 ("eal: improve entropy for initial PRNG seed") > Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR") > > Cc: stable@dpdk.org > > Signed-off-by: Tonghao Zhang Are you sure this patch won't change current default to use HPET (which is slower)? Before this patch users would get TSC as default.