From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2799DA0588; Thu, 16 Apr 2020 07:07:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D903F1DA75; Thu, 16 Apr 2020 07:07:23 +0200 (CEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id 953B71DA74 for ; Thu, 16 Apr 2020 07:07:22 +0200 (CEST) Received: by mail-pj1-f68.google.com with SMTP id mn19so871235pjb.0 for ; Wed, 15 Apr 2020 22:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y/ywgqo1Q/3YiJnqUCrlg0MXGhe/PmGVYiVeOG6joOc=; b=QRmjG1Jz4WNrPUdDy+dTL7O+C+agHf4YZieEYuP+LGb9+PagQTw3/0COUxBVMHAU+o XKDAWfLp2OWEQFZ9bDRu6soKEph15uym9Hnf6XZyNIhCvjpfyl8YMrIxSjZuyFpkK8xi xLxXz2g6PXl5PCRYi9bUKY1W2mTkp1g7Ns9skg4cBJbIxkCTy8jfkOqbPwkgpIvyE9lA df8F/CL5rEoXo0i5sWSVDu1r6LEQZkhZJK8cwhKKA3DzCUHkj52aj53GJpWZVSroL7l6 iEWpr6vhBXFT/8+3QZWCKgykgUJ0jvcEQ/X9xdaDpY0FRpAi2GDsLoQR7ao0HexdQywl UPbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y/ywgqo1Q/3YiJnqUCrlg0MXGhe/PmGVYiVeOG6joOc=; b=PfIavB0g1jUk3RLx3RbHfts8W4780u1iVkzY8gFkXhdjlGHxfh/4vrfprB6DUcpXBm UQ6HBMNmP3GyRZdQmV4e+YEf5YwuHo+gKxpUFJGPF67jlKqucmSmOdjQmJVhFiDUQTOK /drFuoi3SQ0PVVx697pJzKetnBB0zc3wMKlqDYStmqLwMieTbDG7DcfMLmCkL+DtIT5g 4AiTyWD5cAMEpukCob1WYe0p1O4RGnDS26uzXxQMfRwg1rhYWIiT62ohJqEPmWYHeOKM W392mhmdea1dLl69oXZeO1t6+q8dViMdYfAoPx25OsQ8+bGTUUOU0zuk2Kd8j3Vu6YJ6 01Vw== X-Gm-Message-State: AGi0Pub9Imm6Kb1Y/QK6wcOT7vf5cY0YSLEFnixhD0wjafMr2GGXq17U o35tfMgJG7J+HaUGPKE7Gn/ybA== X-Google-Smtp-Source: APiQypJC//KN5Msa9vJNUjY1Ate+BQ7xfxBTDYkKte03hA9OSwODU/gLYS17k4wXrZrjj97jRaJjcw== X-Received: by 2002:a17:90a:1202:: with SMTP id f2mr2988138pja.15.1587013641464; Wed, 15 Apr 2020 22:07:21 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c10sm12374109pfc.23.2020.04.15.22.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 22:07:21 -0700 (PDT) Date: Wed, 15 Apr 2020 22:07:12 -0700 From: Stephen Hemminger To: wangyunjian Cc: , , , , Message-ID: <20200415220712.07d4f4fa@hermes.lan> In-Reply-To: <1587006237-21592-1-git-send-email-wangyunjian@huawei.com> References: <1587006237-21592-1-git-send-email-wangyunjian@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/5] fixes for tap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 16 Apr 2020 11:03:57 +0800 wangyunjian wrote: > From: Yunjian Wang > > This series include five fixes patches for tap PMD driver. > > -- > v5: > * fix check fd error > v4: > * Update some code suggested by Ferruh Yigit and Stephen Hemminger > * Update commit log > * Add fix leak of fds on failure > v3: > * Add fix close a vaild fd and netlink socket file descriptor check > before close > v2: > * Add null check in tap_rxq_pool_free() > > Yunjian Wang (5): > net/tap: fix mbuf double free when writev fails > net/tap: fix mbuf and mem leak during queue release > net/tap: fix check for mbuf's nb_segs failure > net/tap: fix close a valid fd > net/tap: fix leak of fds on failure > > drivers/net/tap/rte_eth_tap.c | 106 ++++++++++++++++++++-------------- > 1 file changed, 63 insertions(+), 43 deletions(-) > These all look good. Acked-by: Stephen Hemminger