From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Joyce Kong <joyce.kong@arm.com>
Cc: maxime.coquelin@redhat.com, stephen@networkplumber.org,
tiwei.bie@intel.com, zhihong.wang@intel.com, thomas@monjalon.net,
jerinj@marvell.com, yinan.wang@intel.com,
honnappa.nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/2] one way barrier for split vring idx
Date: Thu, 16 Apr 2020 17:08:27 +0800 [thread overview]
Message-ID: <20200416090827.GA13374@intel.com> (raw)
In-Reply-To: <20200406152634.606-1-joyce.kong@arm.com>
Hi, Joyce
Thanks for the patch.
On 04/06, Joyce Kong wrote:
>This patch set replaces the two-way barriers with C11 one-way barriers
>for split vring idx, when the frontend and backend are implemented
>in software.
>
>By doing PVP benchmarking, the test result showed the throughput increased
>20% with the 0.001% of acceptable loss rate on Thunderx2 platform.[1]
>
>By doing vhost-user + virtio-user case benchmarking, 4% performance gain
>in the RFC2544 test of 0.001% of acceptable loss rate was measured on
>Thunderx2 platform.[2]
One quick question is do you have the performance number on IA platform since
the code touches the common part of the virtio PMD?
Thanks,
Xiaolong
>
>[1]https://doc.dpdk.org/guides/howto/pvp_reference_benchmark.html
>[2]https://doc.dpdk.org/dts/test_plans/pvp_multi_paths_performance_test_plan.html
> PVP test with virtio 1.0 normal path
>
>v3:
>Modify some style error.
>
>v2:
>Add test performance statistics.
>
>Joyce Kong (2):
> virtio: one way barrier for split vring used idx
> virtio: one way barrier for split vring avail idx
>
> drivers/net/virtio/virtio_ethdev.c | 9 ++-
> drivers/net/virtio/virtio_ring.h | 2 +-
> drivers/net/virtio/virtio_rxtx.c | 46 +++++++--------
> drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +-
> drivers/net/virtio/virtio_rxtx_simple_sse.c | 5 +-
> .../net/virtio/virtio_user/virtio_user_dev.c | 8 ++-
> drivers/net/virtio/virtqueue.c | 2 +-
> drivers/net/virtio/virtqueue.h | 57 ++++++++++++++++---
> lib/librte_vhost/virtio_net.c | 19 +++----
> 9 files changed, 94 insertions(+), 59 deletions(-)
>
>--
>2.17.1
>
next prev parent reply other threads:[~2020-04-16 9:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 9:24 [dpdk-dev] [PATCH v1 " Joyce Kong
2020-02-12 9:24 ` [dpdk-dev] [PATCH v1 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-02-12 9:24 ` [dpdk-dev] [PATCH v1 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-02 2:57 ` [dpdk-dev] [PATCH v2 0/2] one way barrier for split vring idx Joyce Kong
2020-04-02 2:57 ` [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-02 15:47 ` Stephen Hemminger
2020-04-03 8:55 ` Gavin Hu
2020-04-16 4:40 ` Honnappa Nagarahalli
2020-04-16 6:46 ` Joyce Kong
2020-04-02 2:57 ` [dpdk-dev] [PATCH v2 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-06 15:26 ` [dpdk-dev] [PATCH v3 0/2] one way barrier for split vring idx Joyce Kong
2020-04-16 9:08 ` Ye Xiaolong [this message]
2020-04-06 15:26 ` [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-17 6:51 ` Ye Xiaolong
2020-04-17 8:14 ` Joyce Kong
2020-04-06 15:26 ` [dpdk-dev] [PATCH v3 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-24 3:39 ` [dpdk-dev] [PATCH v4 0/2] one way barrier for split vring idx Joyce Kong
2020-04-28 16:06 ` Maxime Coquelin
2020-04-29 17:45 ` Ferruh Yigit
2020-04-30 9:09 ` Maxime Coquelin
2020-04-30 9:16 ` Joyce Kong
2020-04-30 9:24 ` Maxime Coquelin
2020-04-24 3:39 ` [dpdk-dev] [PATCH v4 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-27 9:03 ` Maxime Coquelin
2020-04-24 3:39 ` [dpdk-dev] [PATCH v4 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-27 9:03 ` Maxime Coquelin
2020-04-30 9:14 ` [dpdk-dev] [PATCH v5 0/2] one way barrier for split vring idx Joyce Kong
2020-04-30 20:54 ` Maxime Coquelin
2020-04-30 9:14 ` [dpdk-dev] [PATCH v5 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-30 22:58 ` Ferruh Yigit
2020-05-04 10:04 ` Maxime Coquelin
2020-04-30 9:14 ` [dpdk-dev] [PATCH v5 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416090827.GA13374@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=maxime.coquelin@redhat.com \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=yinan.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).