From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C315A0588; Thu, 16 Apr 2020 11:12:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72AB21DB10; Thu, 16 Apr 2020 11:12:39 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id F3C4A1DB0C for ; Thu, 16 Apr 2020 11:12:37 +0200 (CEST) IronPort-SDR: HrNW8qkCDmgOWbUAJau6UQ6kedCXc13PQsAK8XcgR0jY463bI6sPrieZ21g9f1ASX65pEAjun0 5ivXrkluEqjg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 02:12:37 -0700 IronPort-SDR: EsGba4HFnHWiuhnQq/oDzvs27yhqkT0qe1PVBNfHwqMZ1R7AL3cZGAaBxygmba92I0/JmqCFVl X+5xackjDZug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="454257221" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga005.fm.intel.com with ESMTP; 16 Apr 2020 02:12:34 -0700 Date: Thu, 16 Apr 2020 17:08:27 +0800 From: Ye Xiaolong To: Joyce Kong Cc: maxime.coquelin@redhat.com, stephen@networkplumber.org, tiwei.bie@intel.com, zhihong.wang@intel.com, thomas@monjalon.net, jerinj@marvell.com, yinan.wang@intel.com, honnappa.nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com, dev@dpdk.org Message-ID: <20200416090827.GA13374@intel.com> References: <20200212092456.29433-1-joyce.kong@arm.com> <20200406152634.606-1-joyce.kong@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406152634.606-1-joyce.kong@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 0/2] one way barrier for split vring idx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Joyce Thanks for the patch. On 04/06, Joyce Kong wrote: >This patch set replaces the two-way barriers with C11 one-way barriers >for split vring idx, when the frontend and backend are implemented >in software. > >By doing PVP benchmarking, the test result showed the throughput increased >20% with the 0.001% of acceptable loss rate on Thunderx2 platform.[1] > >By doing vhost-user + virtio-user case benchmarking, 4% performance gain >in the RFC2544 test of 0.001% of acceptable loss rate was measured on >Thunderx2 platform.[2] One quick question is do you have the performance number on IA platform since the code touches the common part of the virtio PMD? Thanks, Xiaolong > >[1]https://doc.dpdk.org/guides/howto/pvp_reference_benchmark.html >[2]https://doc.dpdk.org/dts/test_plans/pvp_multi_paths_performance_test_plan.html > PVP test with virtio 1.0 normal path > >v3: >Modify some style error. > >v2: >Add test performance statistics. > >Joyce Kong (2): > virtio: one way barrier for split vring used idx > virtio: one way barrier for split vring avail idx > > drivers/net/virtio/virtio_ethdev.c | 9 ++- > drivers/net/virtio/virtio_ring.h | 2 +- > drivers/net/virtio/virtio_rxtx.c | 46 +++++++-------- > drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +- > drivers/net/virtio/virtio_rxtx_simple_sse.c | 5 +- > .../net/virtio/virtio_user/virtio_user_dev.c | 8 ++- > drivers/net/virtio/virtqueue.c | 2 +- > drivers/net/virtio/virtqueue.h | 57 ++++++++++++++++--- > lib/librte_vhost/virtio_net.c | 19 +++---- > 9 files changed, 94 insertions(+), 59 deletions(-) > >-- >2.17.1 >