From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB979A0588; Fri, 17 Apr 2020 06:16:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ED771DE0F; Fri, 17 Apr 2020 06:16:05 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 585011DD54 for ; Fri, 17 Apr 2020 06:16:03 +0200 (CEST) IronPort-SDR: qyKtpAV7Yb+iUuxhAczUN1o/Uf+PTvN859ysESmiqyYuDvyOQxc3qhoy+RqBA+L0iOrw8R18Bl 0Y6A9wzuasLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 21:16:02 -0700 IronPort-SDR: Y9aFwWNYIf/D72WlDw92w0DogW6Rw01jZlw/sUq4lFmkZebgZ9KkCQUr6HmU/EILajZ4z8R7Ak SUvZcWIjLtOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,393,1580803200"; d="scan'208";a="454590010" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga005.fm.intel.com with ESMTP; 16 Apr 2020 21:16:00 -0700 Date: Fri, 17 Apr 2020 12:11:52 +0800 From: Ye Xiaolong To: "Zhang, Qi Z" Cc: "Rong, Leyi" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" Message-ID: <20200417041152.GB34073@intel.com> References: <20200316074603.10998-1-leyi.rong@intel.com> <20200416080947.55005-1-leyi.rong@intel.com> <039ED4275CED7440929022BC67E70611547FBE9A@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <039ED4275CED7440929022BC67E70611547FBE9A@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v5 00/11] framework for advanced iAVF PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/16, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Rong, Leyi >> Sent: Thursday, April 16, 2020 4:10 PM >> To: Wu, Jingjing ; Zhang, Qi Z >> ; Xing, Beilei ; Ye, Xiaolong >> >> Cc: dev@dpdk.org; Rong, Leyi >> Subject: [PATCH v5 00/11] framework for advanced iAVF PMD >> >> This patchset enable framework for advanced iAVF, includes flexible >> descriptor support, FDIR mark id and RSS hash support. >> >> --- >> v5: >> - Set rxdid = 0 in iavf_configure_queues() when it's supported and >> RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. So the error can be captured >> explicitly as kernel PF does not support it yet. >> - Fix some build errors when RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. >> >> v4: >> - Avoid initial declaration in 'for' loop to backward-compatible >> with older gcc versions. >> >> v3: >> - Remove patch to query DDP package info as it's specific to DCF. >> - Specify fdir_ref_cnt as per VF value for enable/disable FDIR ID parse. >> - Move fdir_enabled flag to per Queue value for cache benefit when >> access in vector routines. >> - Store extracted flow_id value to mbuf without judgement to avoid >> branch speculation fail, which is benefit to performance. >> >> v2: >> - Revert macro RTE_LIBRTE_IAVF_16BYTE_RX_DESC deletion as >> it's defined in AVF spec. >> - Typo RTE_LIBRTE_ICE_16BYTE_RX_DESC fix in iavf_rxtx.c. >> - Move flex desc definitions into iavf_rxtx.h. >> - Up to date to match with the latest version of virtchnl.h. >> - Extract a new internal func iavf_update_rx_tail to call. >> - Remove >> iavf_dev_rxq_count_flex_rxd()/iavf_dev_rx_desc_status_flex_rxd(), >> as the accompanying legacy ones can deal with the flex desc cases. >> - Move rxq->rxdid assignment from iavf_configure_queues() >> to iavf_dev_rx_queue_setup(). >> - Unfold _mm_extract_epi32(fdir_id0_3, i) to fix build error >> when using GCC compile option -O0. >> >> Leyi Rong (11): >> net/iavf: flexible Rx descriptor definitions >> net/iavf: return error if opcode is mismatched >> net/iavf: flexible Rx descriptor support in normal path >> net/iavf: flexible Rx descriptor support in AVX path >> net/iavf: flexible Rx descriptor support in SSE path >> net/iavf: add flow director enabled switch value >> net/iavf: support flow mark in normal data path >> net/iavf: support flow mark in AVX path >> net/iavf: support flow mark in SSE path >> net/iavf: add RSS hash parsing in AVX path >> net/iavf: add RSS hash parsing in SSE path >> >> drivers/net/iavf/iavf.h | 6 + >> drivers/net/iavf/iavf_ethdev.c | 8 + >> drivers/net/iavf/iavf_rxtx.c | 546 ++++++++++++++++++-- >> drivers/net/iavf/iavf_rxtx.h | 250 +++++++++ >> drivers/net/iavf/iavf_rxtx_vec_avx2.c | 702 >> +++++++++++++++++++++++++- drivers/net/iavf/iavf_rxtx_vec_sse.c | >> 520 +++++++++++++++++++ >> drivers/net/iavf/iavf_vchnl.c | 59 ++- >> 7 files changed, 2042 insertions(+), 49 deletions(-) >> >> -- >> 2.17.1 > >Reviewed-by: Qi Zhang > > Applied to dpdk-next-net-intel, Thanks.