From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92145A058A; Fri, 17 Apr 2020 15:14:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5E551E85E; Fri, 17 Apr 2020 15:14:24 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id B0C521E570 for ; Fri, 17 Apr 2020 15:14:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587129263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HbkM3sqCtqTXl7muw0vy0kup2YXHjWycCzPd38sU+eo=; b=ZgeKD8gW/t+Me0RlVERJuYLUD2zX58M10VblvwbmnycvjQWUB7ikeoJRLXJYdH5ztN7rha 5fgxcQ03mn/KPhVh3fMl+vuj1GRiZg0+nMx3qQINaX6LQzspzI0NXKMDSeuvflkle+iAQO 3uKFUm6/hq/YiM9BNGDHLlEWzvqkaNU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-wpYRV7fRNNGCgiKrECnhYg-1; Fri, 17 Apr 2020 09:14:21 -0400 X-MC-Unique: wpYRV7fRNNGCgiKrECnhYg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BF5880268A; Fri, 17 Apr 2020 13:14:20 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-116-136.phx2.redhat.com [10.3.116.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63D177E7FF; Fri, 17 Apr 2020 13:14:19 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Cc: Konstantin Ananyev , Pavan Nikhilesh , Bruce Richardson , David Marchand , Ferruh Yigit , Anatoly Burakov , Lukasz Wojciechowski Date: Fri, 17 Apr 2020 09:14:08 -0400 Message-Id: <20200417131410.1343135-2-aconole@redhat.com> In-Reply-To: <20200417131410.1343135-1-aconole@redhat.com> References: <20200415172547.1421587-1-aconole@redhat.com> <20200417131410.1343135-1-aconole@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v5 1/3] ip_frag: ensure minimum v4 fragmentation length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Do a formal parameter check of mtu length, as well as checking the the various inputs for validity. If any aren't acceptable, we bail. Acked-by: Lukasz Wojciechowski Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_fr= ag/rte_ipv4_fragmentation.c index 9e9f986cc5..c36678a6d2 100644 --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c @@ -76,6 +76,15 @@ rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in, =09uint16_t fragment_offset, flag_offset, frag_size; =09uint16_t frag_bytes_remaining; =20 +=09/* +=09 * Formal parameter checking. +=09 */ +=09if (unlikely(pkt_in =3D=3D NULL) || unlikely(pkts_out =3D=3D NULL) || +=09 unlikely(nb_pkts_out =3D=3D 0) || +=09 unlikely(pool_direct =3D=3D NULL) || unlikely(pool_indirect =3D=3D = NULL) || +=09 unlikely(mtu_size < 68)) +=09=09return -EINVAL; + =09/* =09 * Ensure the IP payload length of all fragments is aligned to a =09 * multiple of 8 bytes as per RFC791 section 2.3. --=20 2.25.1