From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Dong Zhou <dongz@mellanox.com>,
orika@mellanox.com, matan@mellanox.com, wenzhuo.lu@intel.com,
jingjing.wu@intel.com, bernard.iremonger@intel.com,
john.mcnamara@intel.com, marko.kovacevic@intel.com,
thomas@monjalon.net, arybchenko@solarflare.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging
Date: Fri, 17 Apr 2020 15:07:32 -0700 [thread overview]
Message-ID: <20200417150732.4668bbf8@hermes.lan> (raw)
In-Reply-To: <192e2e54-17fe-5444-1917-3982837f6e5c@intel.com>
On Fri, 17 Apr 2020 23:00:57 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 4/14/2020 9:32 AM, Dong Zhou wrote:
> > One of the reasons to destroy a flow is the fact that no packet matches the
> > flow for "timeout" time.
> > For example, when TCP\UDP sessions are suddenly closed.
> >
> > Currently, there is not any DPDK mechanism for flow aging and the
> > applications use their own ways to detect and destroy aged-out flows.
> >
> > The flow aging implementation need include:
> > - A new rte_flow action: RTE_FLOW_ACTION_TYPE_AGE to set the timeout and
> > the application flow context for each flow.
> > - A new ethdev event: RTE_ETH_EVENT_FLOW_AGED for the driver to report
> > that there are new aged-out flows.
> > - A new rte_flow API: rte_flow_get_aged_flows to get the aged-out flows
> > contexts from the port.
> > - Support input flow aging command line in Testpmd.
> >
> > Signed-off-by: Dong Zhou <dongz@mellanox.com>
>
> <...>
>
> > --- a/lib/librte_ethdev/rte_ethdev.h
> > +++ b/lib/librte_ethdev/rte_ethdev.h
> > @@ -3015,6 +3015,7 @@ enum rte_eth_event_type {
> > RTE_ETH_EVENT_NEW, /**< port is probed */
> > RTE_ETH_EVENT_DESTROY, /**< port is released */
> > RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */
> > + RTE_ETH_EVENT_FLOW_AGED,/**< New aged-out flows is detected */
> > RTE_ETH_EVENT_MAX /**< max value of this enum */
> > };
>
>
> Just recognized that this is failing in ABI check [1], as far as last time for a
> similar enum warning a QAT patch has been dropped, should this need to wait for
> 20.11 too?
>
>
> [1]
> [C]'function int _rte_eth_dev_callback_process(rte_eth_dev*,
> rte_eth_event_type, void*)' at rte_ethdev.c:4063:1 has some indirect sub-type
> changes:
> parameter 2 of type 'enum rte_eth_event_type' has sub-type changes:
> type size hasn't changed
> 1 enumerator insertion:
> 'rte_eth_event_type::RTE_ETH_EVENT_FLOW_AGED' value '10'
> 1 enumerator change:
> 'rte_eth_event_type::RTE_ETH_EVENT_MAX' from value '10' to '11' at
> rte_ethdev.h:3008:1
>
For 20.11, those _MAX values need to be removed from enums
next prev parent reply other threads:[~2020-04-17 22:07 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 10:18 [dpdk-dev] [PATCH] [RFC] " Matan Azrad
2019-06-06 10:24 ` Jerin Jacob Kollanukkaran
2019-06-06 10:51 ` Matan Azrad
2019-06-06 12:15 ` Jerin Jacob Kollanukkaran
2019-06-18 5:56 ` Matan Azrad
2019-06-24 6:26 ` Jerin Jacob Kollanukkaran
2019-06-27 8:26 ` Matan Azrad
2020-03-16 16:13 ` Stephen Hemminger
2020-03-16 10:22 ` [dpdk-dev] [PATCH v2] " BillZhou
2020-03-16 12:52 ` BillZhou
2020-03-20 6:59 ` Jerin Jacob
2020-03-24 10:18 ` Andrew Rybchenko
2020-04-10 9:46 ` [dpdk-dev] [PATCH] " BillZhou
2020-04-10 10:14 ` Thomas Monjalon
2020-04-13 4:02 ` Bill Zhou
2020-04-10 12:07 ` Andrew Rybchenko
2020-04-10 12:41 ` Jerin Jacob
2020-04-12 9:13 ` Ori Kam
2020-04-12 9:48 ` Matan Azrad
2020-04-14 8:32 ` [dpdk-dev] [PATCH v2] " Dong Zhou
2020-04-14 8:49 ` Ori Kam
2020-04-14 9:23 ` Bill Zhou
2020-04-16 13:32 ` Ferruh Yigit
2020-04-17 22:00 ` Ferruh Yigit
2020-04-17 22:07 ` Stephen Hemminger [this message]
2020-04-18 5:04 ` Bill Zhou
2020-04-18 9:44 ` Thomas Monjalon
2020-04-20 14:06 ` Ferruh Yigit
2020-04-20 16:10 ` Thomas Monjalon
2020-04-21 10:04 ` Ferruh Yigit
2020-04-21 10:09 ` Thomas Monjalon
2020-04-21 15:59 ` Andrew Rybchenko
2020-04-21 6:22 ` [dpdk-dev] [PATCH v3] " Bill Zhou
2020-04-21 10:11 ` [dpdk-dev] [PATCH v4] " Bill Zhou
2020-04-21 17:13 ` Ferruh Yigit
2020-04-29 14:50 ` Tom Barbette
2020-04-30 7:36 ` Matan Azrad
2020-04-30 7:49 ` Tom Barbette
2020-04-13 14:53 ` [dpdk-dev] [PATCH 0/2] " Dong Zhou
2020-04-13 14:53 ` [dpdk-dev] [PATCH 1/2] net/mlx5: modify ext-counter memory allocation Dong Zhou
2020-04-13 14:53 ` [dpdk-dev] [PATCH 2/2] net/mlx5: support flow aging Dong Zhou
2020-04-24 10:45 ` [dpdk-dev] [PATCH v2 0/2] " Bill Zhou
2020-04-24 10:45 ` [dpdk-dev] [PATCH v2 1/2] net/mlx5: modify ext-counter memory allocation Bill Zhou
2020-04-24 10:45 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: support flow aging Bill Zhou
2020-04-26 7:07 ` Suanming Mou
2020-04-29 2:25 ` [dpdk-dev] [PATCH v3 0/2] " Bill Zhou
2020-04-29 2:25 ` [dpdk-dev] [PATCH v3 1/2] net/mlx5: modify ext-counter memory allocation Bill Zhou
2020-04-29 2:25 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: support flow aging Bill Zhou
2020-05-03 7:41 ` [dpdk-dev] [PATCH v3 0/2] " Matan Azrad
2020-05-03 11:47 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417150732.4668bbf8@hermes.lan \
--to=stephen@networkplumber.org \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=dongz@mellanox.com \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).