* [dpdk-dev] [PATCH] examples/vm_power_manager: fix build
@ 2020-04-17 18:55 Ferruh Yigit
2020-04-17 21:14 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2020-04-17 18:55 UTC (permalink / raw)
To: David Hunt, Thomas Monjalon; +Cc: dev, Ferruh Yigit
Build fails because '__rte_unused' macro not defined in file, error
produced by 'i686-native-linux-gcc config' but it seems generic issue.
Build error:
.../examples/vm_power_manager/oob_monitor_nop.c:11:13:
error: expected ‘;’ before ‘static’
11 | __rte_unused static float
| ^~~~~~~
| ;
.../examples/vm_power_manager/oob_monitor_nop.c:12:14:
error: unknown type name ‘__rte_unused’
12 | apply_policy(__rte_unused int core)
| ^~~~~~~~~~~~
.../examples/vm_power_manager/oob_monitor_nop.c:18:21:
error: unknown type name ‘__rte_unused’
18 | add_core_to_monitor(__rte_unused int core)
| ^~~~~~~~~~~~
.../examples/vm_power_manager/oob_monitor_nop.c:24:26:
error: unknown type name ‘__rte_unused’
24 | remove_core_from_monitor(__rte_unused int core)
| ^~~~~~~~~~~~
Including 'rte_common.h' header which defines the macro for fix.
Fixes: f2fc83b40f06 ("replace unused attributes")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: thomas@monjalon.net
---
examples/vm_power_manager/oob_monitor_nop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/examples/vm_power_manager/oob_monitor_nop.c b/examples/vm_power_manager/oob_monitor_nop.c
index fc73ce18e..08dc6a72d 100644
--- a/examples/vm_power_manager/oob_monitor_nop.c
+++ b/examples/vm_power_manager/oob_monitor_nop.c
@@ -2,6 +2,8 @@
* Copyright(c) 2010-2014 Intel Corporation
*/
+#include <rte_common.h>
+
#include "oob_monitor.h"
void branch_monitor_exit(void)
--
2.25.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix build
2020-04-17 18:55 [dpdk-dev] [PATCH] examples/vm_power_manager: fix build Ferruh Yigit
@ 2020-04-17 21:14 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-04-17 21:14 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: David Hunt, dev
17/04/2020 20:55, Ferruh Yigit:
> Build fails because '__rte_unused' macro not defined in file, error
> produced by 'i686-native-linux-gcc config' but it seems generic issue.
>
> Build error:
> .../examples/vm_power_manager/oob_monitor_nop.c:11:13:
> error: expected ‘;’ before ‘static’
> 11 | __rte_unused static float
> | ^~~~~~~
> | ;
> .../examples/vm_power_manager/oob_monitor_nop.c:12:14:
> error: unknown type name ‘__rte_unused’
> 12 | apply_policy(__rte_unused int core)
> | ^~~~~~~~~~~~
> .../examples/vm_power_manager/oob_monitor_nop.c:18:21:
> error: unknown type name ‘__rte_unused’
> 18 | add_core_to_monitor(__rte_unused int core)
> | ^~~~~~~~~~~~
> .../examples/vm_power_manager/oob_monitor_nop.c:24:26:
> error: unknown type name ‘__rte_unused’
> 24 | remove_core_from_monitor(__rte_unused int core)
> | ^~~~~~~~~~~~
>
> Including 'rte_common.h' header which defines the macro for fix.
>
> Fixes: f2fc83b40f06 ("replace unused attributes")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
The file oob_monitor_nop.c is not compiled on x86_64.
Unfortunately, my build matrix does not include vm_power_manager
on i686.
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-17 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 18:55 [dpdk-dev] [PATCH] examples/vm_power_manager: fix build Ferruh Yigit
2020-04-17 21:14 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).