DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v1 00/17] introduce global debug flag
Date: Fri, 17 Apr 2020 23:57:22 +0200	[thread overview]
Message-ID: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> (raw)
In-Reply-To: <CGME20200417215755eucas1p25660167c57c26ef04a82a8bb981e07b5@eucas1p2.samsung.com>

This set of patches introduces a global debug flag for dpdk.
This will allow easy switch to debug build configuration using a single
flag. In the debug mode a RTE_DEBUG macro is defined to 1
and can be used to place a debug code inside #ifdef #endif clauses.

It should be used for enabling debug code in all dpdk project
components. Using this flag allows to make additional checks or tests
and provide additional logs even in performance sensitive parts of code.

The build system a built-in meson "debug" flag to switch to debug build.


The set of patches introduces the global debug flag and replaces library
debug flags. It is split to many small patches for easier review
as it affects almost all libraries. Before merge it can be squash into
larger patches (if preferred by maintainers).

As a next step I plan to prepare patches for drivers as well.


Lukasz Wojciechowski (17):
  config: introduce global debug flag
  config: remove unused config flags
  ethdev: replace library debug flag with global one
  eventdev: replace library debug flag with global one
  fib: replace library debug flag with global one
  cmdline: replace library debug flag with global one
  hash: replace library debug flag with global one
  ip_frag: replace library debug flag with global one
  lpm: replace library debug flag with global one
  mbuf: replace library debug flag with global one
  mempool: replace library debug flag with global one
  power: replace library debug flag with global one
  rcu: replace library debug flag with global one
  timer: replace library debug flag with global one
  vhost: replace library debug flag with global one
  eal: replace library debug flag with global one
  sched: replace library debug flag with global one

 app/test/test_lpm.c                           |  2 +-
 app/test/test_malloc.c                        |  4 ++--
 app/test/test_mbuf.c                          |  2 +-
 app/test/test_timer_secondary.c               |  2 +-
 config/common_base                            | 19 ------------------
 config/meson.build                            |  4 ++++
 .../prog_guide/env_abstraction_layer.rst      |  5 +++--
 .../prog_guide/ip_fragment_reassembly_lib.rst |  4 ++--
 doc/guides/prog_guide/mbuf_lib.rst            |  2 +-
 doc/guides/prog_guide/mempool_lib.rst         |  7 ++++---
 doc/guides/prog_guide/rcu_lib.rst             |  8 ++++----
 drivers/net/atlantic/atl_rxtx.c               |  2 +-
 drivers/net/e1000/em_rxtx.c                   |  2 +-
 drivers/net/e1000/igb_rxtx.c                  |  2 +-
 drivers/net/ena/ena_ethdev.c                  |  2 +-
 drivers/net/enic/enic_rxtx.c                  |  2 +-
 drivers/net/fm10k/fm10k_rxtx.c                |  2 +-
 drivers/net/hinic/hinic_pmd_tx.c              |  2 +-
 drivers/net/hns3/hns3_rxtx.c                  |  2 +-
 drivers/net/i40e/i40e_rxtx.c                  |  2 +-
 drivers/net/iavf/iavf_rxtx.c                  |  2 +-
 drivers/net/ice/ice_rxtx.c                    |  2 +-
 drivers/net/ixgbe/ixgbe_rxtx.c                |  2 +-
 drivers/net/qede/qede_rxtx.c                  |  4 ++--
 drivers/net/softnic/rte_eth_softnic.c         |  2 +-
 drivers/net/softnic/rte_eth_softnic_thread.c  |  2 +-
 drivers/net/virtio/virtio_rxtx.c              |  2 +-
 drivers/net/vmxnet3/vmxnet3_rxtx.c            |  2 +-
 lib/librte_cmdline/cmdline_cirbuf.h           |  2 +-
 lib/librte_cmdline/cmdline_parse.c            |  2 +-
 lib/librte_cmdline/cmdline_parse_num.c        |  2 +-
 lib/librte_eal/common/malloc_elem.c           |  2 +-
 lib/librte_eal/common/malloc_elem.h           |  4 ++--
 lib/librte_eal/common/rte_malloc.c            |  2 +-
 lib/librte_ethdev/rte_ethdev.h                | 16 +++++++--------
 .../rte_event_eth_tx_adapter.h                |  2 +-
 lib/librte_eventdev/rte_event_timer_adapter.c |  6 +++---
 lib/librte_eventdev/rte_event_timer_adapter.h |  6 +++---
 lib/librte_eventdev/rte_eventdev.h            |  4 ++--
 lib/librte_eventdev/rte_eventdev_pmd.h        |  2 +-
 lib/librte_fib/rte_fib.c                      |  2 +-
 lib/librte_fib/rte_fib6.c                     |  2 +-
 lib/librte_hash/rte_cuckoo_hash.h             |  4 ++--
 lib/librte_ip_frag/ip_frag_common.h           |  4 ++--
 lib/librte_lpm/rte_lpm.c                      |  2 +-
 lib/librte_lpm/rte_lpm.h                      |  2 +-
 lib/librte_mbuf/rte_mbuf.h                    |  6 +++---
 lib/librte_mempool/rte_mempool.c              | 16 +++++++--------
 lib/librte_mempool/rte_mempool.h              | 20 +++++++++----------
 lib/librte_net/rte_net.h                      |  4 ++--
 lib/librte_power/power_acpi_cpufreq.c         |  2 +-
 lib/librte_power/power_pstate_cpufreq.c       |  2 +-
 lib/librte_rcu/rte_rcu_qsbr.h                 | 16 +++++++--------
 lib/librte_sched/rte_sched.c                  | 10 +++++-----
 lib/librte_timer/rte_timer.c                  | 12 +++++------
 lib/librte_timer/rte_timer.h                  |  2 +-
 lib/librte_vhost/vhost.h                      |  2 +-
 lib/librte_vhost/vhost_crypto.c               |  2 +-
 lib/librte_vhost/vhost_user.c                 |  2 +-
 59 files changed, 122 insertions(+), 135 deletions(-)

-- 
2.17.1


       reply	other threads:[~2020-04-17 21:58 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200417215755eucas1p25660167c57c26ef04a82a8bb981e07b5@eucas1p2.samsung.com>
2020-04-17 21:57 ` Lukasz Wojciechowski [this message]
     [not found]   ` <CGME20200417215756eucas1p107941824d555cdc91899d529d3c4ee67@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 01/17] config: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215756eucas1p13a995889338901b81bf2a59a5a4f1260@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 02/17] config: remove unused config flags Lukasz Wojciechowski
     [not found]   ` <CGME20200417215759eucas1p1c0fcc3046d87dc9de1d15572ba6b7caa@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one Lukasz Wojciechowski
2020-04-20  9:04       ` Dumitrescu, Cristian
2020-04-20 13:37         ` Ananyev, Konstantin
2020-04-20 14:21           ` Bruce Richardson
2020-04-20 14:43             ` Lukasz Wojciechowski
2020-04-20 17:11               ` Bruce Richardson
2020-04-20 17:21                 ` Thomas Monjalon
2020-04-20 17:30                   ` Bruce Richardson
2020-04-20 17:34                     ` Lukasz Wojciechowski
2023-06-12 16:23                       ` Stephen Hemminger
2020-04-20 17:35                     ` Thomas Monjalon
2020-04-20 18:57                       ` Bruce Richardson
2020-04-21  0:32                         ` Ananyev, Konstantin
2020-04-21 20:58                           ` Lukasz Wojciechowski
2020-04-21 21:38                             ` Thomas Monjalon
2020-04-22 10:41                               ` Lukasz Wojciechowski
2020-04-22 10:55                                 ` Bruce Richardson
2020-04-22 11:02                                   ` Thomas Monjalon
2020-04-22 11:16                                     ` Bruce Richardson
2020-04-22 11:29                                     ` Ananyev, Konstantin
2020-04-22 12:24                                       ` Thomas Monjalon
2020-07-09 14:09                                         ` Lukasz Wojciechowski
2020-07-14 10:30                                           ` Ananyev, Konstantin
2020-04-22 11:52                                     ` Lukasz Wojciechowski
2020-04-22 12:44                                       ` Bruce Richardson
2020-04-20 17:24                 ` Bruce Richardson
     [not found]   ` <CGME20200417215800eucas1p2f3a71aaf69584fc37c9c4a47c3a2d39d@eucas1p2.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 04/17] eventdev: " Lukasz Wojciechowski
2020-04-18  9:41       ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2020-04-18  9:53         ` Thomas Monjalon
2020-04-18 10:05           ` Jerin Jacob
2020-04-18 13:22             ` Thomas Monjalon
     [not found]   ` <CGME20200417215801eucas1p28aefc04e119aa5de16a7f0771bb0e268@eucas1p2.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 05/17] fib: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215801eucas1p25e56a60eda9b741ba26e686b90ed8e28@eucas1p2.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 06/17] cmdline: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215802eucas1p27d4041768b717226b7161d0b896c3261@eucas1p2.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 07/17] hash: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215803eucas1p16013610674ce6ac58189259f2632f562@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 08/17] ip_frag: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215804eucas1p2c04d6f2141be07b25f0d346c73d4f965@eucas1p2.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 09/17] lpm: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215805eucas1p114b3286afa16d6f12916048234f3a159@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 10/17] mbuf: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215805eucas1p2530efed5c5a73df8cc5fb613b11dfdde@eucas1p2.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 11/17] mempool: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215806eucas1p1df0cf8a6cfe65dd687dde9056854bbad@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 12/17] power: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215807eucas1p14de926321e5a683224f7550ae902af5b@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 13/17] rcu: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215808eucas1p26bb784466131275eeccff018ecac83ca@eucas1p2.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 14/17] timer: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215808eucas1p1aa9a24a464a4470d27b6c770d2e8c297@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 15/17] vhost: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215809eucas1p1d826c921a9880007af4ee4282dda5d32@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 16/17] eal: " Lukasz Wojciechowski
     [not found]   ` <CGME20200417215810eucas1p17a63d33a4d49c8866733a33ce717484b@eucas1p1.samsung.com>
2020-04-17 21:57     ` [dpdk-dev] [PATCH v1 17/17] sched: " Lukasz Wojciechowski
2020-04-20  9:04       ` Dumitrescu, Cristian
     [not found]   ` <CGME20200422214613eucas1p153ed981de395ef1b800364a003da85e5@eucas1p1.samsung.com>
2020-04-22 21:45     ` [dpdk-dev] [PATCH v2 0/3] introduce global debug flag Lukasz Wojciechowski
     [not found]       ` <CGME20200422214614eucas1p1044184e60bcb04469783ef0dd95091c1@eucas1p1.samsung.com>
2020-04-22 21:45         ` [dpdk-dev] [PATCH v2 1/3] config: introduce global rte " Lukasz Wojciechowski
2020-06-26 16:56           ` Bruce Richardson
2020-06-28  8:40             ` Andrew Rybchenko
2020-07-09 13:51             ` Lukasz Wojciechowski
2020-07-09 14:09               ` Bruce Richardson
2020-07-09 14:13                 ` Lukasz Wojciechowski
     [not found]       ` <CGME20200422214614eucas1p2ad5c7a54972cf47f182f51ba3346027b@eucas1p2.samsung.com>
2020-04-22 21:45         ` [dpdk-dev] [PATCH v2 2/3] config: remove unused config flags Lukasz Wojciechowski
2020-06-26 16:56           ` Bruce Richardson
     [not found]       ` <CGME20200422214615eucas1p2a50ce20695a77b5b2888fd4521296094@eucas1p2.samsung.com>
2020-04-22 21:45         ` [dpdk-dev] [PATCH v2 3/3] mbuf: standardize library debug flag Lukasz Wojciechowski
2020-06-26 17:00           ` Bruce Richardson
2020-07-09 13:50             ` Lukasz Wojciechowski
2020-04-24  9:09       ` [dpdk-dev] [PATCH v2 0/3] introduce global " Bruce Richardson
2020-04-24 10:14         ` Lukasz Wojciechowski
     [not found]       ` <CGME20200709134846eucas1p193d963c3f21f0d5c4985024b6d015042@eucas1p1.samsung.com>
2020-07-09 13:48         ` [dpdk-dev] [PATCH v3 0/4] " Lukasz Wojciechowski
     [not found]           ` <CGME20200709134847eucas1p2698cc0b2de3751aba984d306beb9d8f1@eucas1p2.samsung.com>
2020-07-09 13:48             ` [dpdk-dev] [PATCH v3 1/4] config: introduce global rte " Lukasz Wojciechowski
     [not found]           ` <CGME20200709134847eucas1p2c772544e09360a0b05e95e20c36fb0b8@eucas1p2.samsung.com>
2020-07-09 13:48             ` [dpdk-dev] [PATCH v3 2/4] config: remove unused config flags Lukasz Wojciechowski
2020-07-16  7:43               ` David Marchand
2020-07-16  8:41                 ` Ruifeng Wang
     [not found]           ` <CGME20200709134848eucas1p1b78c9b2d4556ae3047d52e9d6e41b11c@eucas1p1.samsung.com>
2020-07-09 13:48             ` [dpdk-dev] [PATCH v3 3/4] mbuf: standardize library debug flag Lukasz Wojciechowski
     [not found]           ` <CGME20200709134848eucas1p27b4f137a91aa805e84f981802da2a226@eucas1p2.samsung.com>
2020-07-09 13:48             ` [dpdk-dev] [PATCH v3 4/4] app/test: add mbuf perf tests Lukasz Wojciechowski
2020-07-11 15:11           ` [dpdk-dev] [PATCH v3 0/4] introduce global debug flag Thomas Monjalon
2020-07-13  9:04             ` Bruce Richardson
2020-07-13 22:44               ` Lukasz Wojciechowski
2020-07-13 22:39             ` Lukasz Wojciechowski
2020-07-14  1:23               ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417215739.23180-1-l.wojciechow@partner.samsung.com \
    --to=l.wojciechow@partner.samsung.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).