From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA407A0597; Fri, 17 Apr 2020 23:59:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 814461EBB1; Fri, 17 Apr 2020 23:58:14 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CB5D51EB84 for ; Fri, 17 Apr 2020 23:58:04 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200417215804euoutp01547ab1532ea15a10a38f951fd4872ea5~GujvIP3Qu2759027590euoutp01i for ; Fri, 17 Apr 2020 21:58:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200417215804euoutp01547ab1532ea15a10a38f951fd4872ea5~GujvIP3Qu2759027590euoutp01i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587160684; bh=QHqi1LWFdkO587dDZokPQxDwpswrWtVfK316/aO9me4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I3PKShtJUCC/98nL6fgd5+nYLAUh8SV0uPUcO+9oV/Z1PXLaeIIoxuLTd7RvpAKWB sTfm5D/nw9zbYC4FqWBchKmzXP5FOmOv/kPnDm+GrXxwymFrUNcCP4ZvHPZQxpNx4A WK7ffHlDvoZZmI2PalXp5LQ9UoisjHtl2S9+VdcQ= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200417215804eucas1p2053657f5faf6d52dd908e948bd4bb976~Guju-Doet1848618486eucas1p2o; Fri, 17 Apr 2020 21:58:04 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id BC.FF.61286.C662A9E5; Fri, 17 Apr 2020 22:58:04 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200417215803eucas1p16013610674ce6ac58189259f2632f562~GujuISc252225522255eucas1p1j; Fri, 17 Apr 2020 21:58:03 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200417215803eusmtrp27665cd532cce44cd0a1d47bd0229ed14~GujuHtAtG2952229522eusmtrp2i; Fri, 17 Apr 2020 21:58:03 +0000 (GMT) X-AuditID: cbfec7f2-ef1ff7000001ef66-57-5e9a266ce3af Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id BC.94.08375.B662A9E5; Fri, 17 Apr 2020 22:58:03 +0100 (BST) Received: from localhost.localdomain (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200417215802eusmtip29b1e03ea07c3fb22e222b8404b14f795~GujtlAbHy0325203252eusmtip2r; Fri, 17 Apr 2020 21:58:02 +0000 (GMT) From: Lukasz Wojciechowski To: Thomas Monjalon , Konstantin Ananyev , John McNamara , Marko Kovacevic Cc: dev@dpdk.org Date: Fri, 17 Apr 2020 23:57:30 +0200 Message-Id: <20200417215739.23180-9-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7djP87o5arPiDA7+FLN492k7k8X5eVtZ Ld7/WcRicX5jL6vFpwcnWBxYPX4tWMrqsXjPSyaPYzensQcwR3HZpKTmZJalFunbJXBlbH+1 iKXgglDFla6pzA2MN/m7GDk5JARMJC4f6WXrYuTiEBJYwSgxf/8JKOcLo8T37V+ZIJzPjBK9 lxezwLT0T5nHCJFYzihxdfd/VriqlmnP2UCq2ARsJY7M/AqWEBHYxihxuv8SE0iCWUBA4vG9 Z6wgtrCAv8SthT+ZQWwWAVWJq2fXgdXwCrhK/Duxlw1inbzE6g0HwGo4Bdwklr78DrZaQuA2 m8TpNVcZIYpcJJa3/INqEJZ4dXwLO4QtI/F/53wmiAagK67+/gnVvZ9R4nrvCqgqa4nD/34D dXMAnacpsX6XPkTYUWLnr9XsIGEJAT6JG28FIR7gk5i0bTozRJhXoqNNCKJaT+Jpz1RGmLV/ 1j6BBpeHxNfZDdBwnMkosWzybLYJjPKzEJYtYGRcxSieWlqcm55abJiXWq5XnJhbXJqXrpec n7uJEZgETv87/mkH49dLSYcYBTgYlXh4DXpmxgmxJpYVV+YeYpTgYFYS4T3oBhTiTUmsrEot yo8vKs1JLT7EKM3BoiTOa7zoZayQQHpiSWp2ampBahFMlomDU6qBMZjf+vyG+Iv6pj/q3Voe 6nzn+T9J33TX9NMpa2oqn7ja5PorJj8x2VAysXnH7xlL+lRNE22E9xxwL7hzdp6QTLejeenL rGkLN37xCp9Wvft8mGvGv1cL79m/k91x6OwpPb5SK3/m05btQfxvmRbn1SldjX1rP4t364Vw swNlX2tnn2OZfcj5vBJLcUaioRZzUXEiAMzpJu/+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xe7rZarPiDI7dkLN492k7k8X5eVtZ Ld7/WcRicX5jL6vFpwcnWBxYPX4tWMrqsXjPSyaPYzensQcwR+nZFOWXlqQqZOQXl9gqRRta GOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehlbH+1iKXgglDFla6pzA2MN/m7GDk5 JARMJPqnzGPsYuTiEBJYyihx8dxBti5GDqCEjMSHSwIQNcISf651sUHUfGSU+NfXzAKSYBOw lTgy8ysrSEJEYAejxPd1v9lBEswCAhKP7z1jBRkkLOArsfSDAUiYRUBV4urZdUwgNq+Aq8S/ E3vZIBbIS6zecIAZxOYUcJNY+vI7I4gtBFTz8OEp9gmMfAsYGVYxiqSWFuem5xYb6hUn5haX 5qXrJefnbmIEBuO2Yz8372C8tDH4EKMAB6MSD69Bz8w4IdbEsuLK3EOMEhzMSiK8B92AQrwp iZVVqUX58UWlOanFhxhNgY6ayCwlmpwPjJS8knhDU0NzC0tDc2NzYzMLJXHeDoGDMUIC6Ykl qdmpqQWpRTB9TBycUg2Mwge5Il9GGNq4NK0xnnX7e//80GV2x1meyyxhfimjetpjk5afbbrP jzc/IrjZD+Vui3ryo3z5/IuNB5bce5hYyPtTuXFRJn9htEHBq55k5ym2Dx0Z74bxnrgkENQc tWuyDdcHno8TTt2M81X5EDfLl43j6TUjdtUNNnf1bA4tUD2bxTAvqveLEktxRqKhFnNRcSIA S+d6TlwCAAA= X-CMS-MailID: 20200417215803eucas1p16013610674ce6ac58189259f2632f562 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200417215803eucas1p16013610674ce6ac58189259f2632f562 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200417215803eucas1p16013610674ce6ac58189259f2632f562 References: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-dev] [PATCH v1 08/17] ip_frag: replace library debug flag with global one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_IP_FRAG_DEBUG. The old define is completely removed from source code and config. The documentation was updated also. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - doc/guides/prog_guide/ip_fragment_reassembly_lib.rst | 4 ++-- lib/librte_ip_frag/ip_frag_common.h | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/config/common_base b/config/common_base index a12a869a9..44a9ab75c 100644 --- a/config/common_base +++ b/config/common_base @@ -956,7 +956,6 @@ CONFIG_RTE_LIBRTE_NET=y # Compile librte_ip_frag # CONFIG_RTE_LIBRTE_IP_FRAG=y -CONFIG_RTE_LIBRTE_IP_FRAG_DEBUG=n CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=4 CONFIG_RTE_LIBRTE_IP_FRAG_TBL_STAT=n diff --git a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst index 6ac1bba64..b48ccfbbf 100644 --- a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst +++ b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst @@ -104,7 +104,7 @@ Debug logging and Statistics Collection The RTE_LIBRTE_IP_FRAG_TBL_STAT config macro controls statistics collection for the Fragment Table. This macro is not enabled by default. -The RTE_LIBRTE_IP_FRAG_DEBUG controls debug logging of IP fragments processing and reassembling. -This macro is disabled by default. +The RTE_DEBUG controls debug logging of IP fragments processing and reassembling. +This macro is disabled by default and can be enabled using meson "debug" option. Note that while logging contains a lot of detailed information, it slows down packet processing and might cause the loss of a lot of packets. diff --git a/lib/librte_ip_frag/ip_frag_common.h b/lib/librte_ip_frag/ip_frag_common.h index a17a74076..79a0dbd18 100644 --- a/lib/librte_ip_frag/ip_frag_common.h +++ b/lib/librte_ip_frag/ip_frag_common.h @@ -8,11 +8,11 @@ #include "rte_ip_frag.h" /* logging macros. */ -#ifdef RTE_LIBRTE_IP_FRAG_DEBUG +#ifdef RTE_DEBUG #define IP_FRAG_LOG(lvl, fmt, args...) RTE_LOG(lvl, USER1, fmt, ##args) #else #define IP_FRAG_LOG(lvl, fmt, args...) do {} while(0) -#endif /* IP_FRAG_DEBUG */ +#endif /* RTE_DEBUG */ #define IPV4_KEYLEN 1 #define IPV6_KEYLEN 4 -- 2.17.1